similar to: [PATCH v3 1/6] virtio_balloon: transitional interface

On Tue, Apr 14, 2015 at 11:50:53AM +0200, Cornelia Huck wrote: > On Tue, 14 Apr 2015 11:21:11 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h > > index f81b220..164e0c2 100644 > > --- a/include/uapi/linux/virtio_balloon.h > > +++

On Tue, Apr 14, 2015 at 10:24:38AM +0200, Cornelia Huck wrote: > On Tue, 14 Apr 2015 10:42:56 +0930 > Rusty Russell <rusty at rustcorp.com.au> wrote: > > > "Michael S. Tsirkin" <mst at redhat.com> writes: > > > On Wed, Apr 01, 2015 at 02:57:35PM +0200, Michael S. Tsirkin wrote: > > >> Virtio 1.0 doesn't include a modern balloon device.

"Michael S. Tsirkin" <mst at redhat.com> writes: > On Tue, Apr 14, 2015 at 11:50:53AM +0200, Cornelia Huck wrote: >> On Tue, 14 Apr 2015 11:21:11 +0200 >> "Michael S. Tsirkin" <mst at redhat.com> wrote: >> >> > diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h >> > index f81b220..164e0c2

"Michael S. Tsirkin" <mst at redhat.com> writes: > On Tue, Apr 14, 2015 at 11:50:53AM +0200, Cornelia Huck wrote: >> On Tue, 14 Apr 2015 11:21:11 +0200 >> "Michael S. Tsirkin" <mst at redhat.com> wrote: >> >> > diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h >> > index f81b220..164e0c2

Looks like we are better off sticking with the misaligned stat struct, to reduce the amount of virtio 1 specific code in balloon. So let's do it. Add a detailed comment to reduce the chance people copy this bad example. This also fixes a bug on BE architectures: tag should use cpu_to_le16, not cpu_to_le32. Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com> Signed-off-by: Michael

Looks like we are better off sticking with the misaligned stat struct, to reduce the amount of virtio 1 specific code in balloon. So let's do it. Add a detailed comment to reduce the chance people copy this bad example. This also fixes a bug on BE architectures: tag should use cpu_to_le16, not cpu_to_le32. Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com> Signed-off-by: Michael

Virtio 1.0 doesn't include a modern balloon device. But it's not a big change to support a transitional balloon device: this has the advantage of supporting existing drivers, transparently. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_balloon.h | 11 +++++++++-- drivers/virtio/virtio_balloon.c | 29 +++++++++++++++++++++-------- 2 files

Virtio 1.0 doesn't include a modern balloon device. But it's not a big change to support a transitional balloon device: this has the advantage of supporting existing drivers, transparently. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_balloon.h | 11 +++++++++-- drivers/virtio/virtio_balloon.c | 29 +++++++++++++++++++++-------- 2 files

"Michael S. Tsirkin" <mst at redhat.com> writes: > Virtio 1.0 doesn't include a modern balloon device. > But it's not a big change to support a transitional > balloon device: this has the advantage of supporting > existing drivers, transparently. You decided to fix the packed struct... > diff --git a/drivers/virtio/virtio_balloon.c

On Tue, 14 Apr 2015 11:21:11 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h > index f81b220..164e0c2 100644 > --- a/include/uapi/linux/virtio_balloon.h > +++ b/include/uapi/linux/virtio_balloon.h > @@ -52,15 +52,31 @@ struct virtio_balloon_config { > #define

On Tue, 14 Apr 2015 11:21:11 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h > index f81b220..164e0c2 100644 > --- a/include/uapi/linux/virtio_balloon.h > +++ b/include/uapi/linux/virtio_balloon.h > @@ -52,15 +52,31 @@ struct virtio_balloon_config { > #define

Virtio 1.0 doesn't include a modern balloon device. But it's not a big change to support a transitional balloon device: this has the advantage of supporting existing drivers, transparently. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_balloon.h | 6 ++++++ drivers/virtio/virtio_balloon.c | 8 ++++++-- 2 files changed, 12 insertions(+), 2

Virtio 1.0 doesn't include a modern balloon device. But it's not a big change to support a transitional balloon device: this has the advantage of supporting existing drivers, transparently. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_balloon.h | 6 ++++++ drivers/virtio/virtio_balloon.c | 8 ++++++-- 2 files changed, 12 insertions(+), 2

On Tue, 14 Apr 2015 10:42:56 +0930 Rusty Russell <rusty at rustcorp.com.au> wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > On Wed, Apr 01, 2015 at 02:57:35PM +0200, Michael S. Tsirkin wrote: > >> Virtio 1.0 doesn't include a modern balloon device. At some point we'll likely > >> define an incompatible interface with a

On Tue, 14 Apr 2015 10:42:56 +0930 Rusty Russell <rusty at rustcorp.com.au> wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > On Wed, Apr 01, 2015 at 02:57:35PM +0200, Michael S. Tsirkin wrote: > >> Virtio 1.0 doesn't include a modern balloon device. At some point we'll likely > >> define an incompatible interface with a

Balloon is LE, it's cleaner to access it as such directly. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_balloon.c | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 8bc1704ffdf3..31cc97f2f515 100644 --- a/drivers/virtio/virtio_balloon.c

On Thu, Mar 03, 2016 at 06:44:26PM +0800, Liang Li wrote: > Extend the virtio balloon device to support a new feature, this > new feature can help to get guest's free pages information, which > can be used for live migration optimzation. > > Signed-off-by: Liang Li <liang.z.li at intel.com> I don't understand why we need a new interface. Balloon already sends free

On Wed, May 18, 2016 at 03:38:53PM +0300, Michael S. Tsirkin wrote: > Everything should be LE when using virtio-1, but > the linux balloon driver does not seem to care about that. > > Cc: stable at vger.kernel.org > Reported-by: Cornelia Huck <cornelia.huck at de.ibm.com> > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Forgot to CC stable. Please consider

From: "Michael S. Tsirkin" <mst at redhat.com> [ Upstream commit 835a6a649d0dd1b1f46759eb60fff2f63ed253a7 ] This reverts commit 5a6b4cc5b7a1892a8d7f63d6cbac6e0ae2a9d031. It has been queued properly in the akpm tree, this version is just creating conflicts. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Sasha Levin <sashal at kernel.org> ---

From: Greg Kroah-Hartman <gregkh at linuxfoundation.org> This reverts commit 37681282be8e89ae8baf26753bf489837d74e08e which is commit 835a6a649d0dd1b1f46759eb60fff2f63ed253a7 upstream. Jiri and David agree that it is not needed in the 5.6.y tree, so revert it. Reported-by: Jiri Slaby <jslaby at suse.cz> Reported-by: David Hildenbrand <david at redhat.com> Cc: Michael S.