similar to: [klibc:master] Kbuild: Add "-fcommon" for clang builds

Commit-ID: 9eddaf50ea1b837979e49f996a2609a012218837 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=9eddaf50ea1b837979e49f996a2609a012218837 Author: Bill Wendling <morbo at google.com> AuthorDate: Sun, 29 Mar 2020 04:38:30 -0700 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Sat, 25 Jul 2020 20:45:34 +0100 [klibc] Kbuild: add support for clang

Clang defaults to "-fno-common" which causes linking errors because of duplicate symbols in the BSS section. Signed-off-by: Bill Wendling <morbo at google.com> --- usr/klibc/arch/x86_64/MCONFIG | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr/klibc/arch/x86_64/MCONFIG b/usr/klibc/arch/x86_64/MCONFIG index a6ba7c85c68b..46d29985bfd6 100644 ---

Add cc-name to klibc/scripts/Kbuild.include. Make optimization flags not supported by clang conditional on cc-name. Use "--print-file-name=include" and "--print-libgcc-file-name" when using clang. Use cc-option to enable compiler-specific flags. Mark "bcmp" as not a builtin to prevent clang from using it. Signed-off-by: Bill Wendling <morbo at google.com>

On Fri, 2020-03-27 at 15:29 -0700, Bill Wendling wrote: > Clang doesn't have a suitable replacement for libgcc readily available. > Supply one that we know exists. Use "-fno-builtin-bcmp" to prevent clang > from calling a function that doesn't exist. Doesn't this contradict the comment added for KLIBCLIBGCC_DEF? > Signed-off-by: Bill Wendling <morbo at

New clang versions need the '-ffreestanding' flag because new changes convert system calls to their unlocked versions, which don't exist in the kernel library. Signed-off-by: Bill Wendling <morbo at google.com> diff --git a/scripts/Kbuild.klibc b/scripts/Kbuild.klibc index f500d535..9cf4b2d9 100644 --- a/scripts/Kbuild.klibc +++ b/scripts/Kbuild.klibc @@ -67,7 +67,8 @@ include

- Renamed IMAGE_BASE to LD_IMAGE_BASE_OPT. - Moved "-fcommon" to KLIBCREQFLAGS in scripts/Kbuild.klibc. - Remove "dash" warning fixes which have been upstreamed. - Conditionalize the inclusion of compiler flags by using the proper compiler name or "cc-option". - Added "-Werror" to "cc-option" to catch flags that cause warnings. - Retain

Clang doesn't have a suitable replacement for libgcc readily available. Supply one that we know exists. Use "-fno-builtin-bcmp" to prevent clang from calling a function that doesn't exist. Signed-off-by: Bill Wendling <morbo at google.com> --- scripts/Kbuild.klibc | 2 ++ usr/klibc/arch/x86_64/MCONFIG | 2 ++ 2 files changed, 4 insertions(+) diff --git

On Sun, 2020-03-29 at 04:38 -0700, Bill Wendling wrote: > - Renamed IMAGE_BASE to LD_IMAGE_BASE_OPT. > - Moved "-fcommon" to KLIBCREQFLAGS in scripts/Kbuild.klibc. > - Remove "dash" warning fixes which have been upstreamed. > - Conditionalize the inclusion of compiler flags by using the proper > compiler name or "cc-option". > - Added

On Sat, 2020-07-25 at 17:47 +0100, Ben Hutchings wrote: > On Sun, 2020-03-29 at 04:38 -0700, Bill Wendling wrote: > > - Renamed IMAGE_BASE to LD_IMAGE_BASE_OPT. > > - Moved "-fcommon" to KLIBCREQFLAGS in scripts/Kbuild.klibc. > > - Remove "dash" warning fixes which have been upstreamed. > > - Conditionalize the inclusion of compiler flags by using the

On Sat, Jul 25, 2020 at 1:57 PM Ben Hutchings <ben at decadent.org.uk> wrote: > > On Sat, 2020-07-25 at 17:47 +0100, Ben Hutchings wrote: > > On Sun, 2020-03-29 at 04:38 -0700, Bill Wendling wrote: > > > - Renamed IMAGE_BASE to LD_IMAGE_BASE_OPT. > > > - Moved "-fcommon" to KLIBCREQFLAGS in scripts/Kbuild.klibc. > > > - Remove "dash"

-fcommon is not default anymore, with GCC 10 you get the following failure without it: KLIBCLD usr/klibc/libc.so ppc-linux-ld: usr/klibc/globals.o:/root/packages/klibc-2.0.7/usr/klibc/../include/unistd.h:15: multiple definition of `environ'; usr/klibc/__shared_init.o:/root/ldb_base/ofl/packages/klibc-2.0.7/usr/klibc/libc_init.c:42: first defined here ppc-linux-ld:

On Sat, Jul 25, 2020 at 4:10 PM Ben Hutchings <ben at decadent.org.uk> wrote: > On Sat, 2020-07-25 at 15:16 -0700, Bill Wendling wrote: > > On Sat, Jul 25, 2020 at 2:56 PM Ben Hutchings <ben at decadent.org.uk> wrote: > > > On Sat, 2020-07-25 at 14:36 -0700, Bill Wendling wrote: > > > [...] > > > > I upstreamed a few patches to klibc to fix a few

From: Michael Davidson <md at google.com> Add cc-name to klibc/scripts/Kbuild.include. Make optimization flags not supported by clang conditional on cc-name. Don't use -nostdinc when building klibc. While klibc doesn't (shouldn't) use the standard header files supplied by the toolchain, it does still need to be able to find the compiler-specific header file

Commit-ID: cc71445234fcd4f74b137cdebd10136e882cd289 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=cc71445234fcd4f74b137cdebd10136e882cd289 Author: Ben Hutchings <ben at decadent.org.uk> AuthorDate: Sun, 20 Jan 2019 19:15:10 +0000 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Sun, 20 Jan 2019 21:15:17 +0000 [klibc] Kbuild: Enable full debug

This is a series of patches for clang compatibility: - Using flags needed flags and removing unsupported flags. - Adding support for clang's LLD linker. - Removing a variety of warnings. Bill Wendling (3): [klibc] Kbuild: use "libc.a" with clang [klibc] Kbuild: Add "-fcommon" for clang builds [klibc] Clean up clang warnings Michael Davidson (1): [klibc] Kbuild:

On Fri, 2020-03-27 at 15:29 -0700, Bill Wendling wrote: > From: Michael Davidson <md at google.com> > > Add cc-name to klibc/scripts/Kbuild.include. [...] > --- a/scripts/Kbuild.klibc > +++ b/scripts/Kbuild.klibc > @@ -107,8 +107,15 @@ KLIBCOBJCOPY := $(OBJCOPY) > KLIBCOBJDUMP := $(OBJDUMP) > > # klibc include paths > -KLIBCCPPFLAGS := -nostdinc

Commit-ID: 9d8d648e604026b32cad00a84ed6c29cbd157641 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=9d8d648e604026b32cad00a84ed6c29cbd157641 Author: Ben Hutchings <ben at decadent.org.uk> AuthorDate: Sat, 29 Feb 2020 00:03:20 +0000 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Sat, 29 Feb 2020 00:11:26 +0000 [klibc] Kbuild: Tell gas we

Commit-ID: 312b3d0a38ff2e43becd47cf1f4a930bc0c4b8e6 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=312b3d0a38ff2e43becd47cf1f4a930bc0c4b8e6 Author: Ben Hutchings <ben at decadent.org.uk> AuthorDate: Wed, 29 Apr 2020 22:24:33 +0100 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Sat, 25 Jul 2020 17:33:29 +0100 Revert "[klibc] Kbuild: Tell

Commit-ID: c562319cdba0102c3a8a8298ba94e645418193d5 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=c562319cdba0102c3a8a8298ba94e645418193d5 Author: Ben Hutchings <ben at decadent.org.uk> AuthorDate: Wed, 29 Apr 2020 22:28:10 +0100 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Sat, 25 Jul 2020 17:33:29 +0100 [klibc] Kbuild: Add a

Commit-ID: 84d319b2fda958d73a58bf338ee212da772d0cc6 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=84d319b2fda958d73a58bf338ee212da772d0cc6 Author: Ben Hutchings <ben at decadent.org.uk> AuthorDate: Sun, 6 Jan 2019 03:44:40 +0000 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Fri, 18 Jan 2019 03:10:14 +0000 [klibc] Disable PIE We link all