similar to: usr/dash/eval.c:277:19: warning: logical not is only applied to the left hand side of comparison

Hi Christophe. On Tue, Jan 22, 2019 at 04:53:05PM +0000, Christophe Leroy wrote: > ? KLIBCCC usr/dash/eval.o > usr/dash/eval.c: In function 'evaltree': > usr/dash/eval.c:277:19: warning: logical not is only applied to the > left hand side of comparison [-Wlogical-not-parentheses] > ?? if (!exitstatus == isor) > ?????????????????? ^ > > Not sure what the fix should

Hi! > Any idea ? I believe that: if (!exitstatus == isor) equals to, if ((!exitstatus) == isor) because the exclamation mark have bigger priority than "==". Nikita.

Commit-ID: 777b77571a451d5fc5dfc04749854ea40abe8093 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=777b77571a451d5fc5dfc04749854ea40abe8093 Author: Herbert Xu <herbert at gondor.apana.org.au> AuthorDate: Tue, 7 Jun 2016 16:47:59 +0800 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Sat, 28 Mar 2020 21:42:54 +0000 [klibc] dash: eval: Return

Commit-ID: ef5fd2060f3c7d1a4a22a079bc1c32b61964bb5f Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=ef5fd2060f3c7d1a4a22a079bc1c32b61964bb5f Author: Herbert Xu <herbert at gondor.apana.org.au> AuthorDate: Tue, 7 Jun 2016 16:47:59 +0800 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Fri, 25 Jan 2019 02:57:21 +0000 [klibc] eval: Return status in

Commit-ID: e3da328217a1fbfaad2ae617dbc26746adf63f8f Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=e3da328217a1fbfaad2ae617dbc26746adf63f8f Author: Antonio Ospite <ao2 at ao2.it> AuthorDate: Tue, 16 Oct 2018 18:42:20 +0200 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Sat, 28 Mar 2020 21:42:55 +0000 [klibc] dash: eval: Silence compiler

Commit-ID: c970d7573aa382c89d3c71b88cd10f4c6a464264 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=c970d7573aa382c89d3c71b88cd10f4c6a464264 Author: Antonio Ospite <ao2 at ao2.it> AuthorDate: Tue, 16 Oct 2018 18:42:20 +0200 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Fri, 25 Jan 2019 02:57:21 +0000 [klibc] [PATCH] eval: Silence compiler

Commit-ID: 2993257551260450b6471d0650bec6e859cafed4 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=2993257551260450b6471d0650bec6e859cafed4 Author: Herbert Xu <herbert at gondor.apana.org.au> AuthorDate: Fri, 14 Dec 2018 13:44:14 +0800 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Sat, 28 Mar 2020 21:42:55 +0000 [klibc] dash: eval: avoid

- Convert the "old style" GNU field designator extension to the new style. - Use proper indexing into a string literal. - Use "%s" for the format string in "fmtstr". - Add or remove casts of the "void *" argument of ioctl. - Convert "if (!exitstatus == isor)" to "if ((!exitstatus) == isor)" which retains the current semantics, but may

Many warnings are encountered with GCC 10. Fix them. Signed-off-by: Christophe Leroy <christophe.leroy at csgroup.eu> --- usr/dash/eval.c | 2 +- usr/klibc/zlib/infback.c | 2 +- usr/klibc/zlib/inflate.c | 20 ++++++++++++++++++++ 3 files changed, 22 insertions(+), 2 deletions(-) diff --git a/usr/dash/eval.c b/usr/dash/eval.c index dd144948a9fa..6b2b01e19a47 100644 ---

Commit-ID: 9a10962c04d36abbeaa11ca47227f6ca6cacd1ce Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=9a10962c04d36abbeaa11ca47227f6ca6cacd1ce Author: Herbert Xu <herbert at gondor.apana.org.au> AuthorDate: Mon, 6 Oct 2014 20:45:04 +0800 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Sat, 28 Mar 2020 21:42:54 +0000 [klibc] dash: [EVAL] Move

This is a series of patches for clang compatibility: - Using flags needed flags and removing unsupported flags. - Adding support for clang's LLD linker. - Removing a variety of warnings. Bill Wendling (3): [klibc] Kbuild: use "libc.a" with clang [klibc] Kbuild: Add "-fcommon" for clang builds [klibc] Clean up clang warnings Michael Davidson (1): [klibc] Kbuild:

Commit-ID: dde2b81c52d389b21abd0814dac5a4988be80725 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=dde2b81c52d389b21abd0814dac5a4988be80725 Author: Herbert Xu <herbert at gondor.apana.org.au> AuthorDate: Mon, 6 Oct 2014 20:45:04 +0800 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Fri, 25 Jan 2019 02:57:21 +0000 [klibc] [EVAL] Move common

New clangs emit some warnings. The code isn't wrong, but should be updated to prevent warning creep. Bill Wendling (3): [klibc] dash: shell: Fix clang warnings [klibc] dash: shell: Fix clang warnings about format string [klibc] Kbuild: use an enum to silence a clang warning usr/dash/eval.c | 6 +++--- usr/dash/jobs.c | 2 +- usr/kinit/nfsmount/dummypmap.c

Commit-ID: 54653f129781515d3eaff2aa26078ef376bc5a6f Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=54653f129781515d3eaff2aa26078ef376bc5a6f Author: Harald van Dijk <harald at gigawatt.nl> AuthorDate: Tue, 7 Jun 2016 16:35:41 +0800 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Sat, 28 Mar 2020 21:42:54 +0000 [klibc] dash: eval: Fix exit

Commit-ID: d431641e217fa4f75e63b8ee817dc97cda9a2976 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=d431641e217fa4f75e63b8ee817dc97cda9a2976 Author: Harald van Dijk <harald at gigawatt.nl> AuthorDate: Tue, 7 Jun 2016 16:35:41 +0800 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Fri, 25 Jan 2019 02:57:21 +0000 [klibc] eval: Fix exit status when

On Tue, Jan 22, 2019 at 08:23:15PM +0100, Sam Ravnborg wrote: > So one could backport this fix. > But a better approach was maybe to upgrade to latest dash version. > yes, indeed upgrading dash is the best way. In the past, we imported latest dash from time to time. thanks to Ben for all of his work!

Commit-ID: 9d16e7c25d87057eae0b8bbbd512dd768f409e01 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=9d16e7c25d87057eae0b8bbbd512dd768f409e01 Author: Herbert Xu <herbert at gondor.apana.org.au> AuthorDate: Thu, 2 Oct 2014 19:49:48 +0800 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Sat, 28 Mar 2020 21:42:54 +0000 [klibc] dash: [TRAP] Make sure

Commit-ID: e6ebc6f4137090ec4ce858bdb0fe674774173e57 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=e6ebc6f4137090ec4ce858bdb0fe674774173e57 Author: Herbert Xu <herbert at gondor.apana.org.au> AuthorDate: Thu, 2 Oct 2014 19:49:48 +0800 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Fri, 25 Jan 2019 02:57:21 +0000 [klibc] [TRAP] Make sure

Commit-ID: e49a1160b58933c257c27603aa3d020daf8e0943 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=e49a1160b58933c257c27603aa3d020daf8e0943 Author: Herbert Xu <herbert at gondor.apana.org.au> AuthorDate: Fri, 3 Oct 2014 14:07:07 +0800 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Sat, 28 Mar 2020 21:42:54 +0000 [klibc] dash: [EVAL] Do not

Commit-ID: 1fc5f5a5a8704d47b71b01cc0ab734a4d2976d37 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=1fc5f5a5a8704d47b71b01cc0ab734a4d2976d37 Author: Herbert Xu <herbert at gondor.apana.org.au> AuthorDate: Fri, 3 Oct 2014 14:07:07 +0800 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Fri, 25 Jan 2019 02:57:21 +0000 [klibc] [EVAL] Do not clobber