similar to: [PATCH -next] drm/nouveau/kms/nvd9-: Fix file release memory leak

This is not complete documentation, but covers the pieces I read through while reviewing the IGT CRC tests for nouveau. It covers the nouveau-specific debugfs file, an overview of why the code is more complicated than the DRM display CRC support documentation would lead one to expect, and the nv50_crc_func vtable. Many of the details were gleaned from Lyude's commit message, but I think

Reviewed-by: Karol Herbst <kherbst at redhat.com> On Thu, Sep 5, 2019 at 9:14 AM Wei Yongjun <weiyongjun1 at huawei.com> wrote: > > When using single_open() for opening, single_release() should be > used, otherwise there is a memory leak. > > This is detected by Coccinelle semantic patch. > > Fixes: 6e9fc177399f ("drm/nouveau/debugfs: add copy of sysfs pstate

When using single_open() for opening, single_release() should be used, otherwise there is a memory leak. This is detected by Coccinelle semantic patch. Fixes: 6e9fc177399f ("drm/nouveau/debugfs: add copy of sysfs pstate interface ported to debugfs") Signed-off-by: Wei Yongjun <weiyongjun1 at huawei.com> --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 1 + 1 file changed, 1

This introduces support for CRC readback on gf119+, using the documentation generously provided to us by Nvidia: https://github.com/NVIDIA/open-gpu-doc/blob/master/Display-CRC/display-crc.txt We expose all available CRC sources. SF, SOR, PIOR, and DAC are exposed through a single set of "outp" sources: outp-active/auto for a CRC of the scanout region, outp-complete for a CRC of both

This introduces support for CRC readback on gf119+, using the documentation generously provided to us by Nvidia: https://github.com/NVIDIA/open-gpu-doc/blob/master/Display-CRC/display-crc.txt We expose all available CRC sources. SF, SOR, PIOR, and DAC are exposed through a single set of "outp" sources: outp-active/auto for a CRC of the scanout region, outp-complete for a CRC of both

This introduces support for CRC readback on gf119+, using the documentation generously provided to us by Nvidia: https://github.com/NVIDIA/open-gpu-doc/blob/master/Display-CRC/display-crc.txt We expose all available CRC sources. SF, SOR, PIOR, and DAC are exposed through a single set of "outp" sources: outp-active/auto for a CRC of the scanout region, outp-complete for a CRC of both

This introduces support for CRC readback on gf119+, using the documentation generously provided to us by Nvidia: https://github.com/NVIDIA/open-gpu-doc/blob/master/Display-CRC/display-crc.txt We expose all available CRC sources. SF, SOR, PIOR, and DAC are exposed through a single set of "outp" sources: outp-active/auto for a CRC of the scanout region, outp-complete for a CRC of both

Looks like I made the mistake of forgetting to check whether or not this would build without CONFIG_DEBUG_FS, as the Kbuild bot reported some issues building with tegra_defconfig: In file included from drivers/gpu/drm/nouveau/nouveau_display.c:47: ./drivers/gpu/drm/nouveau/dispnv50/crc.h: In function ?nv50_head_crc_late_register?: ./drivers/gpu/drm/nouveau/dispnv50/crc.h:106:47: error: parameter

https://bugs.freedesktop.org/show_bug.cgi?id=43731 Bug #: 43731 Summary: No support for DP on NVD9 Classification: Unclassified Product: xorg Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Driver/nouveau

https://bugs.freedesktop.org/show_bug.cgi?id=89047 Bug ID: 89047 Summary: linux-3.19 nvd9 Invalid rom content Product: xorg Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Driver/nouveau Assignee: nouveau at

https://bugs.freedesktop.org/show_bug.cgi?id=54646 Bug #: 54646 Summary: i2c failure on Quadro NVS 4200M (GF119 (NVD9)) Classification: Unclassified Product: xorg Version: unspecified Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Driver/nouveau

https://bugs.freedesktop.org/show_bug.cgi?id=78361 Priority: medium Bug ID: 78361 Assignee: nouveau at lists.freedesktop.org Summary: [NVD9] Screen frozen on resume from suspend QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified OS: Linux (All) Reporter: R.Palmer at

I'm here and alive. I submitted my problem somewhere and have been getting emails related to nouveau ever since. Yes there is a craigcgarner at gmail.com I am glad to be following along with these bugs as they directly affect me and my system :) This where I reported the problem nouveau at lists.freedesktop.org The other buglist just started ? Thank you, Craig On Wed, Dec 9, 2015 at

https://bugs.freedesktop.org/show_bug.cgi?id=79795 Priority: medium Bug ID: 79795 Assignee: nouveau at lists.freedesktop.org Summary: [NVD9] No devices detected QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified OS: Linux (All) Reporter: mail at tcrueger.de

https://bugs.freedesktop.org/show_bug.cgi?id=55948 Priority: medium Bug ID: 55948 Assignee: nouveau at lists.freedesktop.org Summary: [nvd9 optimus] drm/nouveau/bios: attempt to fetch entire acpi rom image in one shot breaks module load QA Contact: xorg-team at lists.x.org Severity: major Classification:

From: Wei Yongjun <weiyongjun1 at huawei.com> The error return code PTR_ERR(mc) is always 0 since mc is equal to 0 in this error handling case. Signed-off-by: Wei Yongjun <weiyongjun1 at huawei.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm20b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm20b.c

From: Wei Yongjun <weiyongjun1 at huawei.com> Date: Thu, 31 May 2018 02:05:07 +0000 > Fix to return a negative error code from the failover create fail error > handling case instead of 0, as done elsewhere in this function. > > Fixes: ba5e4426e80e ("virtio_net: Extend virtio to use VF datapath when available") > Signed-off-by: Wei Yongjun <weiyongjun1 at

https://bugs.freedesktop.org/show_bug.cgi?id=80769 Priority: medium Bug ID: 80769 Assignee: nouveau at lists.freedesktop.org Summary: [NVD9] GF119M boot hang with 3.15.2 QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified OS: Linux (All) Reporter: sven.pilz+freedesktop at

https://bugs.freedesktop.org/show_bug.cgi?id=71662 Priority: medium Bug ID: 71662 Assignee: nouveau at lists.freedesktop.org Summary: [nvd9 regression] 3d application hang Severity: normal Classification: Unclassified OS: All Reporter: jano.vesely at gmail.com Hardware: Other Status: NEW

While I had thought I'd tested this before, it looks like this one issue slipped by my original CRC patches. Basically, there seem to be a few rules we need to follow when sending CRC commands to the display controller: * CRCs cannot be both disabled and enabled for a single head in the same flush * If a head with CRC reporting enabled switches from one OR to another, there must be a