similar to: [PATCH] x86: mmiotrace: Use cpumask_available for cpumask_var_t variables

On Mon, May 18, 2020 at 2:31 AM Nathan Chancellor <natechancellor at gmail.com> wrote: > > On Wed, Apr 08, 2020 at 01:53:23PM -0700, Nathan Chancellor wrote: > > When building with Clang + -Wtautological-compare and > > CONFIG_CPUMASK_OFFSTACK unset: > > > > arch/x86/mm/mmio-mod.c:375:6: warning: comparison of array 'downed_cpus' > > equal to a

On Wed, Apr 8, 2020 at 10:53 PM Nathan Chancellor <natechancellor at gmail.com> wrote: > > When building with Clang + -Wtautological-compare and > CONFIG_CPUMASK_OFFSTACK unset: > Hi Nathan, thanks for the quick patch. I can confirm I have no CONFIG_CPUMASK_OFFSTACK set. Regards, - Sedat - > arch/x86/mm/mmio-mod.c:375:6: warning: comparison of array 'downed_cpus'

On Wed, Apr 8, 2020 at 11:12 PM Sedat Dilek <sedat.dilek at gmail.com> wrote: > > On Wed, Apr 8, 2020 at 10:53 PM Nathan Chancellor > <natechancellor at gmail.com> wrote: > > > > When building with Clang + -Wtautological-compare and > > CONFIG_CPUMASK_OFFSTACK unset: > > > > Hi Nathan, > > thanks for the quick patch. > > I can confirm

On Wed, Apr 08, 2020 at 01:53:23PM -0700, Nathan Chancellor wrote: > When building with Clang + -Wtautological-compare and > CONFIG_CPUMASK_OFFSTACK unset: > > arch/x86/mm/mmio-mod.c:375:6: warning: comparison of array 'downed_cpus' > equal to a null pointer is always false [-Wtautological-pointer-compare] > if (downed_cpus == NULL && >

On Mon, 18 May 2020 11:52:47 -0700 Nick Desaulniers <ndesaulniers at google.com> wrote: > On Mon, May 18, 2020 at 2:31 AM Nathan Chancellor > <natechancellor at gmail.com> wrote: > > > > On Wed, Apr 08, 2020 at 01:53:23PM -0700, Nathan Chancellor wrote: > > > When building with Clang + -Wtautological-compare and > > > CONFIG_CPUMASK_OFFSTACK

On Wed, 8 Apr 2020 13:53:23 -0700 Nathan Chancellor <natechancellor at gmail.com> wrote: > When building with Clang + -Wtautological-compare and > CONFIG_CPUMASK_OFFSTACK unset: > > arch/x86/mm/mmio-mod.c:375:6: warning: comparison of array 'downed_cpus' > equal to a null pointer is always false [-Wtautological-pointer-compare] > if (downed_cpus == NULL

Clang warns when CONFIG_BALLOON_COMPACTION is unset: ../drivers/virtio/virtio_balloon.c:963:1: warning: unused label 'out_del_vqs' [-Wunused-label] out_del_vqs: ^~~~~~~~~~~~ 1 warning generated. Move the label within the preprocessor block since it is only used when CONFIG_BALLOON_COMPACTION is set. Fixes: 1ad6f58ea936 ("virtio_balloon: Fix memory leaks on errors in

Clang warns when CONFIG_BALLOON_COMPACTION is unset: ../drivers/virtio/virtio_balloon.c:963:1: warning: unused label 'out_del_vqs' [-Wunused-label] out_del_vqs: ^~~~~~~~~~~~ 1 warning generated. Move the label within the preprocessor block since it is only used when CONFIG_BALLOON_COMPACTION is set. Fixes: 1ad6f58ea936 ("virtio_balloon: Fix memory leaks on errors in

On Sun, Feb 16, 2020 at 08:36:45AM +0100, David Hildenbrand wrote: > > > > Am 16.02.2020 um 01:41 schrieb Nathan Chancellor <natechancellor at gmail.com>: > > > > ?Clang warns when CONFIG_BALLOON_COMPACTION is unset: > > > > ../drivers/virtio/virtio_balloon.c:963:1: warning: unused label > > 'out_del_vqs' [-Wunused-label] > >

Clang warns: drivers/vhost/vhost.c:2085:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined] #if VHOST_ARCH_CAN_ACCEL_UACCESS ^ drivers/vhost/vhost.h:98:38: note: expanded from macro 'VHOST_ARCH_CAN_ACCEL_UACCESS' #define VHOST_ARCH_CAN_ACCEL_UACCESS defined(CONFIG_MMU_NOTIFIER) && \

Clang warns: drivers/vhost/vhost.c:2085:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined] #if VHOST_ARCH_CAN_ACCEL_UACCESS ^ drivers/vhost/vhost.h:98:38: note: expanded from macro 'VHOST_ARCH_CAN_ACCEL_UACCESS' #define VHOST_ARCH_CAN_ACCEL_UACCESS defined(CONFIG_MMU_NOTIFIER) && \

On recent builds of R-devel, R CMD check gives a WARNING when some compiler warning flags are detected, such as -Werror, because they are non-portable. This appears to have been added in this commit: https://github.com/wch/r-source/commit/2e80059 I'm working on a package where these compiler warning flags are present in a Makefile generated by a configure script -- that is, the configure

>> On recent builds of R-devel, R CMD check gives a WARNING when some >> compiler warning flags are detected, such as -Werror, because they are >> non-portable. This appears to have been added in this commit: >> https://github.com/wch/r-source/commit/2e80059 > > That is not the canonical R sources. Yes, that is obvious. The main page for that repository says it is

Clang warns: kernel/resource.c:1281:53: warning: operator '?:' has lower precedence than '|'; '|' will be evaluated first [-Wbitwise-conditional-parentheses] new_res = alloc_resource(GFP_KERNEL | alloc_nofail ? __GFP_NOFAIL : 0); ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ kernel/resource.c:1281:53: note: place parentheses around the '|'

Clang warns several times when building for 32-bit ARM along the lines of: drivers/vdpa/mlx5/net/mlx5_vnet.c:1462:31: warning: shift count >= width of type [-Wshift-count-overflow] ndev->mvdev.mlx_features |= BIT(VIRTIO_F_VERSION_1); ^~~~~~~~~~~~~~~~~~~~~~~ This is related to the BIT macro, which uses an unsigned long literal,

Clang warns several times when building for 32-bit ARM along the lines of: drivers/vdpa/mlx5/net/mlx5_vnet.c:1462:31: warning: shift count >= width of type [-Wshift-count-overflow] ndev->mvdev.mlx_features |= BIT(VIRTIO_F_VERSION_1); ^~~~~~~~~~~~~~~~~~~~~~~ This is related to the BIT macro, which uses an unsigned long literal,

From: Borislav Petkov <bp at suse.de> Fix drivers/virtio/virtio_balloon.c: In function ?virtballoon_probe?: drivers/virtio/virtio_balloon.c:963:1: warning: label ?out_del_vqs? defined but not used [-Wunused-label] 963 | out_del_vqs: | ^~ The CONFIG_BALLOON_COMPACTION ifdeffery should enclose it too. Signed-off-by: Borislav Petkov <bp at suse.de> Cc: David

From: Borislav Petkov <bp at suse.de> Fix drivers/virtio/virtio_balloon.c: In function ?virtballoon_probe?: drivers/virtio/virtio_balloon.c:963:1: warning: label ?out_del_vqs? defined but not used [-Wunused-label] 963 | out_del_vqs: | ^~ The CONFIG_BALLOON_COMPACTION ifdeffery should enclose it too. Signed-off-by: Borislav Petkov <bp at suse.de> Cc: David

So ever since syzbot discovered fbcon, we have solid proof that it's full of bugs. And often the solution is to just delete code and remove features, e.g. 50145474f6ef ("fbcon: remove soft scrollback code"). Now the problem is that most modern-ish drivers really only treat fbcon as an dumb kernel console until userspace takes over, and Oops printer for some emergencies. Looking at

>>>>> Duncan Murdoch <murdoch.duncan at gmail.com> >>>>> on Thu, 21 Dec 2017 14:23:13 -0500 writes: > On 21/12/2017 1:02 PM, Winston Chang wrote: >>>> On recent builds of R-devel, R CMD check gives a >>>> WARNING when some compiler warning flags are detected, >>>> such as -Werror, because they are