similar to: [PATCH] drm/nouveau/dispnv04: subdev/bios.h is included more than once

remove duplicate inclusion of nvif/device.h Issue identified by includecheck Signed-off-by: Hariprasad Kelam <hariprasad.kelam at gmail.com> --- drivers/gpu/drm/nouveau/nouveau_drv.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.h b/drivers/gpu/drm/nouveau/nouveau_drv.h index 35ff0ca..cfebb14 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drv.h +++

In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Signed-off-by: Ma Ke <make_ruc2021 at 163.com> --- drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c

fix the following 'make includecheck' warning: drivers/xen/evtchn.c: linux/errno.h is included more than once. Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput at gmail.com> --- drivers/xen/evtchn.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c index af03195..79bedba 100644 --- a/drivers/xen/evtchn.c

fix the following 'make includecheck' warning: drivers/xen/evtchn.c: linux/errno.h is included more than once. Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput at gmail.com> --- drivers/xen/evtchn.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c index af03195..79bedba 100644 --- a/drivers/xen/evtchn.c

fix the following 'make includecheck' warning: drivers/xen/evtchn.c: linux/errno.h is included more than once. Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput at gmail.com> --- drivers/xen/evtchn.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c index af03195..79bedba 100644 --- a/drivers/xen/evtchn.c

nouveau changes up to here are: Reviewed-by: Karol Herbst <kherbst at redhat.com> On Fri, Mar 17, 2023 at 9:23?AM Lee Jones <lee at kernel.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer

The code claims to grab a runtime PM ref when at least one CRTC is active, but that's not actually the case as we grab a runtime PM ref whenever a CRTC is enabled regardless of it's DPMS state. Meaning that we can end up keeping the GPU awake when there are no screens enabled, something we don't really want to do. Note that we fixed this same issue for nv50 a while ago in: commit

Interesting. I do remember seeing some snow on NV5's overlay at high resolutions. Wonder if it was because of this missing code... On Thu, Apr 30, 2020 at 4:19 PM Souptick Joarder <jrdr.linux at gmail.com> wrote: > > These are dead code since 3.10. If there is no plan to use > it further, these can be removed forever. > > Signed-off-by: Souptick Joarder <jrdr.linux at

In nv17_tv_get_hd_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). The same applies to drm_cvt_mode(). Add a check to avoid null pointer dereference. Signed-off-by: Ma Ke <make_ruc2021 at 163.com> --- drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 4 ++++ 1 file changed, 4 insertions(+)

Reviewed-by: Lyude Paul <lyude at redhat.com> On Tue, 2024-06-25 at 16:18 +0800, Ma Ke wrote: > In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate() > is > assigned to mode, which will lead to a possible NULL pointer > dereference > on failure of drm_mode_duplicate(). Add a check to avoid npd. > > Cc: stable at vger.kernel.org > Signed-off-by: Ma Ke

Reviewed-by: Lyude Paul <lyude at redhat.com> I will push this and the other patch that you sent upstream in just a moment, thanks! On Tue, 2024-06-25 at 16:10 +0800, Ma Ke wrote: > In nv17_tv_get_hd_modes(), the return value of drm_mode_duplicate() > is > assigned to mode, which will lead to a possible NULL pointer > dereference > on failure of drm_mode_duplicate(). The

On Wed, Aug 7, 2019 at 5:55 PM Daniel Vetter <daniel at ffwll.ch> wrote: > > On Wed, Aug 07, 2019 at 05:33:00PM -0400, Lyude Paul wrote: > > The code claims to grab a runtime PM ref when at least one CRTC is > > active, but that's not actually the case as we grab a runtime PM ref > > whenever a CRTC is enabled regardless of it's DPMS state. Meaning that >

On Fri, May 1, 2020 at 2:21 AM Ilia Mirkin <imirkin at alum.mit.edu> wrote: > > Interesting. I do remember seeing some snow on NV5's overlay at high > resolutions. Wonder if it was because of this missing code... What was the problem ? Does enabling this dead code will fix the problem ? > > On Thu, Apr 30, 2020 at 4:19 PM Souptick Joarder <jrdr.linux at gmail.com>

fix the following 'make includecheck' warning: drivers/xen/evtchn.c: linux/errno.h is included more than once. Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput at gmail.com> --- drivers/xen/evtchn.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c index af03195..79bedba 100644 --- a/drivers/xen/evtchn.c

fix the following 'make includecheck' warning: drivers/xen/evtchn.c: linux/errno.h is included more than once. Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput at gmail.com> --- drivers/xen/evtchn.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c index af03195..79bedba 100644 --- a/drivers/xen/evtchn.c

fix the following 'make includecheck' warning: drivers/xen/evtchn.c: linux/errno.h is included more than once. Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput at gmail.com> --- drivers/xen/evtchn.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c index af03195..79bedba 100644 --- a/drivers/xen/evtchn.c

Hi, I am planning to guide Engineering Students, to build a MP3 Streaming Server as part of their academic project. I downloaded icecast 2.0.2 & ices 0.4 & went through the documentation & code. I am not able to find technical resources explaining the streaming protocol between Icecast Server & Client (winamp or xmms). We are in need of technical details of streaming protocol,