similar to: [PATCH v3 0/3] drm/connector: Provide generic support for underscan

Hello, This is an attempt at providing generic support for underscan connector props. We already have 3 drivers defining the same underscan, underscan vborder and underscan hborder properties (amd, radeon and nouveau) and I am about to add a new one, hence my proposal to put the prop parsing code in the core and add ->underscan fields to drm_connector_state. Note that I use this new

Hello, This is an attempt at providing generic support for underscan connector props. We already have 3 drivers defining the same underscan, underscan vborder and underscan hborder properties (amd, radeon and nouveau) and I am about to add a new one, hence my proposal to put the prop parsing code in the core and add ->underscan fields to drm_connector_state. In this v2, I also converted the

On Mon, May 07, 2018 at 04:44:32PM +0200, Boris Brezillon wrote: > We have 3 drivers defining the "underscan", "underscan hborder" and > "underscan vborder" properties (radeon, amd and nouveau) and we are > about to add the same kind of thing in VC4. > > Define generic underscan props and add new fields to the drm_connector > state so that the

On Mon, May 07, 2018 at 04:44:32PM +0200, Boris Brezillon wrote: > We have 3 drivers defining the "underscan", "underscan hborder" and > "underscan vborder" properties (radeon, amd and nouveau) and we are > about to add the same kind of thing in VC4. > > Define generic underscan props and add new fields to the drm_connector > state so that the

On 2018-05-07 12:19 PM, Boris Brezillon wrote: > On Mon, 7 May 2018 18:01:44 +0300 > Ville Syrjälä <ville.syrjala at linux.intel.com> wrote: > >> On Mon, May 07, 2018 at 04:44:32PM +0200, Boris Brezillon wrote: >>> We have 3 drivers defining the "underscan", "underscan hborder" and >>> "underscan vborder" properties (radeon, amd

On Fri, May 11, 2018 at 04:59:17PM +0200, Boris Brezillon wrote: > Applying an underscan setup is just a matter of scaling all planes > appropriately and adjusting the CRTC X/Y offset to account for the > horizontal and vertical border. > > Create an vc4_plane_underscan_adj() function doing that and call it from > vc4_plane_setup_clipping_and_scaling() so that we are ready to

On Thu, Nov 22, 2018 at 12:23:29PM +0100, Boris Brezillon wrote: > @@ -924,6 +978,29 @@ struct drm_connector { > */ > struct drm_property_blob *path_blob_ptr; > > + /** > + * @underscan_mode_property: Optional connector underscan mode. Used by > + * the driver to scale the output image and compensate an overscan done > + * on the display side. > + */ > +

On Fri, May 11, 2018 at 05:52:56PM +0200, Boris Brezillon wrote: > On Fri, 11 May 2018 18:34:50 +0300 > Ville Syrjälä <ville.syrjala at linux.intel.com> wrote: > > > On Fri, May 11, 2018 at 04:59:17PM +0200, Boris Brezillon wrote: > > > Applying an underscan setup is just a matter of scaling all planes > > > appropriately and adjusting the CRTC X/Y offset to

On Fri, May 11, 2018 at 07:12:21PM +0200, Boris Brezillon wrote: > On Fri, 11 May 2018 19:54:02 +0300 > Ville Syrjälä <ville.syrjala at linux.intel.com> wrote: > > > On Fri, May 11, 2018 at 05:52:56PM +0200, Boris Brezillon wrote: > > > On Fri, 11 May 2018 18:34:50 +0300 > > > Ville Syrjälä <ville.syrjala at linux.intel.com> wrote: > > >

On Fri, May 11, 2018 at 09:47:49PM +0200, Boris Brezillon wrote: > On Fri, 11 May 2018 20:29:48 +0300 > Ville Syrjälä <ville.syrjala at linux.intel.com> wrote: > > > On Fri, May 11, 2018 at 07:12:21PM +0200, Boris Brezillon wrote: > > > On Fri, 11 May 2018 19:54:02 +0300 > > > Ville Syrjälä <ville.syrjala at linux.intel.com> wrote: > > >

Hi Boris, Just because I happened to read the docs in here, one typo below: On Thu, Nov 22, 2018 at 12:23:29PM +0100, Boris Brezillon wrote: >We have 3 drivers defining the "underscan", "underscan hborder" and >"underscan vborder" properties (radeon, amd and nouveau) and we are >about to add the same kind of thing in VC4. > >Define generic underscan

On Mon, May 07, 2018 at 04:44:34PM +0200, Boris Brezillon wrote: > Now that the plane code takes the underscan setup into account, we can > safely attach the underscan props to the HDMI connector. > > We also take care of filling AVI infoframes correctly to expose the > top/botton/left/right bar. > > Note that these underscan props match pretty well the >

Boris Brezillon <boris.brezillon at bootlin.com> writes: > On Mon, 3 Dec 2018 16:40:11 +0200 > Ville Syrjälä <ville.syrjala at linux.intel.com> wrote: > >> On Thu, Nov 22, 2018 at 12:23:29PM +0100, Boris Brezillon wrote: >> > @@ -924,6 +978,29 @@ struct drm_connector { >> > */ >> > struct drm_property_blob *path_blob_ptr; >> >

We have 3 drivers defining the "underscan", "underscan hborder" and "underscan vborder" properties (radeon, amd and nouveau) and we are about to add the same kind of thing in VC4. Define generic underscan props and add new fields to the drm_connector state so that the property parsing logic can be shared by all DRM drivers. A driver can now attach underscan

We have 3 drivers defining the "underscan", "underscan hborder" and "underscan vborder" properties (radeon, amd and nouveau) and we are about to add the same kind of thing in VC4. Define generic underscan props and add new fields to the drm_connector state so that the property parsing logic can be shared by all DRM drivers. A driver can now attach underscan

On Mon, May 07, 2018 at 05:15:33PM +0200, Daniel Vetter wrote: > On Mon, May 07, 2018 at 04:44:32PM +0200, Boris Brezillon wrote: > > We have 3 drivers defining the "underscan", "underscan hborder" and > > "underscan vborder" properties (radeon, amd and nouveau) and we are > > about to add the same kind of thing in VC4. > > > > Define

Applying an underscan setup is just a matter of scaling all planes appropriately and adjusting the CRTC X/Y offset to account for the horizontal and vertical border. Create an vc4_plane_underscan_adj() function doing that and call it from vc4_plane_setup_clipping_and_scaling() so that we are ready to attach underscan properties to the HDMI connector. Signed-off-by: Boris Brezillon

Applying an underscan setup is just a matter of scaling all planes appropriately and adjusting the CRTC X/Y offset to account for the horizontal and vertical border. Create an vc4_plane_underscan_adj() function doing that and call it from vc4_plane_setup_clipping_and_scaling() so that we are ready to attach underscan properties to the HDMI connector. Signed-off-by: Boris Brezillon

On Fri, 11 May 2018 18:34:50 +0300 Ville Syrjälä <ville.syrjala at linux.intel.com> wrote: > On Fri, May 11, 2018 at 04:59:17PM +0200, Boris Brezillon wrote: > > Applying an underscan setup is just a matter of scaling all planes > > appropriately and adjusting the CRTC X/Y offset to account for the > > horizontal and vertical border. > > > > Create an

https://bugs.freedesktop.org/show_bug.cgi?id=47846 Bug #: 47846 Summary: Nouveau -> overscan using HDMI Classification: Unclassified Product: xorg Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Driver/nouveau