similar to: [PATCH] drm/nouveau/debugfs: fix pm_runtime.cocci warnings

From: kbuild test robot <fengguang.wu at intel.com> pm_runtime_get_sync returns < 0 as error. Unecessary IS_ERR_VALUE at line 164 Generated by: scripts/coccinelle/api/pm_runtime.cocci Fixes: eaeb9010bb4b ("drm/nouveau/debugfs: Wake up GPU before doing any reclocking") CC: Karol Herbst <karolherbst at gmail.com> Signed-off-by: kbuild test robot <fengguang.wu at

From: YueHaibing <yuehaibing at huawei.com> pm_runtime_get_sync returns negative on failure. Fixes: eaeb9010bb4b ("drm/nouveau/debugfs: Wake up GPU before doing any reclocking") Signed-off-by: YueHaibing <yuehaibing at huawei.com> --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

From: YueHaibing <yuehaibing at huawei.com> [ Upstream commit 909e9c9c428376e2a43d178ed4b0a2d5ba9cb7d3 ] pm_runtime_get_sync returns negative on failure. Fixes: eaeb9010bb4b ("drm/nouveau/debugfs: Wake up GPU before doing any reclocking") Signed-off-by: YueHaibing <yuehaibing at huawei.com> Signed-off-by: Ben Skeggs <bskeggs at redhat.com> Signed-off-by: Sasha Levin

From: YueHaibing <yuehaibing at huawei.com> [ Upstream commit 909e9c9c428376e2a43d178ed4b0a2d5ba9cb7d3 ] pm_runtime_get_sync returns negative on failure. Fixes: eaeb9010bb4b ("drm/nouveau/debugfs: Wake up GPU before doing any reclocking") Signed-off-by: YueHaibing <yuehaibing at huawei.com> Signed-off-by: Ben Skeggs <bskeggs at redhat.com> Signed-off-by: Sasha Levin

From: YueHaibing <yuehaibing at huawei.com> [ Upstream commit 909e9c9c428376e2a43d178ed4b0a2d5ba9cb7d3 ] pm_runtime_get_sync returns negative on failure. Fixes: eaeb9010bb4b ("drm/nouveau/debugfs: Wake up GPU before doing any reclocking") Signed-off-by: YueHaibing <yuehaibing at huawei.com> Signed-off-by: Ben Skeggs <bskeggs at redhat.com> Signed-off-by: Sasha Levin

On 17/11/17 02:04, Karol Herbst wrote: > Fixes various reclocking related issues on prime systems. Is that the only place that was not covered? Could you check if other places would need this code too? In any case, this patch is (assuming you are calling the right functions to prevent the GPU from sleeping): Signed-off-by: Martin Peres <martin.peres at free.fr> > > Signed-off-by:

Make sure Pm_runtime_* calls does not use unnecessary IS_ERR_VALUE. when I run pm_runtime.cocci, I find the issue. So just replace it. Signed-off-by: zhong jiang <zhongjiang at huawei.com> --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau/nouveau_debugfs.c

Fixes various reclocking related issues on prime systems. Signed-off-by: Karol Herbst <karolherbst at gmail.com> --- drm/nouveau/nouveau_debugfs.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drm/nouveau/nouveau_debugfs.c b/drm/nouveau/nouveau_debugfs.c index 963a4dba..9109b69c 100644 --- a/drm/nouveau/nouveau_debugfs.c +++ b/drm/nouveau/nouveau_debugfs.c @@ -160,7 +160,11 @@

Date: Sat, 15 Apr 2023 21:06:06 +0200 The address of a data structure member was determined before a corresponding null pointer check in the implementation of the function ?nouveau_debugfs_pstate_set?. Thus avoid the risk for undefined behaviour by moving the usage of an expression into a parameter for a function call at the end. This issue was detected by using the Coccinelle software. Fixes:

pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu <dinghao.liu at zju.edu.cn> --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Hi julia, I think it would be better to extract the assignment out of the if clause. Then you'll get something like this: memory = ...; if (IS_ERR(memory)) { .... } so, to answer your question: no, it isn't necessary. On Tue, Nov 28, 2017 at 1:56 PM, Julia Lawall <julia.lawall at lip6.fr> wrote: > This is a false positive, but I wonder if it is really necessary to put > the

From: Julia Lawall <julia.lawall at lip6.fr> Date: Wed, 8 Jun 2016 18:15:29 +0200 (CEST) > Use BUG_ON instead of a if condition followed by BUG. > > Generated by: scripts/coccinelle/misc/bugon.cocci > > CC: Mike Rapoport <rppt at linux.vnet.ibm.com> > Signed-off-by: Julia Lawall <julia.lawall at lip6.fr> > Signed-off-by: Fengguang Wu <fengguang.wu at

On Mon, Jan 15, 2018 at 01:47:07PM +0100, Julia Lawall wrote: > From: Fengguang Wu <fengguang.wu at intel.com> > > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > drm_*_unreference() helpers. > > Generated by: scripts/coccinelle/api/drm-get-put.cocci > > Signed-off-by: Fengguang Wu <fengguang.wu at intel.com> > Signed-off-by:

Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Asias He <asias at redhat.com> Signed-off-by: Fengguang Wu <fengguang.wu at intel.com> Signed-off-by: Julia Lawall <julia.lawall at lip6.fr> --- vsock.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/vhost/vsock.c +++

Use BUG_ON instead of a if condition followed by BUG. Generated by: scripts/coccinelle/misc/bugon.cocci CC: Mike Rapoport <rppt at linux.vnet.ibm.com> Signed-off-by: Julia Lawall <julia.lawall at lip6.fr> Signed-off-by: Fengguang Wu <fengguang.wu at intel.com> --- macvtap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/macvtap.c +++

Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Asias He <asias at redhat.com> Signed-off-by: Fengguang Wu <fengguang.wu at intel.com> Signed-off-by: Julia Lawall <julia.lawall at lip6.fr> --- vsock.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/vhost/vsock.c +++

Use BUG_ON instead of a if condition followed by BUG. Generated by: scripts/coccinelle/misc/bugon.cocci CC: Mike Rapoport <rppt at linux.vnet.ibm.com> Signed-off-by: Julia Lawall <julia.lawall at lip6.fr> Signed-off-by: Fengguang Wu <fengguang.wu at intel.com> --- macvtap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/macvtap.c +++

From: kbuild test robot <fengguang.wu at intel.com> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and drm_*_unreference() helpers. Generated by: scripts/coccinelle/api/drm-get-put.cocci Fixes: 30ed49b55b6e ("drm/nouveau/kms/nv50-: move code underneath dispnv50/") Signed-off-by: kbuild test robot <fengguang.wu at intel.com> Signed-off-by: Julia

From: Fengguang Wu <fengguang.wu at intel.com> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and drm_*_unreference() helpers. Generated by: scripts/coccinelle/api/drm-get-put.cocci Signed-off-by: Fengguang Wu <fengguang.wu at intel.com> Signed-off-by: Julia Lawall <julia.lawall at lip6.fr> --- tree: https://github.com/thierryreding/linux for-4.16/work

This is a false positive, but I wonder if it is really necessary to put the assignment in the conditional test expression. julia ---------- Forwarded message ---------- Date: Tue, 28 Nov 2017 13:23:36 +0800 From: kbuild test robot <fengguang.wu at intel.com> To: kbuild at 01.org Cc: Julia Lawall <julia.lawall at lip6.fr> Subject: [PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci