similar to: [PATCH 1/4] nouveau_hwmon: migrate to hwmon_device_register_with_info

Hi again, I've split the patches as Karol Herbst suggested. I hope now it's fine. This series of patches introduce the new hwmon_device_register_with_info and gets rid of the old hwmon_device_register. This patch adds the default sensors with their possible config values. Just to prepare for the next patches --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-12

This is a preparation for the next patches. It just adds the sensors with their possible configurable settings and then fills the struct hwmon_channel_info with all this information. --- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 72 +++++++++++++++++++++++++++++++++ 1 file changed, 72 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c

All kernel patches must have a Signed-off-by: $user. See https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin On Mon, Apr 17, 2017 at 3:47 AM, Oscar Salvador <osalvador.vilardaga at gmail.com> wrote: > This is a preparation for the next patches. It just adds the sensors with > their possible configurable settings

Sorry for that. I'll split the patch and I'll come again ;) El dia 11/04/2017 22:12, "Karol Herbst" <karolherbst at gmail.com> va escriure: thanks for the work, but could you please split that patch? It looks like you are doing several things at once and it isn't really easy to review like this. And it isn't bisectable. If there are clean ups here, please do it

Hi, this patch replaces the old hwmon_device_register with the new hwmon_device_register_with_info. I've tested it on my laptop with a GeForceGT 425M and it doesn't break anything. --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-11 18:27:15.477623009 +0200 +++ linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c 2017-04-11 18:45:41.918688215 +0200 @@ -1,5 +1,6 @@ /* - *

2017-04-13 11:08 GMT+02:00 Oscar Salvador <osalvador.vilardaga at gmail.com>: > This patch introduces the structure "struct hwmon_ops" and sets up the ".visible" operation. > Is also a preparation for the next patch where all work is being done. > > --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-12 19:22:29.070573187 +0200 > +++

This patch introduces the structure "struct hwmon_ops" and sets up the ".visible" operation. Is also a preparation for the next patch where all work is being done. --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-12 19:22:29.070573187 +0200 +++ linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c 2017-04-12 19:21:32.391338011 +0200 @@ -764,6 +764,166 @@ static const

This patch creates special group attributes for special attrs like "*auto_point*". We check if we need them, and if we do, we set them up in special_groups structure, that then we pass to hwmon_device_register_with_info. --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-13 10:13:26.331391326 +0200 +++ linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c 2017-04-13

This patch introduces the nouveau_hwmon_ops structure, sets up .is_visible and .read_string operations and adds all the functions for these operations. This is also a preparation for the next patches, where most of the work is being done. This code doesn't interacture with the old one. It's just to make easier the review of all patches. --- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 166

This patch introduces the nouveau_hwmon_ops structure, sets up .is_visible and .read_string operations and adds all the functions for these operations. This is also a preparation for the next patches, where most of the work is being done. This code doesn't interacture with the old one. It's just to make easier the review of all patches. Signed-off-by: Oscar Salvador

This patch introduces the nouveau_hwmon_ops structure, sets up .is_visible and .read_string operations and adds all the functions for these operations. This is also a preparation for the next patches, where most of the work is being done. This code doesn't interacture with the old one. It's just to make easier the review of all patches. Signed-off-by: Oscar Salvador

Statically allocated array of pointed to hwmon_channel_info can be made const for safety. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> --- This depends on hwmon core patch: https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski at linaro.org/ Therefore I propose this should also go via hwmon tree. Cc: Jean Delvare <jdelvare at suse.com>

On Fri, 07 Apr 2023, Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> wrote: > Statically allocated array of pointed to hwmon_channel_info can be made > const for safety. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> > > --- > > This depends on hwmon core patch: >

Hi Karol, I don't get what you mean with return due to fallthrough. I mean, I know what is it, but I don't see how I can do it there. Moving the check before the switch looks like that: if (!iccsense) return 0; switch (attr) { case hwmon_power_input: if (iccsense->data_valid &&

On 4/10/23 02:56, Michael S. Tsirkin wrote: > On Fri, Apr 07, 2023 at 04:08:30PM -0700, Guenter Roeck wrote: >> On 4/7/23 08:01, Krzysztof Kozlowski wrote: >>> Statically allocated array of pointed to hwmon_channel_info can be made >>> const for safety. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> >>>

On 26/04/17 19:46, Oscar Salvador wrote: > This patch introduces the nouveau_hwmon_ops structure, sets up > .is_visible and .read_string operations and adds all the functions > for these operations. > This is also a preparation for the next patches, where most of the > work is being done. > This code doesn't interacture with the old one. > It's just to make easier the

On 4/7/23 08:01, Krzysztof Kozlowski wrote: > Statically allocated array of pointed to hwmon_channel_info can be made > const for safety. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> > > --- > > This depends on hwmon core patch: > https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski at linaro.org/ > >

On Fri, Apr 07, 2023 at 05:01:30PM +0200, Krzysztof Kozlowski wrote: > Statically allocated array of pointed to hwmon_channel_info can be made > const for safety. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> sure, merge it as appropriate Acked-by: Michael S. Tsirkin <mst at redhat.com> > --- > > This depends on hwmon core patch:

Reviewed-by: Lyude Paul <lyude at redhat.com> On Fri, 2023-04-07 at 17:00 +0200, Krzysztof Kozlowski wrote: > Statically allocated array of pointed to hwmon_channel_info can be made > const for safety. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> > > --- > > This depends on hwmon core patch: >

Statically allocated array of pointers to hwmon_channel_info can be made const for safety. Reviewed-by: Lyude Paul <lyude at redhat.com> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> --- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c