similar to: [PATCH] drm/nouveau/core: add missing header dependencies

On 23 October 2016 at 01:32, Karol Herbst <karolherbst at gmail.com> wrote: > I think it would be better to squash those commits: > 1. for the includes > 2. for static declerations > > OK, I have resent new patch that squash those commits. > 2016-10-22 11:41 GMT+02:00 Baoyou Xie <baoyou.xie at linaro.org>: > > We get 2 warnings when building kernel with W=1:

2016-10-24 9:13 GMT+02:00 Baoyou Xie <baoyou.xie at linaro.org>: > > > On 23 October 2016 at 01:32, Karol Herbst <karolherbst at gmail.com> wrote: >> >> I think it would be better to squash those commits: >> 1. for the includes >> 2. for static declerations >> > OK, I have resent new patch that squash those commits. > thanks, this is much

I think it would be better to squash those commits: 1. for the includes 2. for static declerations 2016-10-22 11:41 GMT+02:00 Baoyou Xie <baoyou.xie at linaro.org>: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous prototype for 'nvkm_firmware_get' [-Wmissing-prototypes] >

We get a few warnings when building kernel with W=1: drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c:60:1: warning: no previous prototype for 'nvkm_sddr2_calc' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c:69:1: warning: no previous prototype for 'nvkm_sddr3_calc' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c:35:1: warning: no

We get 2 warnings when building kernel with W=1: drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous prototype for 'nvkm_firmware_get' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/core/firmware.c:58:1: warning: no previous prototype for 'nvkm_firmware_put' [-Wmissing-prototypes] In fact, these functions are declared in

We get a few warnings when building kernel with W=1: drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous prototype for 'nvkm_firmware_get' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/core/firmware.c:58:1: warning: no previous prototype for 'nvkm_firmware_put' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c:69:1: warning: no previous

We get some warnings when building kernel with W=1: drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c:222:1: warning: no previous prototype for 'gf117_grctx_generate_main' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c:255:1: warning: no previous prototype for 'nv50_grctx_fill' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c:265:1:

Add two functions nvkm_firmware_get() and nvkm_firmware_put() to load a firmware file and free its resources, respectively. Since firmware files are becoming a necessity for new GPUs, and their location has been standardized to nvidia/chip/, this will prevent duplicate and error-prone name-generation code. Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> ---

We get 2 warnings when build kernel with W=1: drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c:255:1: warning: no previous prototype for 'nv50_grctx_fill' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c:265:1: warning: no previous prototype for 'nv50_grctx_init' [-Wmissing-prototypes] In fact, these functions are declared in gr/nv50.h, so this patch add

... and demote non-conformant kernel-doc header. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/core/firmware.c:71: warning: Function parameter or member 'subdev' not described in 'nvkm_firmware_get' drivers/gpu/drm/nouveau/nvkm/core/firmware.c:71: warning: Function parameter or member 'fwname' not described in 'nvkm_firmware_get'

Hi Alexandre, On 18 January 2016 at 06:07, Alexandre Courbot <acourbot at nvidia.com> wrote: > Add two functions nvkm_firmware_get() and nvkm_firmware_put() to load a > firmware file and free its resources, respectively. Since firmware files > are becoming a necessity for new GPUs, and their location has been > standardized to nvidia/chip/, this will prevent duplicate and >

On Thu, Jan 21, 2016 at 8:41 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote: > Hi Alexandre, > > On 18 January 2016 at 06:07, Alexandre Courbot <acourbot at nvidia.com> wrote: >> Add two functions nvkm_firmware_get() and nvkm_firmware_put() to load a >> firmware file and free its resources, respectively. Since firmware files >> are becoming a necessity

On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie <baoyou.xie at linaro.org> wrote: > We get 1 warning when build kernel with W=1: > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a

On 30 August 2016 at 00:01, Sean Paul <seanpaul at google.com> wrote: > On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie <baoyou.xie at linaro.org> wrote: > > We get 1 warning when build kernel with W=1: > > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no > previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes] > >

On Tuesday 30 August 2016, Baoyou Xie wrote: > We get some warnings when building kernel with W=1: > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c:222:1: warning: no previous prototype for 'gf117_grctx_generate_main' [-Wmissing-prototypes] > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c:255:1: warning: no previous prototype for 'nv50_grctx_fill'

We get 1 warning when build kernel with W=1: drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this patch marks this function with 'static'. Signed-off-by:

We get 2 warnings when build kernel with W=1: drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c:75:1: warning: no previous prototype for 'nvkm_perfsig_find' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c:703:1: warning: no previous prototype for 'nvkm_perfsrc_new' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared

We get 2 warnings when biuld kernel with W=1: drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c:75:1: warning: no previous prototype for 'nvkm_perfsig_find' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c:703:1: warning: no previous prototype for 'nvkm_perfsrc_new' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared

On Sunday, August 28, 2016 1:02:52 PM CEST Baoyou Xie wrote: > We get 1 warning when build kernel with W=1: > drivers/gpu/drm/nouveau/dispnv04/overlay.c:496:1: warning: no previous prototype for 'nouveau_overlay_init' [-Wmissing-prototypes] > > In fact, this function is declared in disp.h, so this patch > add missing header dependencies > > Signed-off-by: Baoyou Xie

We get 1 warning when build kernel with W=1: drivers/gpu/drm/nouveau/dispnv04/overlay.c:496:1: warning: no previous prototype for 'nouveau_overlay_init' [-Wmissing-prototypes] In fact, this function is declared in disp.h, so this patch add missing header dependencies Signed-off-by: Baoyou Xie <baoyou.xie at linaro.org> --- drivers/gpu/drm/nouveau/dispnv04/overlay.c | 2 +- 1 file