similar to: RFC: FileCheck Enhancements

Hi, CHECK-WORD - If you want find some string in file, but you want to be sure, that this string should be a separate word. There are examples in file. Prefixes which can be described as regular expressions should be turning on with option -regex-prefixes . By default, you can't use it. Thanks for your comments. -----Original Message----- From: Jonathan Roelofs [mailto:jonathan at

> From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Elena Lepilkina via llvm-dev > Sent: Tuesday, May 24, 2016 6:51 AM > To: llvm-dev > Subject: [llvm-dev] RFC: FileCheck Enhancements > > Hi everyone, > > There was idea to add new directives to FileCheck: > 1.       Directive to use some patterns as named template with or without parameters. Seems

On 5/24/16 8:10 AM, Elena Lepilkina wrote: > Hi, > > CHECK-WORD - If you want find some string in file, but you want to be sure, that this string should be a separate word. Is this functionally equivalent to doing: // CHECK: {{\s}}whatever{{\s}} Or is there some other subtlety about it? Jon > > There are examples in file. > Prefixes which can be described as regular

On 5/24/16 7:51 AM, Elena Lepilkina via llvm-dev wrote: > Hi everyone, > > There was idea to add new directives to FileCheck: > > 1.Directive to use some patterns as named template with or without > parameters. > > 2.CHECK-INCLUDE - Directive to include other file with checks to another. > > 3.Expressions repeat for CHECK - If statement should be checked several >

It's equivalent to {{\b}}whatever{{\b}}. I amn't sure if assertion \b is supported. \s will not match with start and of line, but it should be matched. Elena. -----Original Message----- From: Jonathan Roelofs [mailto:jonathan at codesourcery.com] Sent: Tuesday, May 24, 2016 5:14 PM To: Elena Lepilkina <Elena.Lepilkina at synopsys.com>; llvm-dev <llvm-dev at lists.llvm.org>

Hi Paul, Thank you for information about the [[:space:]] character-class. About performance I tested on Clang/LLVM test suite. I try to profile and the problem is that I used regular expressions a lot for supporting some new features and functions in your regex library are very slow . Regex library is very old and quite awkward, in my opinion. May be you will see some ways to improve performance,

On Thu, May 26, 2016 at 10:35 AM, Ehsan Amiri via llvm-dev < llvm-dev at lists.llvm.org> wrote: > 7. Wildcard for prefixes - If some statements should be checked > regardless prefix, it should be used //{{*}}, //{{*}}-NEXT, //{{*}}-SAME > and etc. > >> 8. Prefix with regular expressions - If statement should be >> checked if prefix matches some regular

But then I should write // CHECK: something // SSE: something // SSE3: something With this feature it can be write // {{[A-Z0-9]+}} : something From: James Y Knight [mailto:jyknight at google.com] Sent: Thursday, May 26, 2016 5:53 PM To: Ehsan Amiri <ehsanamiri at gmail.com> Cc: Elena Lepilkina <Elena.Lepilkina at synopsys.com>; llvm-dev <llvm-dev at lists.llvm.org> Subject:

7. Wildcard for prefixes - If some statements should be checked regardless prefix, it should be used //{{*}}, //{{*}}-NEXT, //{{*}}-SAME and etc. > 8. Prefix with regular expressions - If statement should be checked > if prefix matches some regular expression, it should be used {{regex}}:, > {{regex}}-NEXT and etc. > > > > I, too, think wildcard and regular

Hi all, I' ll be glad to hear more opinions and may be some suggestions how to improve new features (may be there are ideas how template descriptions can be done simplier). After we try to accept your ideas and opinions to make new FileCheck features better. I will make changes and publish separate patches a month later, because I'll take a holiday in June. Thanks, Elena. -----Original

Yes, I now understand what you suggested. > CHECK-DEFINE-PATTERN: car(make, model, year): {{Found a }} make model {{, from }} year But I think that in pattern I should show that I use parameter. I thought that patterns can also be simple strings. All strings should be regexs in pattern and parameters can't be used in pattern in your example. But I want to use parameters in regexs. For

> On Aug 24, 2016, at 4:46 PM, Vedant Kumar via llvm-dev <llvm-dev at lists.llvm.org> wrote: > >> >> On Aug 24, 2016, at 2:04 AM, Elena Lepilkina <Elena.Lepilkina at synopsys.com> wrote: >> >> Hi all, >> >> Some discussions and comments were made in reviews. Much time has already passed since last comment and uploading changed patches. I

On 5/26/16 5:25 PM, Robinson, Paul via llvm-dev wrote: > >> 7. Wildcard for prefixes - If some statements should be checked regardless prefix, it should be used //{{*}}, //{{*}}-NEXT, //{{*}}-SAME and etc. >> 8. Prefix with regular expressions - If statement should be checked if prefix matches some regular expression, it should be used {{regex}}:, {{regex}}-NEXT and

Ok, when I change syntax I will load new patch. Thanks, Elena. -----Original Message----- From: vsk at apple.com [mailto:vsk at apple.com] Sent: Thursday, September 01, 2016 9:38 PM To: Elena Lepilkina <Elena.Lepilkina at synopsys.com> Cc: Mehdi Amini <mehdi.amini at apple.com>; llvm-dev at lists.llvm.org Subject: Re: [llvm-dev] RFC: FileCheck Enhancements It is necessary to be

I wanted to start making some change. But I thought and I don't understand why it's necessary to add @. // RUN: FileCheck %s // CHECK-DEFINE-PATERN: register(n): {{[a-z]+}}n // CHECK: %[[register("1")]] // CHECK-SAME: %[[register("2")]] // CHECK: %[[register("1")]] // CHECK-SAME: %[[register("2")]] This example will be equivalent to // RUN:

For all of these changes: why/where are they actually useful? Previous enhancements of FileCheck have mostly been added when needed by a test. It would greatly help your case for adding these new enhancements to show some tests which would be improved, or have greater clarity, by the use of these features. I'm particularly skeptical about "3. Expressions repeat for CHECK",

Hi all, Some discussions and comments were made in reviews. Much time has already passed since last comment and uploading changed patches. I made small summary report about features here, because there are some doubts about syntax of some features and changes in patches and it'll be great to know more opinions. 1. FileCheck Enhancement - CHECK-WORD (https://reviews.llvm.org/D22353) I replace

Hi, I have question again about modifiers for pattern parameters. Vedant suggested such way. > CHECK-DEFINE-PATTERN: one_or_more(x): x {{+}} But I have some doubts. This should be equal to x+. This approach differs from standard one. In FileCheck I can write CHECK: {{x|y}}{{something}} This line will be equal to regex (x|y)(something). But if I use suggested approach and write same

And I also want to ask again about possible change of regexp library. There are a lot of comments that some changes in FileCheck are useless, because they may be replaced by using some features of regular expressions, but they are not supported by current library. I don't know a lot about modern C++ regexp library, but there are: 1. PCRE(pcre.h) 2. std::regex. It has no necessary features. So

Hi Elena, > On Jul 19, 2016, at 6:36 AM, Elena Lepilkina via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Hi all, > > I made new patches for most of changes with llvm-commits subscriber. But two patches were updated, because there are a lot of comments (patch for CHECK-WORD and patch for templates pattern). Will it be ok? IMO it's fine to keep some of the original