similar to: [LLVMdev] Phabricator by email/git?

Would it make sense to officially have phabricator ignore all replies to the email thread, and instead require that all comments are done through phabricator itself? -Krzysztof On 5/25/2016 10:20 AM, James Y Knight via llvm-dev wrote: > Just ran into another thread where phabricator is seemingly ignoring > replies. This one seems to be a different issue. > > In the thread

Just ran into another thread where phabricator is seemingly ignoring replies. This one seems to be a different issue. In the thread "[PATCH] D20337: [MC] Support symbolic expressions in assembly directives", Phabricator seems to have completely ignored all of the replies starting with my (emailed) reply earlier today: "The .s does have a way to carry the location.". Except

On Wed, Dec 11, 2013 at 2:57 PM, Hal Finkel <hfinkel at anl.gov> wrote: > ----- Original Message ----- > > From: "Renato Golin" <renato.golin at linaro.org> > > To: "LLVM Dev" <llvmdev at cs.uiuc.edu>, "Clang Dev" <cfe-dev at cs.uiuc.edu> > > Sent: Wednesday, December 11, 2013 7:50:38 AM > > Subject: [LLVMdev]

----- Original Message ----- > From: "Renato Golin" <renato.golin at linaro.org> > To: "LLVM Dev" <llvmdev at cs.uiuc.edu>, "Clang Dev" <cfe-dev at cs.uiuc.edu> > Sent: Wednesday, December 11, 2013 7:50:38 AM > Subject: [LLVMdev] Phabricator email > > Hi folks, > > I seem to be getting an error on every reply to a

On 19 May 2016 at 19:59, James Y Knight via llvm-dev <llvm-dev at lists.llvm.org> wrote: > Does anyone know why phab sometimes misses replies sent by email? Usually > they make it through, but sometimes not. Doesn't seem to be a trivial thing to do: https://secure.phabricator.com/T7358 https://secure.phabricator.com/T5181 cheers, --renato

Hi folks, I seem to be getting an error on every reply to a Phabricator auto-generated email, is this happening to everyone? I've seen comments from others not registering on it, so I'm assuming this is global. This means two things: 1. Phabricator is not catching all replies, which means we have an incomplete picture on it, bad for reviews, but at least the info is stored in the lists

> Dropping replies from the web interface or the mail interface? > Also: does "dropping replies" mean that an email reply doesn't show up in the phab interface? > (that's currently "working as intended", until we find enough time to write a parser for inline > comment replies in mails) I mean that email replies don't always appear in the web interface.

I'm not getting the error email you mention, but I have noticed it silently dropping replies (including my own on occasion). I haven't spotted anything the missing replies have in common. The web interface did just pop up with this though: Unhandled Exception ("Exception") Failed to proc_open(): proc_open(): fork failed - Cannot allocate memory > -----Original

On 11/12/2013 17:01, Manuel Klimek wrote: > On Wed, Dec 11, 2013 at 5:52 PM, Daniel Sanders > <Daniel.Sanders at imgtec.com <mailto:Daniel.Sanders at imgtec.com>> wrote: > > I'm not getting the error email you mention, but I have noticed it > silently dropping replies (including my own on occasion). I > haven't spotted anything the missing replies

On 11/12/2013 17:48, Renato Golin wrote: > On 11 December 2013 17:35, Alp Toker <alp at nuanti.com> wrote: >> I noticed a few contributors have been landing patches without responding to >> my review comments. > Oh, that happened to me too, but it turns out you have to press the > "clowncopterize" after making comments inlilne, or Phabricator won't >

On 11 December 2013 17:35, Alp Toker <alp at nuanti.com> wrote: > I noticed a few contributors have been landing patches without responding to > my review comments. Oh, that happened to me too, but it turns out you have to press the "clowncopterize" after making comments inlilne, or Phabricator won't publish them. You can see them, we can't. cheers, --renato

On Wed, Dec 11, 2013 at 5:52 PM, Daniel Sanders <Daniel.Sanders at imgtec.com>wrote: > I'm not getting the error email you mention, but I have noticed it > silently dropping replies (including my own on occasion). I haven't spotted > anything the missing replies have in common. > Dropping replies from the web interface or the mail interface? Also: does "dropping

Those seem to be comments by the original author? Is this a problem? On Wed, Jul 8, 2015 at 10:31 AM Tamas Berghammer <tberghammer at google.com> wrote: > Hi Manual, > > Since the Phabricator update I noticed that the username of the reviewer > isn't displayed for some comment added to the review (e.g.: > http://reviews.llvm.org/D11016). Can you check it out what is

On 11 December 2013 14:03, Manuel Klimek <klimek at google.com> wrote: > I'm working with the upstream guys to get this fixed. I'll try to see > whether we can up the priority... Thanks! --renato

Ah, thanks, interesting - investigating On Wed, Jul 8, 2015 at 12:37 PM Renato Golin <renato.golin at linaro.org> wrote: > On 8 July 2015 at 11:31, Manuel Klimek <klimek at google.com> wrote: > > Those seem to be comments by the original author? Is this a problem? > > Not always, see http://reviews.llvm.org/D10676 or any other. > > I can only see the commenter

Does anyone know why phab sometimes misses replies sent by email? Usually they make it through, but sometimes not. For example, a recent email from Rafael (which I got through the llvm-commits list) seems to be addressed to the proper thing @ reviews.llvm.org, yet seems to have never made it onto the website. Not having not seen that response (because I was looking on the website), I ended up

On Mon, Jun 30, 2014 at 10:48 AM, Renato Golin <renato.golin at linaro.org> wrote: > On 27 June 2014 21:53, Duncan P. N. Exon Smith <dexonsmith at apple.com> > wrote: > > Then the only way for people to "accept" something is by typing text > > to that effect. > > If you don't "Accept" the patch, you can't close the issue. So, either

Folks, For some reason, all new phabricator diffs are automatically including Amara, which is probably a bit annoying for him, but pointless. I believe it happens because his name is the first in the alphabetical order. Can someone have a look at what's going on? cheers, --renato

I don't think we should mention phabricator at all. I only mention attribution because that's legally important. Cheers, Renato On 8 Mar 2015 16:31, "Kuperstein, Michael M" <michael.m.kuperstein at intel.com> wrote: > Hi Renato, > > I know this is nitpicking, but do we want to specify the order between > "Patch By" and "Differential

Hi, I haven't got any comments to add that haven't already been discussed but I thought it would be worth mentioning that Phabricator's documentation has a fairly good section on good commit messages at https://secure.phabricator.com/book/phabflavor/article/writing_reviewable_code/#write-sensible-commit-me. > -----Original Message----- > From: cfe-dev-bounces at cs.uiuc.edu