similar to: How to deal with multiple patches to the same file

I think I understand the concepts, but I sure would appreciate a specific example, and I appreciate the offer. To make your life harder, could you start with what I should do given that I have not created a branch for the first patch? I just have the six files staged. I have GitHub Desktop installed, if that makes any of the steps easier. Thanks again, and no rush! At 8/10/2020 10:07 AM,

I have a patch being reviewed in Phabricator. A couple of suggestions were made, so I would like to submit a revised patch. I think this patch will take awhile to be accepted, or perhaps never will be. Meanwhile, I would like to fix an unrelated bug in one of the same C++ files. Here is my plan. Could you tell me if this makes sense? I will make a branch off master for the bug fix, make the fix,

Thank you for driving this Paul, I agree that it is better to have one doc on TableGen. This has been a point of confusion for me as well - when I land in the wrong one and can’t find what I’m looking for :-). -Chris > On Jul 31, 2020, at 1:49 PM, Paul C. Anagnostopoulos via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Thanks, David. I have started a new document titled

Are all the records collected as they are parsed, with template parameter substitution and lets, and *then*, after all records are collected, a "pass" is made to calculate the inter-field expressions? Once I understand this, I will add a section to the new guide to explain it. I presume it is the case that this behavior should be publicized. It also appears to be the case that a record

Folks, I am interested in contributing to LLVM in the future. Meanwhile, I am reading many of the project documents (right now, "TableGen Language Reference"). Is there a way I can contribute corrections to these documents without cloning and building LLVM? ~~ Paul ---------------------------------------------------------------- Windfall Paul C. Anagnostopoulos

I owe you a gala dinner at your favorite restaurant. Really. A few questions: Why did you 'git pull --rebase' when the branch was up-to-date? Is this just a safety habit? I don't understand the pushing upstream. Since we use Phabricator, isn't that the job of the person who commits the patch? Does git keep all my branches up-to-date with the origin? Say I come in tomorrow and

John, I'm pretty much down to details and smoothing the text. Here is a pdf. Can you mark it with comments? Or you can send an email with a list. I will incorporate your comments and send you a second proof, so you can be sure I understood you. Is a week long enough? ~~ Paul At 8/5/2020 02:16 PM, John Byrd wrote: >I'd like to collaborate, if you point me at your tree. Like you,

I wasn't sure how to respond to John Byrd's post, since it wasn't addressed to me. So I've responded to Nicolai's. I'm reasonably far along in the process of writing a new Programmer's Guide for TableGen. I will continue working on it and submit it for review. I expect to do some rewriting as a result. John: Would you like me to respect a copyright on your documents

Could you expand on this a bit? I see from my build directory that llvm-tblgen.exe was built before the Target/* .inc files. It sounds like you're saying that something has to be built between the .exe and the .inc files. At 8/4/2020 02:44 PM, Chris Lattner wrote: >> On Aug 4, 2020, at 11:31 AM, Paul C. Anagnostopoulos via llvm-dev <llvm-dev at lists.llvm.org> wrote: >>

Oh yes, I am diffing the output of some of the tests in order to be sure everything is the same. And running the tests, too. I have a question about the release notes. The current version of LLVM is 10. There are release notes for 12. What happened to poor old version 11? At 8/7/2020 02:55 PM, David Blaikie wrote: >On Fri, Aug 7, 2020 at 11:47 AM Paul C. Anagnostopoulos ><paul at

Can you explain how to revert for someone who is a 2 on a git scale of 0 to 10? At 9/22/2020 03:51 PM, Arthur Eubanks wrote: >Yes, push whatever is needed to fix the build if the fix is fairly simple (else revert and get an LGTM with the fix). > >Next time I'd recommend creating and pushing a revert first if you can't quickly figure out the issue.

I understood that the name is a matching tag for the operand and not its name (as in named macro or function arguments). However, I was assuming that the names in any one DAG node had to be unique and so could serve as selectors for operands. But a quick investigation shows that I was wrong: names can be duplicated in the same node. So DAG indexes are integers only. At 10/12/2020 01:46 PM,

Well, I was hinting at LLVM_DEBUG messages. You can pretty much dump all "actions" Tablegen would take to process a .td file, which should suffice, IMO. On Wed, Aug 5, 2020 at 5:59 PM Paul C. Anagnostopoulos <paul at windfall.com> wrote: > Your reply suggests that there is a way to see debug messages from > TableGen. Is that what you meant? If so, can you explain how that

At 8/16/2020 10:39 AM, Stefan Stipanovic wrote: >Hi Paul, > >I've read "LLVM Code-Review Policies and Practices," but I remain unsure of a couple of things. Do I always wait for an actual "LGTM", or can people approve the patch for submission in other ways? > >The patch is accepted through Phabricator with or without a message (the message is usually LGTM or

Yes, I understand the problem. To be more useful, TableGen would have to carry the traces along with the classes and records and (re)display the values while the substitutions are being made. I'm writing a new Programmer's Guide for TableGen and have been digging into the parse-time versus substitution-time issue. I haven't found a document that makes it clear. Can you give a quick

I was confused by the lack of TableGen backends in the llvm/lib/tablegen directory until I stumbled upon the llvm/utils/tablegen directory. Could someone explain why TableGen is divided into these two directories? ---------------------------------------------------------------- Windfall Paul C. Anagnostopoulos ----------------------------------------------------------

I think I could stomach changing the tests over time, although at least one should be left with the old punctuator. It's the "real" .td files that scare me. Tell me more abut diffing the test files. I assume that the CHECK: lines are checking the important results of each .td file, and so if all the tests still pass, things are good. Are you suggesting some way of automating the

Just a poke to see if anyone knows when the Doxygen pages are built. ---------------------------------------------------------------- Windfall Paul C. Anagnostopoulos ---------------------------------------------------------- Software 978 369-0839 www.windfall.com ---------------------------------------------------------------- My

Is "Unix Makefiles" what I want if I am building on Windows using GNU make? At 7/28/2020 10:41 PM, Xing GUO wrote: >On 7/29/20, Paul C. Anagnostopoulos via llvm-dev ><llvm-dev at lists.llvm.org> wrote: >> Folks, >> >> Total newbie here. What is the simplest way to build a single .rst file so >> that I can look at the generated HTML? I have CMake,

At 7/30/2020 11:41 AM, Michael Kruse wrote: >This looks like cmake starts processing with a wrong top-level CMakeLists.txt (llvm\docs\CMakeLists.txt). It should be <your llvm-project checkout>\llvm\CMakeLists.txt. For instance: > >C:\> cmake -SÂ <your llvm-project checkout>\llvm -B C:/LLVM/Build Thank you for responding. I'm trying to build just the LLVM