similar to: Flang landing in the monorepo - next Monday!

On 01/07, David Blaikie via llvm-dev wrote: > Hey Peter - would you be able to link to/describe the history on this > process/decision. I can find one old thread where this was first proposed ( > http://lists.llvm.org/pipermail/llvm-dev/2019-February/130497.html ) with > some general positive responses and a lot of questions. > > I see there's a flang-dev list, though

Hi Hal, On Tue, Jan 7, 2020 at 3:38 PM Finkel, Hal J. via llvm-dev < llvm-dev at lists.llvm.org> wrote: > > On 1/7/20 4:38 PM, Doerfert, Johannes via llvm-dev wrote: > > On 01/07, David Blaikie via llvm-dev wrote: > > Hey Peter - would you be able to link to/describe the history on this > process/decision. I can find one old thread where this was first proposed

On Thu, Jan 9, 2020 at 4:19 AM Mehdi AMINI via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > > > On Tue, Jan 7, 2020 at 6:04 AM Peter Waller via llvm-dev <llvm-dev at lists.llvm.org> wrote: >> >> Hi All, >> >> As discussed before Christmas, this is a reminder that we intend to >> merge flang on the 13th January (next Monday) before the

Hi all Thanks for all the replies and engagement on this issue. First point, given the state of discussions today I would like to propose that we don't start the merge at 10:00 GMT on Monday 13th as proposed and we delay by at least 24 hours until after the scheduled F18 technical call on Monday afternoon. In order to help compile a plan of action, I've tried to compile a list of the

I take it from this conversation that we should do a --no-ff merge of the rewritten history. The final history will look like this: [llvm project/master] ---------------------> [empty merge commit]                       \_ 2,700ish commits _/^ This means that `git log --first-parent` will only show the merge commit, and not those from the "initial flang" branch. Currently it

Hi Eric, Renato Thanks again for the engagement and challenge on this, it is really useful feedback to know what we need to do to get F18 into the project in a way that everyone is happy with. I have tried to give timelines on the points addressed below where I can today. Clearly we need to do some work on points 8-11, but are the above plans/answers to points 1-7 sufficient at this stage and

Hi, On Wed, Jan 8, 2020 at 6:54 PM Finkel, Hal J. via llvm-dev < llvm-dev at lists.llvm.org> wrote: > FYI to everyone: If you have things that you would like to see done > before a merge of Flang, please reply with as many details as you have > time to provide (and if you have things that you would like to see done > soon, but you're comfortable with them happening after

Hi Eric, Apologies, I failed to disambiguate clearly, because there are multiple projects named flang. I was referring to the "new" flang, whose repository is currently found at https://github.com/flang-compiler/f18. It will land in the monorepo under a directory called "/flang/". f18 has been approved to join, for reference see "[llvm-dev] f18 is accepted as part of

Hi All, The flang project (a Fortran compiler) is getting ready to join the monorepo. We intend to preserve the existing history by rewriting the existing commits as a linear series of commits on top of llvm-project. I understand the flang community would like to do this before the LLVM 10 branch in due in mid January, so please speak up soon if you see anything needing fixing in what I

I think it would probably make the most sense to land this as a single merge-commit (from the 2700-commit rewritten history you've created) onto llvm-project master, rather than as 2700 individual toplevel commits to master. (Which means: disable the merge-commit prohibition in the github configuration, temporarily, push this commit, and then enable it again). On Tue, Dec 17, 2019 at 5:10 PM

On 18/12/2019 21:49, Eric Christopher wrote: > Yes, I looked through those sources and a number of my questions > around which clang versions have been supported and directory > structure. I think the only difference is removing the direct > questions about earlier flang, but I still don't see code generation > or uses of llvm libraries that would conform to "written in

On Wed, Dec 18, 2019 at 4:56 AM Peter Waller <Peter.Waller at arm.com> wrote: > On 17/12/2019 22:25, James Y Knight wrote: > > I think it would probably make the most sense to land this as a single > > merge-commit (from the 2700-commit rewritten history you've created) > > onto llvm-project master, rather than as 2700 individual toplevel > > commits to

On Mon, 13 Jan 2020 at 06:50, Eric Christopher <echristo at gmail.com> wrote: > I don't really consider this addressed without a plan of action (before merge) that contains a list of standard llvm support libraries that would be used in addition to things being removed (pretty much all use of C++ c* headers and more?) as well as staffing and approximate ETAs. Agreed. > I think

Hal, Eric, Johannes, David and Peter, I lead the development of OpenMP for AMD GPUs and work with others at AMD who support OpenMP on AMD CPUs. On behalf of our development teams, we greatly appreciate your efforts to move the development of flang into a subproject in the llvm-project repository and to integrate this development effort into the overall LLVM development community. Like most

On Wed, 8 Jan 2020 at 01:48, Eric Christopher via llvm-dev <llvm-dev at lists.llvm.org> wrote: > I am in favor of having a flang front end in tree. I have concerns about the design of flang versus other front ends, the lack of llvm based library use, and a number of other things that I tried to enumerate in previous emails. I don't know if anything has changed and the responses I got

Can you elaborate on this? - to move the std::string/string_view/StringRef changes to pre-merge unless you're going to have someone dedicated to handling them post-merge (rather than "time permits"). The C vs C++ ism here is fairly strong and I'd like to get the C-style string handling out fairly quickly. I understood this item to be looking into replacing uses of std::string

Hi Eric, Old flang certainly uses C-style strings but f18 uses std::string with few exceptions. Most of the instances in f18 of “char *” aren’t really strings in the C sense – they’re not null terminated and are really just pointers into raw or cooked source files/streams. I can’t think of an instance where the compiler dynamically allocates an array of characters and uses it as a C string. -

Hi llvm-dev It's been a few weeks since I last gave an update on F18 and our progress on readying it for inclusion into the monorepo. Last time we discussed this the community challenged us to make the F18 source code look more like an LLVM project and to come up with a plan and schedule for completing this work (http://lists.llvm.org/pipermail/llvm-dev/2020-January/137989.html) The full

On Wed, Jan 08, 2020 at 05:35:44PM -0800, Eric Christopher via llvm-dev wrote: > As far as the current use in the clang driver: Honestly I don't think you > should be using the clang driver and had I seen I probably wouldn't have > accepted those patches either. I think it would be better off to turn parts > of the driver you might need into a separable library rather than

Hi llvm-dev We have not been able to complete all the work we need to do before merging F18 into LLVM as Flang so we will not be dong that today as previously announced. We propose to slip this back a week to let us finish off the last bits of work. All code changes are in review as of Friday. If you want more detail, you can see the exact status here: