similar to: Branching debuginfo-tests for releases

llvm-profdata is part of llvm though. It’s perfectly fine for something in clang to depend on something in llvm. However, clang and lld are two independent llvm subprojects, neither of which can depend on each other. Generally speaking, from a layering perspective, if A depends on B and C, but B and C are independent, that should be reflected in the structure. For example, in CMake we will need

From the CI side moving this stuff around is a huge undertaking. We include this repo in every build, they will all need to be fixed and verified. It is a lot of work on our side. Is there a plan for both system to work side-by-side as we migrate jobs? Talking to Mike today, we estimated a week of work to migrate and verify, plus residual failures for the next month. Regarding your

I just got a Diffusion notification about a change of mine being reverted by Fangrui, but I'm not sure that's actually what happened and am confused and concerned. My commit was "[DebugInfo] Allow spill slots in call site parameter descriptions", and it appears in the history under two hashes: 1ee84e and 67c416. The first commit contains the actual change. The second touches

On Fri, Nov 3, 2017 at 9:34 PM Zachary Turner via llvm-dev < llvm-dev at lists.llvm.org> wrote: > By adding in a different suite, you mean the lld part? I mean > theoretically, but that would be pretty awkward, because the idea behind > the lld requirement is that we want to make debuginfo-tests work with > clang-cl and CodeView debug info, and for this lld is a hard

> On Sep 22, 2017, at 11:36 AM, Vedant Kumar <vsk at apple.com> wrote: > > Ah, the problem goes away once I build clang-func-mapping. > > I stripped some stuff out, but here's pretty much what clang/test/lit.cfg.py says my PATH is: > > ** PATH **: /Volumes/Builds/llvm.org-coverage-braces-RA/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin > > I wonder how

The actual DWARF emission for call site parameters is gated inside of DwarfDebug::constructCallSiteEntryDIEs by `tuneForGDB() || tuneForLLDB()`. However, we are creating+updating CallSiteInfo (basically, in-memory only bookkeeping used by the backend to keep track of call sites) even when the debugger tuning is set to the Sony debugger. If this creates problems, feel free to file a bug and

Hi, Thanks you all for the collaboration! :) Paul, > This is not how tuning-controlled features are supposed to work. I will comment on the review. I see, I am working on addressing the comments from the [1]. I will update the diff asap. Thanks. Vedant, There are no entry values generated at -O0 level, but I will add a test case for it. Thanks. Best regards, Djordje On 8.2.20. 02:41,

Yea at first I was worried that maybe I changed the semantics of how it looked in PATH, and you had clang-func-mapping in your PATH somewhere before but now lit was building a different PATH. But I looked at that change and it wasn't even creating that substitution before. So it looks like that CL is indeed the problem. On Fri, Sep 22, 2017 at 11:38 AM Vedant Kumar <vsk at apple.com>

This works for me. Can you run "which clang-func-mapping" and also add a line to clang/test/lit.cfg.py to print the value of config.environment['PATH']? On Fri, Sep 22, 2017 at 11:27 AM Zachary Turner <zturner at google.com> wrote: > Looking, thanks for the report. > > On Fri, Sep 22, 2017 at 11:22 AM Vedant Kumar <vsk at apple.com> wrote: > >> As

Greetings, If you dont' care about running debuginfo-tests, and don't maintain a bot that runs debuginfo-tests, you can stop reading. I've uploaded a patch [https://reviews.llvm.org/D39605] that changes the way you run debuginfo-tests. Prior to this patch, the way to run them is to clone an external git repository into clang/test and then debuginfo-tests will happen transparently

Ah, the problem goes away once I build clang-func-mapping. I stripped some stuff out, but here's pretty much what clang/test/lit.cfg.py says my PATH is: ** PATH **: /Volumes/Builds/llvm.org-coverage-braces-RA/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin I wonder how this ever worked before, when I didn't have clang-func-mapping built. Anyway, thanks for your help! vedant >

Hi vedant, 1. First, I think your theory is right that llvm’s object file reading libraries do not “understand” the architecture I’m working on. Since I’m using binutils as assembler which means llvm can only provide asm and object file is provided by biutils. I think these ELF header information is provided by my binutils now, so maybe I have to modify binutils code to provide ELF header

Hi vedant, 1. The definition is from llvm/Supprot/ELF.h. But this machine information(e_machine) is given to compiler at lib/MC/ELFObjectWriter.cpp. I greped the whole llvm project and found that e_machine was assigned at only two files. One was lib/MC/ELFObjectWriter.cpp(there was an comment said “e_machine=target”) and the other was tools/obj2yaml/elf2yaml.cpp(GDB stopped only at the

Hi vedant, The program didn't pass the checking "OF->getArch() != Triple(Arch).getArch()" loadBinaryFormat in CoverageMappingReader.cpp and returned an error. It's because "OF->getArch()" returned null and "Triple(Arch).getArch()" returned XXXX(name of my arch). The returned value of " OF->getArch()" is decided by "

What Vedant said -- the profiler runtime provides buffer API for profile dumping. Note that value profiling dumping is not yet supported for buffer API, but since you are using Front-end based instrumentation/profile-use, value profiler is not turned on by default anyway. David On Tue, Dec 19, 2017 at 5:29 PM, Vedant Kumar <vsk at apple.com> wrote: > > On Dec 19, 2017, at 5:16 PM,

As of r313998, this workflow no longer works: cd <build-dir> ./bin/llvm-lit <src>/llvm/tools/clang/test/CoverageMapping I get: llvm-lit: /Users/vk/src/llvm.org-coverage-braces/llvm/tools/clang/test/lit.cfg.py:97: note: using clang: '/Volumes/Builds/llvm.org-coverage-braces-RA/bin/clang' llvm-lit:

Looking, thanks for the report. On Fri, Sep 22, 2017 at 11:22 AM Vedant Kumar <vsk at apple.com> wrote: > As of r313998, this workflow no longer works: > > cd <build-dir> > ./bin/llvm-lit <src>/llvm/tools/clang/test/CoverageMapping > > I get: > > llvm-lit: /Users/vk/src/llvm.org-coverage-braces/llvm/tools/clang/test/ > lit.cfg.py:97: note: using

Thank you So it does not seem to be relevant for what I’m trying to do. I’m doing something unconventional. The objective is to implement PGO and code coverage on a system that does not exit and does not have any file io, or any of stdc libraries that libclang-profile is using. (more like a kernel) So what I’m trying to do is instead of calling __llvm_profile_write_file () from the application,

Hi Vedant, > This sounds fine to me. I don't think we need to preserve the old single-file behavior. We can add a release note about the new behavior. Great! I’d like to change the index.html page to only include coverage data for the filtered functions and do the same for all the ‘source view’ pages. For the index.html page I plan to do the filtering in

On Mon, Jun 10, 2019 at 2:11 PM <vsk at apple.com> wrote: > > > On Jun 6, 2019, at 9:56 AM, Nico Weber <thakis at chromium.org> wrote: > > On Wed, Jun 5, 2019 at 1:33 PM <vsk at apple.com> wrote: > >> >> >> On Jun 4, 2019, at 4:41 PM, Nico Weber <thakis at chromium.org> wrote: >> >> On Mon, Jun 3, 2019 at 2:06 PM <vsk at