similar to: Widescale clang-tidy (or similar) based cleanup

On Fri, Apr 7, 2017 at 3:14 PM Adrian Prantl <aprantl at apple.com> wrote: > > > On Apr 7, 2017, at 3:05 PM, David Blaikie via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > > > > There have been some efforts recently to use clang-tidy or similar > automated refactoring to make project-wide cleanups/improvements to the > LLVM codebase that appear to me

+100 to Mehdi. Large scale cleanups should not only be welcome, they should be encouraged. This is the type of work that almost nobody wants to do and is sorely underappreciated (as evidenced by the fact that this thread even exists, IMHO). Code quality and code health are ongoing costs, and if we raise the barrier to entry for this type of change, then they're not going to happen. Why

Hello, sorry for posting this here but I'm kind of stuck. I'm trying to introduce LLVM tooling step by step at the company I'm working for. So far I'm using clang-format for automated formatting. Since I'm also working on the coding guideline I wanted to use clang-tidy for enforcing the naming convention. The problem is that we're using a plain old MAKE project, so I

> On Dec 29, 2016, at 11:20 AM, David Blaikie <dblaikie at gmail.com> wrote: > > > > On Thu, Dec 29, 2016 at 10:04 AM Mehdi Amini via cfe-dev <cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>> wrote: >> On Dec 29, 2016, at 5:54 AM, Daniel Berlin <dberlin at dberlin.org <mailto:dberlin at dberlin.org>> wrote: >> >>

> On Jan 9, 2017, at 12:47 PM, Renato Golin <renato.golin at linaro.org> wrote: > > On 9 January 2017 at 19:04, Mehdi Amini <mehdi.amini at apple.com> wrote: >> This is not correct according to the number of “should” and the imperative tone for many aspects of http://llvm.org/docs/CodingStandards.html#source-code-formatting > > You mistake the tone of the

Is there an r-tidy program? something that works similar to perl tidy? http://perltidy.sourceforge.net/ which takes program code and reformats white space with standard indentations and spacing? I did find a ruby based rtidy, but that is for html formatting. // George -- George Georgalis, systems architect, administrator <IXOYE><

So, I have a directory of symlinks that I''m managing and Tidy doesn''t seem to be doing much for me in there. Does Tidy ignore symlinks for some reason? If not, does anyone have the correct syntax? Thanks, Trevor --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Users" group. To

Hi, all, I build clang-tidy by "ninja clang-tidy", but when I run below command, I get no checks. Where is the clang-diagnostic* checkers? Thanks in advance. > $ /Users/zyg/Documents/workspace/llvm-project/llvm/cmake-build-debug/bin/clang-tidy --checks="-*,clang-diagnostic-*" --list-checks No checks enabled.

Hi everyone, I would like to start a discussion about enforcing use of clang-tidy (or better clang-tidy-diff) on patches before sending it to review. I like how clang-format simplified sending patches and reviews, e.g. "Use clang-format" instead of giving long list of lines that should be formatted by reviewer. I believe that clang-tidy can be also be very helpful here. Note that by

> On Jan 9, 2017, at 10:29 AM, Renato Golin via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > On 9 January 2017 at 18:20, Reid Kleckner <rnk at google.com> wrote: >> I object to the first. If you need a new type name, use a typedef. It's time >> honored and everyone, including C programmers, will know what you're doing. >> I don't understand

I'm a bit confused by this whole discussion. clang-format is neither mandated (by documentation) nor enforced (by any infrastructure/automation) for use in the LLVM project that I know of. It's convenient, and in review people may reasonably ask authors to consider running it, etc - but we have no system that requires or checks for that. Might be nice, might not be. It sounds like even

We want to modify the aforementioned check so that it does not flag the exceptions that aren't nothrow copy constructible/assignable. This page http://clang.llvm.org/extra/clang-tidy/#using-clang-tidy tells me to dump the configs of all the checks using %clang-tidy -checks=* -dump-config but it does not mention the cert-err60-cpp. How do I modify the configuration of this check so that it

Dave pointed out that I didn't complete one aspect of my argument on the push_back vs. emplace_back: On Thu, Dec 29, 2016 at 2:04 PM Chandler Carruth <chandlerc at gmail.com> wrote: > Still another way to see the consequence of this is to look at the nature > of compiler errors when a programmer makes a mistake. > > With emplace_back, if you fail to call the constructor

I needed to clean someone else code and run it through tidy.source. It encountered a number of hangups which after some experimentation lead me to suspect that the culprit is # symbol when it is a part of literal string. For example if i copy the following to the clipboard confuse.tidy <-    function() {   txt <- 'abra # cadabra' } and run with default arguments >tidy.source()

First, I love this bot:) It makes LLVM's "pushing to master" practise less awful:) Now the main topic... > clang-tidy: fail. Please fix clang-tidy findings. For example, on https://reviews.llvm.org/D72103#1801916 , merge_guards_bot reports clang-tidy findings of existing code, not just the modified code. I think https://github.com/google/llvm-premerge-checks should use

The crazy clang-format folks have taught it to sort includes, and clang-tidy has a nice way to run it across all of LLVM and Clang. Before I just submit the fixes (and any bug reports to the clang-format folks if it sorts things weirdly) I wanted to double check that folks would be ok with this. My understanding is that the sorting should match the LLVM conventions, but if not, I'll make sure

The patches contain some tidy-up work, and refactoring that has arisen as a by-product of my initial work on adding TV support to nv50. Best Regards Joel Holdsworth -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-drm-nouveau-Removed-unneeded-include-in-nvc0_fence.c.patch Type: text/x-patch Size: 726 bytes Desc: not available URL:

On Sat, Oct 17, 2020 at 10:43 PM Greg KH <gregkh at linuxfoundation.org> wrote: > > On Sat, Oct 17, 2020 at 09:09:28AM -0700, trix at redhat.com wrote: > > From: Tom Rix <trix at redhat.com> > > > > This is a upcoming change to clean up a new warning treewide. > > I am wondering if the change could be one mega patch (see below) or > > normal patch

Hi, all, I am planning to add clang-tidy checkers for my company. How to add a new module for my company? Please help, thanks in advance. I try to copy files from cert module, and rename cert to Misra, then add a rule named "m-0-1-1" by ./add_new_checker.py. then I run ninja check-clang-tool, but my case is failed due to below error Running ['clang-tidy',

I'm in the process of writing a clang-tidy check that concerns the position of the "const" keyword. The check should either enforce "T const" or "const T", based on a flag. Naturally, this should extend to all sorts of variations and qualifiers, e.g., X<const T&, Y const*> const&. My approach is to first find the right AST matcher expression to flag