similar to: linkonce_odr & coff

On Tue, Apr 4, 2017 at 12:36 PM, Duncan P. N. Exon Smith < dexonsmith at apple.com> wrote: > > On 2017-Apr-04, at 12:12, Peter Collingbourne <peter at pcc.me.uk> wrote: > > On Mon, Apr 3, 2017 at 8:13 PM, Mehdi Amini <mehdi.amini at apple.com> wrote: > >> >> On Apr 3, 2017, at 7:08 PM, Peter Collingbourne <peter at pcc.me.uk> wrote: >>

[+llvmdev, -llvm-dev] (Oopsies, llvmdev doesn't have a hyphen in it like all the others do) On 6/17/14, 10:45 AM, Jonathan Roelofs wrote: > [+llvm-dev, cfe-dev] > > Was "Re: [PATCH] ARM: allow inline atomics on Cortex M" > > On 6/17/14, 10:42 AM, Jonathan Roelofs wrote: >> >> >> On 6/17/14, 9:35 AM, Renato Golin wrote: >>> On 17 June 2014

Eric, Attached are patches for llvm and clang that implement this. I've made 'none' a component that must be added explicitly (i.e. don't turn arm-eabi into arm--none-eabi, but rather turn it into arm--unknown-eabi) to try to reduce surprises. It also keeps the normalization logic a bit simpler than it would otherwise have to be. SPIR triples were one place where I was

Kostya Serebryany <kcc at google.com> writes: > Justin, > Calling appendToUsed has horrible complexity and if we call it in > every function clang consumes tons of memory (6Gb when compiling one > of the clang's source files). This killed my machine today :) > > The solution is to call appendToUsed once per module, instead of once > per function. Oh right,

On Thu, Aug 24, 2017 at 6:30 PM, Justin Bogner <mail at justinbogner.com> wrote: > Peter Collingbourne <peter at pcc.me.uk> writes: > > On Thu, Aug 24, 2017 at 3:38 PM, Kostya Serebryany <kcc at google.com> > wrote: > > > >> > >> > >> On Thu, Aug 24, 2017 at 3:35 PM, Peter Collingbourne <peter at pcc.me.uk> > >> wrote:

Hello everyone I am linking the Clang libs into my executable for JIT compilation. In order to enable debugging the jited code on OSX via the GDB JIT Interface, I switched the format of the in-memory object files to ELF. I thought this target triple should do:   Triple TT;   TT.setTriple(sys::getProcessTriple());   TT.setObjectFormat(llvm::Triple::ELF); But Clang exits with an error:   backend

I agree with your analysis. I will do the GlobalOpts part as well. The current fix in thinLTO is still good to have for the input that doesn’t have this optimization and I will argue to keep it. Steven > On Feb 9, 2018, at 11:49 AM, Rafael Avila de Espindola <rafael.espindola at gmail.com> wrote: > > Steven Wu <stevenwu at apple.com> writes: > >> Add Rafael here.

Steven Wu <stevenwu at apple.com> writes: > Rafael, another question for you. IRLinker currently takes min visibility for the symbol (lib/Linker/LinkModules.cpp:120). Should it take the max visibility? At least that is what ld64 is doing and is somewhat related to this change because I want to make sure the behavior is consistent if we mark more stuff as hidden. No, it should take the

Steven Wu <stevenwu at apple.com> writes: > Add Rafael here. Because he basically ask me the same question in my commit. > > I wonder why clang choose to do unnamed_addr instead of just do visibility hidden. If linkonce_odr + unnamed_addr is just hidden, is the only difference linkonce_odr + unnamed_addr not in the symbol table? A local symbol being in the symbol table is mostly

I explain that in the same thread to Peter. I talked to Nick yesterday and It turns out to be an implementation choice. The overhead to deduplicate all the non-external symbols are too high so ld64 picks a subset that can potentially be beneficial, which are the "auto hide" symbols. So this is not a correctness issue but we might need a different heuristic for performance. Steven

> On Feb 15, 2018, at 4:16 PM, Rafael Avila de Espindola <rafael.espindola at gmail.com> wrote: > > Steven Wu <stevenwu at apple.com> writes: > >> I did a bit more digging for the auto hide problem. Here is my finding that prevent us from doing this by default in GlobalOpts >> >> 1. When a symbol is linkonce_odr hidden unnamed_addr, it emits both

On Wed, Feb 7, 2018 at 11:35 AM, Mehdi AMINI <joker.eph at gmail.com> wrote: > > From looking at the code, it seems like LLVM is basically opting MachO > into -fvisibility-inlines-hidden all the time, i.e. if the function is > linkonce, it's discardable, so mark it hidden to pretend the compiler > inlined it and discarded it. However, this isn't conforming, because

Rafael, another question for you. IRLinker currently takes min visibility for the symbol (lib/Linker/LinkModules.cpp:120). Should it take the max visibility? At least that is what ld64 is doing and is somewhat related to this change because I want to make sure the behavior is consistent if we mark more stuff as hidden. Steven > On Feb 9, 2018, at 12:04 PM, Steven Wu via llvm-dev <llvm-dev

Steven Wu <stevenwu at apple.com> writes: > I did a bit more digging for the auto hide problem. Here is my finding that prevent us from doing this by default in GlobalOpts > > 1. When a symbol is linkonce_odr hidden unnamed_addr, it emits both '.private_extern' and '.weak_def_can_be_hidden' asm directives on macho platform. There result of that is .private_extern

Isn't #2 actually changing the behavior by changing the visibility while llvm.compiler_used seems actually closest to current behavior to me? The visibility hidden would break comparison of function as you mentioned, which is not the case with auto-hide if I didn't miss anything. -- Mehdi 2018-02-07 11:29 GMT-08:00 Reid Kleckner via llvm-dev < llvm-dev at lists.llvm.org>: >

Steven Wu <stevenwu at apple.com> writes: >> On Feb 15, 2018, at 4:16 PM, Rafael Avila de Espindola <rafael.espindola at gmail.com> wrote: >> >> Steven Wu <stevenwu at apple.com> writes: >> >>> I did a bit more digging for the auto hide problem. Here is my finding that prevent us from doing this by default in GlobalOpts >>>

I'm sorry if this has been asked a quadrillion times before, but i was just wondering about it: I know samba can't be a BDC for ADS. I also know that OpenLDAP can sync with a MS ADS Server. Samba can also auth against both ldap and ADS. so, shoudln't it be possible to use a Samba/openLdap server combination as a Local Master kind of think as a type of BDC for an ADS Domain? Or are

Hello, I recently hit an issue when JIT'ing my generated IR using llvm::orc::LLJIT. My IR contains the following definition of a global variable: > $_ZZ23TestStaticVarInFunctionbE1x = comdat any > @_ZZ23TestStaticVarInFunctionbE1x = linkonce_odr dso_local global i32 123, > comdat, align 4 > And in my host process, there exists the same symbol. I would expect LLJIT to resolve the

I did a bit more digging for the auto hide problem. Here is my finding that prevent us from doing this by default in GlobalOpts 1. When a symbol is linkonce_odr hidden unnamed_addr, it emits both '.private_extern' and '.weak_def_can_be_hidden' asm directives on macho platform. There result of that is .private_extern will win so this is essentially linkonce_odr hidden. 2. ld64 does

Hi, during the week I was thinking to send an email to the upstream development list to see if, at some point in the future, we might have the changes needed for us not to patch their package, or to reduce our patches even more... The points I was going to touch were: /etc/sysconfig: We'd like, if it's possible, to have this be configurable at build time... The default can remain like