similar to: FileCheck: combining -DAG and -NOT

Nope. Sorry, your expectation is incorrect. "BETWEEN BEFORE AFTER" would be accepted, because: (1) the first –DAG matches BEFORE; (2) the –NOT range starts at the preceding match-point, i.e. the (end of the) BEFORE, thus does not find BETWEEN; (3) the second –DAG starts at the same point as the –NOT. That is, the first –DAG and the following –NOT *are* ordered; the –NOT and the

I would personally like a feature like that in FileCheck because it would make it a lot easier to write MachineOutliner tests, and would make the tests significantly smaller and easier to understand. - Jessica > On May 4, 2018, at 8:40 AM, Joel E. Denny via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Hi, > > Using FileCheck, I have not found a way to make a group of

> -----Original Message----- > From: Justin Bogner [mailto:justin at justinbogner.com] On Behalf Of Justin > Bogner > Sent: Wednesday, May 16, 2018 12:16 PM > To: llvm-dev > Cc: jdenny.ornl at gmail.com; Robinson, Paul > Subject: Re: [llvm-dev] RFC: [FileCheck] CHECK-DAG for multiple > occurrences of string > > Paul Robinson <paul.robinson at sony.com> writes:

Right now, the tests try to accomplish the following 1. Define a sequence of instructions (e.g a,b,c) 2. Insert that sequence into k places with an unique instruction between them to make sure the outliner will yank them out *without overlaps* 3. Check for k calls to an outlined function 4. Check that the outlined sequence still exists in the program This can result in some pretty long tests

Hi Jessica, This time I'm replying all.... On Fri, May 4, 2018 at 12:45 PM, Jessica Paquette <jpaquette at apple.com> wrote: > I would personally like a feature like that in FileCheck because it would > make it a lot easier to write MachineOutliner tests, and would make the > tests significantly smaller and easier to understand. > How do MachineOutliner tests accomplish

Paul Robinson <paul.robinson at sony.com> writes: >> From: Joel E. Denny [mailto:jdenny.ornl at gmail.com] >>> On Mon, May 7, 2018 at 12:56 PM, <paul.robinson at sony.com> wrote: >>>> 1. In a CHECK-DAG group, don't let the matches for patterns overlap. >>>> 2. Add a new CHECK-DAG-N directive, where N is some integer, to express

On Wed, May 16, 2018 at 12:38 PM, Joel E. Denny <jdenny.ornl at gmail.com> wrote: > On Wed, May 16, 2018 at 12:24 PM, <paul.robinson at sony.com> wrote: > >> >> >> > -----Original Message----- >> > From: Justin Bogner [mailto:justin at justinbogner.com] On Behalf Of >> Justin >> > Bogner >> > Sent: Wednesday, May 16, 2018

On 05/24/2018 08:46 AM, via llvm-dev wrote: > Background > ---------- > > FileCheck [0] is a cornerstone testing tool for the LLVM project. It > has grown new features over the years to meet new needs, but these > sometimes have surprising and counter-intuitive behavior [1]. This > has become even more evident in Joel Denny's recent quest to repair > what seemed like

On Wed, May 16, 2018 at 12:24 PM, <paul.robinson at sony.com> wrote: > > > > -----Original Message----- > > From: Justin Bogner [mailto:justin at justinbogner.com] On Behalf Of Justin > > Bogner > > Sent: Wednesday, May 16, 2018 12:16 PM > > To: llvm-dev > > Cc: jdenny.ornl at gmail.com; Robinson, Paul > > Subject: Re: [llvm-dev] RFC:

I just stumbled across r332416, which was modifying a test with multiple identical CHECK-DAG directives, which reminded me I needed to get back to you about this... sorry for the slow response. > From: Joel E. Denny [mailto:jdenny.ornl at gmail.com] >> On Mon, May 7, 2018 at 12:56 PM, <paul.robinson at sony.com> wrote: >>> 1. In a CHECK-DAG group, don't let the matches

Hi, Using FileCheck, I have not found a way to make a group of CHECK-DAG directives match multiple occurrences of a string. For example, I naively thought the following would match successfully: ``` $ cat checks.txt // CHECK: start // CHECK-DAG: foo // CHECK-DAG: foo // CHECK-DAG: bar // CHECK-NEXT: end $ cat input.txt start foo bar foo end $ FileCheck --input-file=input.txt checks.txt

On Mon, May 7, 2018 at 12:56 PM, <paul.robinson at sony.com> wrote: > > 1. In a CHECK-DAG group, don't let the matches for patterns overlap. > > 2. Add a new CHECK-DAG-N directive, where N is some integer, to express > > that a pattern must have N non-overlapping matches. > > I think #1 is much more intuitive and easy to describe/document than #2. > Changing

Background ---------- FileCheck [0] is a cornerstone testing tool for the LLVM project. It has grown new features over the years to meet new needs, but these sometimes have surprising and counter-intuitive behavior [1]. This has become even more evident in Joel Denny's recent quest to repair what seemed like an obvious defect [2] but which led me to the conclusion [3] that FileCheck sorely

Hi, I was reading the FileCheck tool documentation [1] this morning and a two parts of the CHECK-DAG: directive don't quite seem right to me. 1. ``` With captured variables, CHECK-DAG: is able to match valid topological orderings of a DAG with edges from the definition of a variable to its use. ``` This is a little confusing. It is not explained what "captured variables" are. My

> 1. In a CHECK-DAG group, don't let the matches for patterns overlap. > 2. Add a new CHECK-DAG-N directive, where N is some integer, to express > that a pattern must have N non-overlapping matches. I think #1 is much more intuitive and easy to describe/document than #2. Changing the meaning of DAG in that way is highly unlikely to affect any existing test, IMO. And if it does, my

"--strict-whitespace By default, FileCheck canonicalizes input horizontal whitespace (spaces and tabs) which causes it to ignore these differences (a space will match a tab). The/--strict-whitespace/ <http://llvm.org/docs/CommandGuide/FileCheck.html#cmdoption--strict-whitespace>argument disables this behavior. End-of-line sequences are canonicalized to UNIX-style ‘n’ in all

See: http://llvm.org/docs/CommandGuide/FileCheck.html It is not required to pipe output to FileCheck; there is the --input-file option, which allows you to run FileCheck on an existing disk file. Something like this: FileCheck %s --input-file a.rpt --check-prefix=A FileCheck %s --input-file b.rpt --check-prefix=B FileCheck %s --input-file c.rpt --check-prefix=C If there are common parts to each

Hi Paul, On Thu, May 24, 2018 at 9:46 AM, <paul.robinson at sony.com> wrote: > Background > ---------- > > FileCheck [0] is a cornerstone testing tool for the LLVM project. It > has grown new features over the years to meet new needs, but these > sometimes have surprising and counter-intuitive behavior [1]. This > has become even more evident in Joel Denny's

Please add llvm-commits as a subscriber to all of these reviews so everyone has a chance to see/comment on them. Thanks, --paulr > -----Original Message----- > From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Elena > Lepilkina via llvm-dev > Sent: Friday, July 15, 2016 6:05 AM > To: llvm-dev > Subject: Re: [llvm-dev] RFC: FileCheck Enhancements > >

http://llvm.org/docs/CommandGuide/FileCheck.html says FileCheck ignores white spaces/tabs by default unless you use "--strict-whitespace" option. 2013/3/15 Shawn <shaolin.xie at ia.ac.cn>: > Hi all: > I'm writing testcase for the MC layer regression in llvm, the > disassembled string is a bit complicate, for example: > "IALU.T0 (I0) = BIU0.DM ; REPEAT