similar to: [LLVMdev] Phabricator (Was: Automatically adding llvm-commits as CC)

Hi Manuel, I like Phabricator for code review much much more than emails. Let me know how I can help (I’m not afraid of PHP). — Mehdi > On May 27, 2015, at 3:12 AM, Manuel Klimek <klimek at google.com> wrote: > > Quick update from IRC chat: > Justin (and anybody else who wants to) is going to file bugs against our phab workflow on the llvm-bugtracker until we get a

Mehdi Amini <mehdi.amini at apple.com> writes: > Hi Manuel, > > I like Phabricator for code review much much more than emails. Let me know how > I can help (I’m not afraid of PHP). Chandler updated the llvm phabricator doc to point at what we're deploying: http://llvm.org/docs/Phabricator.html#status That'll lead you here: https://github.com/r4nt/llvm-reviews

On Fri, 19 Jun 2020, 18:55 Hubert Tong, <hubert.reinterpretcast at gmail.com> wrote: > On Fri, Jun 19, 2020 at 12:32 PM Anton Korobeynikov via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> Just my 2 cents here: we are working on enabling this as a part of >> bugzilla migration as PRs and issues are very tied inside GitHub. Stay >> tuned for updates!

Heya, I'll look into it first thing tomorrow - probably a problem with the encoding settings. On Thu Dec 11 2014 at 9:17:40 PM Robinson, Paul < Paul_Robinson at playstation.sony.com> wrote: > What I'm seeing is that Phabricator emails double-space *everything* > (not just the diffs). > > --paulr > > > > *From:* cfe-dev-bounces at cs.uiuc.edu

On Thu, Dec 11, 2014 at 1:29 AM, Manuel Klimek <klimek at google.com> wrote: > On Thu Dec 11 2014 at 2:16:00 AM Alexey Samsonov <vonosmas at gmail.com> > wrote: > >> On Wed, Dec 10, 2014 at 2:38 PM, Jonathan Roelofs < >> jonathan at codesourcery.com> wrote: >> >>> I think the send-email part of phab has yet to come back up. >>>

Hi folks, phabricator maintenance is a topic that has been lying dormant for a while now. That subsequently creates a non-optimal user experience. For me personally, given that github provides a secure PR infrastructure, the additional effort required to keep Phab going is not an investment I'm personally willing to make. I understand that there are unique selling points for Phab in its UI

On Mon, Jun 22, 2020 at 2:33 AM Manuel Klimek <klimek at google.com> wrote: > On Fri, Jun 19, 2020 at 10:04 PM Mehdi AMINI via cfe-dev < > cfe-dev at lists.llvm.org> wrote: > >> >> >> On Fri, Jun 19, 2020 at 9:56 AM Hubert Tong via llvm-dev < >> llvm-dev at lists.llvm.org> wrote: >> >>> On Fri, Jun 19, 2020 at 12:32 PM Anton

Just my 2 cents here: we are working on enabling this as a part of bugzilla migration as PRs and issues are very tied inside GitHub. Stay tuned for updates! On Fri, Jun 19, 2020 at 3:45 PM Manuel Klimek via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > -Chris' outdated email, +Chris' correct email :) > > On Fri, Jun 19, 2020 at 2:01 PM Manuel Klimek <klimek at

On Mon, Jun 22, 2020 at 9:25 PM David Blaikie <dblaikie at gmail.com> wrote: > On Mon, Jun 22, 2020 at 8:15 PM Mehdi AMINI via cfe-dev > <cfe-dev at lists.llvm.org> wrote: > > > > > > > > On Mon, Jun 22, 2020 at 2:33 AM Manuel Klimek <klimek at google.com> wrote: > >> > >> On Fri, Jun 19, 2020 at 10:04 PM Mehdi AMINI via cfe-dev

On Wed, Dec 10, 2014 at 2:38 PM, Jonathan Roelofs <jonathan at codesourcery.com > wrote: > I think the send-email part of phab has yet to come back up. > Yes, restarting it would be very helpful. > > > Cheers, > > Jon > > > On 12/10/14 1:59 PM, Manuel Klimek wrote: > >> Phab is back up - it's still a little slow (the mysql database we use is

Phab is back up - it's still a little slow (the mysql database we use is doing some cleanups). On Wed Dec 10 2014 at 5:07:07 PM suyog sarda <sardask01 at gmail.com> wrote: > And i was thinking something wrong with my proxy configuration :P > > On Wed, Dec 10, 2014 at 6:47 PM, Manuel Klimek <klimek at google.com> wrote: > >> Heya, >> >> if you wonder

On Sat, Jun 20, 2020 at 1:45 AM Zachary Turner via llvm-dev < llvm-dev at lists.llvm.org> wrote: > There’s also some feature regressions in GH vs Phab. > > You *must* initiate a review via a pull request, and pull request by > definition compares your working copy against master. > > This is not very compatible with LLVMs approach to incremental > development. For

On Fri, Jun 19, 2020 at 9:56 AM Hubert Tong via llvm-dev < llvm-dev at lists.llvm.org> wrote: > On Fri, Jun 19, 2020 at 12:32 PM Anton Korobeynikov via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> Just my 2 cents here: we are working on enabling this as a part of >> bugzilla migration as PRs and issues are very tied inside GitHub. Stay >> tuned for

Hi Manuel, Thanks for the help. Still persists for me too. Instead of waiting indefinitely, now I get this error: Unhandled Exception ("AphrontDeadlockQueryException") #1205: Lock wait timeout exceeded; try restarting transaction On Thu, Dec 11, 2014 at 11:26 AM, suyog sarda <sardask01 at gmail.com> wrote: > The problem still persist :( > > On 12/11/14, Manuel Klimek

How much ongoing work do you estimate Phabracitor requires? There’s the times the server falls over (e.g. database exceptions) and needs to be revived, there’s updates to Phabricator itself, there’s keeping the server updated, and probably a bunch of other work I’m not thinking of. About how much of a time commitment would keeping Phabricator going be, in your estimation? From: llvm-dev

Hi, I am facing problem while submitting patch on phab. All things go smooth - create diff, create revision, specify title and comments. However, when I try to submit the diff by clicking "save" button, it takes a lot of time and eventually times out, failing to submit the patch. Any help on this? On Thursday, December 11, 2014, Manuel Klimek <klimek at google.com> wrote: >

On Fri, Jun 27, 2014 at 8:13 AM, Yaron Keren <yaron.keren at gmail.com> wrote: > Happened to me twice, it would be really nice if Phab would require > confirmation of patches created without CCing one of the two lists, > something like: > > "You have not CCed llvm-commits or cfe-commits, are you creating a private > patch?" > I filed

On Fri, Jun 19, 2020 at 1:15 PM Keith Smiley <keithbsmiley at gmail.com> wrote: > FWIW GitHub's code review tools have improved significantly in the past > few years. At this point with reviews and manual control over resolving / > unresolving comments I think many previous complaints I've seen about > GitHub vs Phabricator have been alleviated. > To be clear: this

Another php type problem; can you please try again. Thanks! On Thu Dec 11 2014 at 1:37:32 PM Bruno Cardoso Lopes < bruno.cardoso at gmail.com> wrote: > I'm facing the same problem. > > On Thu, Dec 11, 2014 at 10:16 AM, suyog sarda <sardask01 at gmail.com> wrote: > > Hi, > > I am facing problem while submitting patch on phab. All things go smooth > - >

I understand that keeping this within one company is easiest from an organization perspective, so if Fangrui and Mehdi (and other Googlers) are able to take this on, that’s great. If not, I can raise this internally at Facebook. An estimate of the total costs incurred would be helpful for that, e.g. you mentioned Sendgrid being a couple of hundred dollars a month. Thanks, Shoaib From: llvm-dev