similar to: [LLVMdev] Patchpoint and Stackmap Instrinsics on Linux/ELF

[+ Lang] > On Jun 13, 2016, at 9:58 AM, Philip Reames via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Andy, Juergen, > > I don't know enough about AArch64 to assess here. Is the proposed change below something we should take in tree? I'm happy to do the mechanics of posting a patch (if Rob doesn't), but I don't know enough to assess. Would such a

Mostly likely, nobody got around to writing ELF tests. The change to enable stack maps on ELF would be fine if it includes a test case. -Andy > On Jun 13, 2016, at 5:38 PM, Lang Hames via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Hi All, > > I don't recall anything MachO specific in the AArch64 stack maps code. Digging through the svn history it looks like the

I figured out the issue -- the AArch64 backend only emits the stack map section if isOSBinFormateMachO() returns true -- see [1], lines 123 - 134. Moving the call to serializeToStackMapSection() outside of the conditional fixes the problem. [1] http://llvm.org/doxygen/AArch64AsmPrinter_8cpp_source.html On Thu, May 26, 2016 at 2:46 PM, Rob Lyerly <rlyerly at vt.edu> wrote: > Hi

Hi everyone, I'm using LLVM's stack map intrinsic to store value location information. I've got a pass that automatically inserts the "llvm.experimental.stackmap" intrinsic into the IR. On x86-64, an ".llvm_stackmaps" section is successfully emitted (I can see the section & its contents in the generated assembly). However I can't get the AArch64 backend

On Oct 23, 2013, at 5:27 PM, Philip Reames <listmail at philipreames.com> wrote: >> The implementation of the two intrinsics is actually very similar. In this case, the difference would be that llvm.stackmap does not reserve space for patching, while llvm.patchpoint does. > I'm slightly confused by this given that stackmap takes an argument indicating the number of nops to emit

On Oct 18, 2013, at 12:39 PM, Chris Lattner <clattner at apple.com> wrote: > On Oct 18, 2013, at 11:08 AM, Andrew Trick <atrick at apple.com> wrote: > >>> >>> I recommend, this being the case, to replace 'webkit' with 'experimental'. Having webkit in the name implies some dependence on webkit, and there is none. Plus, this functionality will

On Fri, Oct 18, 2013 at 1:37 PM, Andrew Trick <atrick at apple.com> wrote: > For the record, I wasn’t aware of any precedent for “llvm.experimental”, > but if it will help avoid backward compatibility issues then it’s a good > thing. > I don't think we have precedent, but I think it will be really good to establish precedent. =] -------------- next part -------------- An

On 10/17/13 10:39 PM, Andrew Trick wrote: > This is a proposal for adding Stackmaps and Patchpoints to LLVM. The > first client of these features is the JavaScript compiler within the > open source WebKit project. > I have a couple of comments on your proposal. None of these are major enough to prevent submission. - As others have said, I'd prefer an experimental namespace

On Oct 18, 2013, at 12:39 PM, Chris Lattner <clattner at apple.com> wrote: > On Oct 18, 2013, at 11:08 AM, Andrew Trick <atrick at apple.com> wrote: > >>> >>> I recommend, this being the case, to replace 'webkit' with 'experimental'. Having webkit in the name implies some dependence on webkit, and there is none. Plus, this functionality will

On Oct 23, 2013, at 7:26 PM, Philip Reames <listmail at philipreames.com> wrote: > On 10/23/13 5:38 PM, Andrew Trick wrote: >> >> On Oct 23, 2013, at 5:27 PM, Philip Reames <listmail at philipreames.com> wrote: >> >>>> The implementation of the two intrinsics is actually very similar. In this case, the difference would be that llvm.stackmap does not

On Oct 18, 2013, at 2:59 PM, Evan Cheng <evan.cheng at apple.com> wrote: > > On Oct 18, 2013, at 12:39 PM, Chris Lattner <clattner at apple.com> wrote: > >> On Oct 18, 2013, at 11:08 AM, Andrew Trick <atrick at apple.com> wrote: >> >>>> >>>> I recommend, this being the case, to replace 'webkit' with 'experimental'.

On 10/23/13 10:03 PM, Andrew Trick wrote: > > On Oct 23, 2013, at 7:26 PM, Philip Reames <listmail at philipreames.com > <mailto:listmail at philipreames.com>> wrote: > >> On 10/23/13 5:38 PM, Andrew Trick wrote: >>> >>> On Oct 23, 2013, at 5:27 PM, Philip Reames >>> <listmail at philipreames.com <mailto:listmail at

On 10/23/13 5:38 PM, Andrew Trick wrote: > > On Oct 23, 2013, at 5:27 PM, Philip Reames <listmail at philipreames.com > <mailto:listmail at philipreames.com>> wrote: > >>> The implementation of the two intrinsics is actually very similar. >>> In this case, the difference would be that llvm.stackmap does not >>> reserve space for patching, while

On 10/22/13 10:48 PM, Andrew Trick wrote: > I'll respond to a few questions below. I'll start a new thread for GC > discussion. Good idea. Thanks. > > On Oct 22, 2013, at 6:24 PM, Philip R <listmail at philipreames.com > <mailto:listmail at philipreames.com>> wrote: > >>> Now with regard to patching. I think llvm.patchpoint is generally

I'll respond to a few questions below. I'll start a new thread for GC discussion. On Oct 22, 2013, at 6:24 PM, Philip R <listmail at philipreames.com> wrote: >> Now with regard to patching. I think llvm.patchpoint is generally useful for any type of patching I can imagine. It does look like a call site in IR, and it’s nice to be able to leverage calling conventions to inform

On 10/22/13 10:34 AM, Filip Pizlo wrote: > On Oct 22, 2013, at 9:53 AM, Philip R <listmail at philipreames.com> wrote: > >> On 10/17/13 10:39 PM, Andrew Trick wrote: >>> This is a proposal for adding Stackmaps and Patchpoints to LLVM. The >>> first client of these features is the JavaScript compiler within the >>> open source WebKit project.

On Oct 18, 2013, at 11:08 AM, Andrew Trick <atrick at apple.com> wrote: >> >> I recommend, this being the case, to replace 'webkit' with 'experimental'. Having webkit in the name implies some dependence on webkit, and there is none. Plus, this functionality will be used by outside projects as soon as it lands in trunk, and I suspect that having webkit in the

On Oct 22, 2013, at 9:53 AM, Philip R <listmail at philipreames.com> wrote: > On 10/17/13 10:39 PM, Andrew Trick wrote: >> This is a proposal for adding Stackmaps and Patchpoints to LLVM. The >> first client of these features is the JavaScript compiler within the >> open source WebKit project. >> > I have a couple of comments on your proposal. None of these

On Oct 18, 2013, at 10:09 AM, Hal Finkel <hfinkel at anl.gov> wrote: > ----- Original Message ----- >> >> On Fri, Oct 18, 2013 at 1:39 AM, Andrew Trick < atrick at apple.com > >> wrote: >> >> >> >> The initial documentation and patches name these intrinsics in a >> "webkit" namespace. This clarifies their current purpose

On Fri, Oct 18, 2013 at 1:39 AM, Andrew Trick <atrick at apple.com> wrote: > > The initial documentation and patches name these intrinsics in a > "webkit" namespace. This clarifies their current purpose and conveys > that they haven't been standardized for other JITs yet. If someone on > the on the dev list says "yes we want to use these too, just the way