similar to: [LLVMdev] [llvm] r170280 - /llvm/trunk/lib/MC/MCPureStreamer.cpp

How did I break the build? I had a totally clean svn updated to the latest and did a build and make check and ran the test-suite. On 12/15/2012 08:23 PM, NAKAMURA Takumi wrote: > Author: chapuni > Date: Sat Dec 15 22:23:20 2012 > New Revision: 170280 > > URL: http://llvm.org/viewvc/llvm-project?rev=170280&view=rev > Log: > MCPureStreamer.cpp: Try to fix build, pruning

Hi Michael, Overall patch looks good. I do have a few comments below. My main comment is please try to make the style match that used in the MCMachOStreamer more closely. I intend to refactor more functionality into the base MCObjectStreamer class, and having them use consistent idioms makes this easier; specific instances are included in the comments: -- > diff --git

I thought of a simpler way to do this which is no more of a hack than the way labels are noramally output. Create an EmitDebugLabel and then in MCAsminfo, add another variable for the suffix for debug labels which can by default be just ":". Then for Mips I can change it to "=." On 11/03/2012 01:40 PM, Reed Kotler wrote: > I'm working on a patch for this problem

I'm working on a patch for this problem for mips16; unfortunately it's a target independent patch. I'm not sure the best nomenclature for this. In the gcc mips16 patch they call "xxx=." a debug label. The other terminology they use is byte pointer vs ISA-encoded address (ISA-encoded meaning this one bit in the case of mips16 ISA). I'm planning to add a virtual method

On Jun 11, 2010, at 6:44 PM, Michael Spencer wrote: > Here is a full patch including Nathan's COFF support, tests that pass > on Windows, and some changes to lit. > > Obviously the COFF support and changes to lit should be separate > patches in the end. > > http://codereview.appspot.com/1624043/show Hi Guys, What is the status of this patch? Here are some comments on

llvm-dev, Thanks so much in advance for any help, tips, or advice you may be able to offer me. I'm going to try to avoid the big-picture description of the project I'm working on, and only talk about the parts that I have trouble with / currently need to implement. -- I've been starting by taking the source code from the "llvm-mc" tool, and working that down into a

On Sun, Jul 11, 2010 at 6:10 PM, Chris Lattner <clattner at apple.com> wrote: > This probably needs to be slightly tweaked to work with mainline.  I don't see anything objectionable, but I think Daniel needs to review this one. Updated patch to work with mainline. http://github.com/Bigcheese/llvm-mirror/commit/d19a4c82c18afc4830c09b70f02d162292231c94 - Michael Spencer

On 7 May 2010 18:14, Chris Lattner <clattner at apple.com> wrote: > > On May 7, 2010, at 10:02 AM, Aaron Gray wrote: > > On 7 May 2010 17:53, Chris Lattner <clattner at apple.com> wrote: > >> >> On May 7, 2010, at 9:51 AM, Nathan Jeffords wrote: >> >> This seems counter intuitive to me, I can understand that C assigned that >>> behavior

Hi Daniel, attached is a patch that pushes most of the object file specific parsing out of AsmParser and down into MachOAsmParser. This was done as a cleanup for the ELF work. I know that you're not happy with this approach, particularly the fact that as we add more object file formats and assembler dialects, it's going to cause a class explosion. But I was hoping that we could use this

Nathan, do you have any other changes? If not, I can make these changes and have a patch ready this evening. Sent from my iPhone On Jun 14, 2010, at 2:16 PM, Chris Lattner <clattner at apple.com> wrote: > > On Jun 11, 2010, at 6:44 PM, Michael Spencer wrote: > >> Here is a full patch including Nathan's COFF support, tests that pass >> on Windows, and some

Michael, I have not made any changes since I last posted a patch. If you would like to make the final updates, thats fine by me. I don't mind making the changes either, I can have them done this evening as well. Chris, As far as naming goes, PE/COFF used in Microsoft's document because they are describing both their version of COFF, and their Portable Execution format which is a

On Wed, Oct 09, 2013 at 08:06:42PM -0500, Jay Cornwall wrote: > Hi, > > This patch adds R600/SI disassembly text to compiled object files, when > a code dump is requested, to assist debugging in Mesa clients. > > Here's an example of the output in a Mesa client with a corresponding > patch and RADEON_DUMP_SHADERS set: > > Shader Disassembly: > >

On Thu, Jan 21, 2016 at 4:04 PM, Craig Topper <craig.topper at gmail.com> wrote: > Isn't it also marked 'final' so it can't be inherited from anyway? What's > your need to inherit from it? > -- > ~Craig > Oops, missed the final part. I need to change the alignment. For my target it is sort of independent of the data layout. I was going to overwrite void

On 12/15/2012 12:53 PM, Chandler Carruth wrote: > On Sat, Dec 15, 2012 at 12:33 PM, Reed Kotler <rkotler at mips.com > <mailto:rkotler at mips.com>> wrote: > > I have an approved target independent putback and i've run all > that we have at Mips as well as on x86 " make TEST=simple" > > Is there anything else that is easy to run that I

On May 7, 2010, at 11:42 AM, Nathan Jeffords wrote: >> $ llc t.ll -o - -mtriple=i386-apple-darwin10 >> .section __TEXT,__text,regular,pure_instructions >> .zerofill __DATA,__bss,_tst1,4,0 ## @tst1 >> .section __DATA,__data >> _tst2: ## @tst2 >> .ascii "\000\001\002\003" >> >> I think we should

On Fri, May 7, 2010 at 10:14 AM, Chris Lattner <clattner at apple.com> wrote: > > On May 7, 2010, at 10:02 AM, Aaron Gray wrote: > > On 7 May 2010 17:53, Chris Lattner <clattner at apple.com> wrote: > >> >> On May 7, 2010, at 9:51 AM, Nathan Jeffords wrote: >> >> This seems counter intuitive to me, I can understand that C assigned that

On May 7, 2010, at 10:02 AM, Aaron Gray wrote: > On 7 May 2010 17:53, Chris Lattner <clattner at apple.com> wrote: > > On May 7, 2010, at 9:51 AM, Nathan Jeffords wrote: > >>> This seems counter intuitive to me, I can understand that C assigned that behavior somewhat arbitrarily to uninitialized global variables, but in LLVM there is explicitly a common linkage

On 7 May 2010 17:53, Chris Lattner <clattner at apple.com> wrote: > > On May 7, 2010, at 9:51 AM, Nathan Jeffords wrote: > > This seems counter intuitive to me, I can understand that C assigned that >> behavior somewhat arbitrarily to uninitialized global variables, but in LLVM >> there is explicitly a common linkage attribute to get that behavior. Nothing >>

I have run "make check", the "test-suite" on x86 and all internal mips flavors with this patch and no problems arose. On 11/04/2012 11:07 AM, Reed Kotler wrote: > The main idea is to distinguish between emitting normal labels and debug > labels. This is the nomenclature chosen by the gcc people working on > this same problem. > > I have just added one