similar to: [LLVMdev] AddressSanitizer+CMake unittest question

On Mon, Jun 25, 2012 at 4:00 PM, Chandler Carruth <chandlerc at google.com>wrote: > Context: I'm trying to implement support for ASan's unittest suite in > CMake. This is ... quite challenging. > > I think I can get it to work with one significant caveat: it will require > manual dependency management. None of the automatic header tracking. I > think this is fine

On Mon, Jun 25, 2012 at 5:43 PM, Kostya Serebryany <kcc at google.com> wrote: > > > On Mon, Jun 25, 2012 at 4:00 PM, Chandler Carruth <chandlerc at google.com>wrote: > >> Context: I'm trying to implement support for ASan's unittest suite in >> CMake. This is ... quite challenging. >> >> I think I can get it to work with one significant

On Tue, Jun 26, 2012 at 11:06 AM, Chandler Carruth <chandlerc at google.com>wrote: > On Mon, Jun 25, 2012 at 7:38 AM, Kostya Serebryany <kcc at google.com> wrote: > > > > > > > > On Mon, Jun 25, 2012 at 5:43 PM, Kostya Serebryany <kcc at google.com> > wrote: > >> > >> > >> > >> On Mon, Jun 25, 2012 at 4:00 PM,

And one more question regarding ASan cmake build. Currently unittests are fine, but regular "clang -faddress-sanitizer" is not: current cmake build stores libclang_rt.asan-x86_64.a together with all the LLVM libs (in $build_path/lib/libclang_rt.asan-x86_64.a), but the Clang driver looks for asan runtime in clang resource dir:

On Tue, Jun 26, 2012 at 12:37 AM, Alexey Samsonov <samsonov at google.com> wrote: > > > > On Tue, Jun 26, 2012 at 11:06 AM, Chandler Carruth <chandlerc at google.com> wrote: >> >> On Mon, Jun 25, 2012 at 7:38 AM, Kostya Serebryany <kcc at google.com> wrote: >> > >> > >> > >> > On Mon, Jun 25, 2012 at 5:43 PM, Kostya

On Mon, Jun 25, 2012 at 7:38 AM, Kostya Serebryany <kcc at google.com> wrote: > > > > On Mon, Jun 25, 2012 at 5:43 PM, Kostya Serebryany <kcc at google.com> wrote: >> >> >> >> On Mon, Jun 25, 2012 at 4:00 PM, Chandler Carruth <chandlerc at google.com> wrote: >>> >>> Context: I'm trying to implement support for ASan's

On Wed, Jul 11, 2012 at 3:06 PM, Alexey Samsonov <samsonov at google.com>wrote: > And one more question regarding ASan cmake build. > Currently unittests are fine, but regular "clang -faddress-sanitizer" is > not: > As a side note: I don't like that the current cmake machinery builds asan tests by explicitly passing libclang_rt.asan-x86_64.a. IMO it needs to use

On Wed, Jul 11, 2012 at 10:03 AM, Kostya Serebryany <kcc at google.com> wrote: > > > On Wed, Jul 11, 2012 at 3:06 PM, Alexey Samsonov <samsonov at google.com>wrote: > >> And one more question regarding ASan cmake build. >> Currently unittests are fine, but regular "clang -faddress-sanitizer" is >> not: >> > > As a side note: I

Hi llvm-dev, I'm trying to figure out how to contribute to LLVM, in particular a followup to kcc's commit 6bde702a in sanitzer_suppressions.cc. However I can't find a way to get the tests to run before I even change anything. The relevant unit test is compiler-rt/lib/sanitizer_common/tests/sanitizer_suppressions_test.cc, so I expect I want `ninja check-asan` (right?). Here's what

Any updates on this? In particular, I'd like to see concrete patches proposed for review and inclusion into LLVM. I think having actual patches on the table and under review will help a great deal. Kostya, let me know if I can help prepare them. A few general comments as well inline... On Tue, Jul 26, 2011 at 1:57 AM, Kostya Serebryany <kcc at google.com> wrote: > On Tue, Jul 26,

On Mon, Aug 1, 2011 at 12:01 PM, Chandler Carruth <chandlerc at google.com>wrote: > Any updates on this? > > In particular, I'd like to see concrete patches proposed for review and > inclusion into LLVM. I think having actual patches on the table and under > review will help a great deal. Kostya, let me know if I can help prepare > them. > Ok, I'll send the

On Jun 21, 2011, at 8:05 AM, Kostya Serebryany wrote: > Hi, > What would be our next steps in getting ASan into the LLVM trunk? > I'd like to do it in two steps, first for the LLVM part with minimal tests and then for the run-time library and all tests. > The current ASan's source repository will probably stay the primary home for the run-time library and tests as we plan

On Thu, Jun 21, 2012 at 1:44 PM, Chandler Carruth <chandlerc at google.com>wrote: > Can we alter the build system so that when building a run-time library it >>>>>>>> modifies all .cpp files like this: >>>>>>>> namespace FOO { >>>>>>>> <file body> >>>>>>>> }

On Tue, Jul 26, 2011 at 10:20 AM, Chris Lattner <clattner at apple.com> wrote: > > On Jun 21, 2011, at 8:05 AM, Kostya Serebryany wrote: > > > Hi, > > What would be our next steps in getting ASan into the LLVM trunk? > > I'd like to do it in two steps, first for the LLVM part with minimal > tests and then for the run-time library and all tests. > >

Hi Daniel, Chris suggested to talk to you about committing the AddressSanitizer (asan) run-time into the llvm tree (llvm-project/compiler-rt). Questions: - What is the preferred name for the directory? (asan? libasan? address_sanitizer? AdressSanitizer?) - Should the asan run-time use cmake, or just make, or what? The build is a bit tricky, especially for tests. We currently use make. - How

Reviving the discussion. The cool cmake-build of compiler-rt is not completely functional, but allows sanitizer runtimes to reuse LLVM code with almost no dirty hacks. Suppose I want to run call functions from LLVM libs (currently: LLVMDebugInfo, LLVMSupport) from sanitizer runtime. 1) I can simply include LLVM headers in sanitizer runtime, and it compiles and builds static asan runtime

On Thu, Nov 24, 2011 at 7:27 AM, Daniel Dunbar <daniel at zuster.org> wrote: > Quick answers, I'm on txgiving break this week and not doing any real > work, but I will be doing more compiler-rt work when I get back > (initially focused at getting profile libs to come from compiler-rt on > Linux et al). > > On Wed, Nov 16, 2011 at 9:24 PM, Kostya Serebryany <kcc at

Quick answers, I'm on txgiving break this week and not doing any real work, but I will be doing more compiler-rt work when I get back (initially focused at getting profile libs to come from compiler-rt on Linux et al). On Wed, Nov 16, 2011 at 9:24 PM, Kostya Serebryany <kcc at google.com> wrote: > Hi Daniel, > Chris suggested to talk to you about committing the AddressSanitizer

On Mon, Nov 28, 2011 at 1:15 PM, Kostya Serebryany <kcc at google.com> wrote: > > > On Thu, Nov 24, 2011 at 7:27 AM, Daniel Dunbar <daniel at zuster.org> wrote: >> >> Quick answers, I'm on txgiving break this week and not doing any real >> work, but I will be doing more compiler-rt work when I get back >> (initially focused at getting profile libs

I'm getting this link failure when running ninja check on Linux. I'm configuring with shared libraries enabled, so I'm not sure why asan is looking for .a archives. $ cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug -DLLVM_BUILD_TESTS=ON -DCLANG_INCLUDE_DOCS=ON -DBUILD_SHARED_LIBS=ON ../llvm $ ninja check-all FAILED: cd [..]bld/projects/compiler-rt/lib/asan/tests &&