similar to: [LLVMdev] Infinite recursion in sys::fs::create_directories()

Hi, sys::fs::create_directories() recurses infinitely for relative paths with only one directory or where the first directory in path doesn't exist. This was observed in r153176. Example: #include <llvm/Support/FileSystem.h> using namespace llvm; int main(int argc, char *argv[]) { bool existed; error_code ec = sys::fs::create_directories(Twine("log"), existed);

llvm::sys::fs::make_absolute converts its first parameter (const Twine &current_directory) to StringRef p(path.data(), path.size()), and then passes that StringRef to several functions (path::has_root_directory, path::has_root_name, and path::append) that accept Twines as parameters. Since llvm::StringRef can implicitly convert to an llvm::Twine, p converts to a bunch of Twine temporaries. In

On Thu, May 17, 2012 at 3:25 PM, Nick Kledzik <kledzik at apple.com> wrote: > I now have an implementation of FileOutputBuffer (OutputBuffer was already taken).  The patch supports the functionality listed below and I've tested that it works for lld. > > To implement the FileOutputBuffer, I needed to add some more functions to llvm/Support/FileSystem.h, including: >  

I now have an implementation of FileOutputBuffer (OutputBuffer was already taken). The patch supports the functionality listed below and I've tested that it works for lld. -------------- next part -------------- A non-text attachment was scrubbed... Name: FileOutputBuffer.patch Type: application/octet-stream Size: 25308 bytes Desc: not available URL:

This is a proposed patch to enhance FileSystem.h to add functionality (getting and setting permission bits and mapping an unmapping files). This implementation follows the N3365 proposal regarding permission bits. This functionality is needed for my next patch which will implement llvm/include/Support/FileOutputBuffer.h which is needed by lld. -------------- next part -------------- A

On Fri, May 18, 2012 at 3:07 PM, Michael Spencer <bigcheesegs at gmail.com> wrote: > >> +  error_code ec = sys::fs::status(filePathTwine, stat); > > stat is undefined if ec isn't success. ec will be success even in the case of > file_not_found. Actually I was wrong. The Windows and UNIX implementation disagree on this point. I'm going to change it to match

I've created a patch that adds a feature that is helpful to my setup. If 'parent_dir_umask' is set in the configuration file, any missing directories in the home directory path are created. The home directory itself is created according to the 'umask' setting, 'parent_dir_umask' is only used for intermediate directories that might need creating. This is useful to me,

Completed testing. Diffs for Path.cpp attached to fix bugs. Some of them are probably present in the Unix version as well. There are some uses of ThrowError when there is no error present in errno to format. A throw statement should be used. Path::is_valid uses realpath on Unix. The problem is that realpath validates that all the directory components of the path actually exist and are

On UNIX, I am executing an rsync command, from within a script. The command goes something like this: /usr/bin/rsync --verbose --progress --stats --compress --recursive --times --perms --links --safe-links source_dir/ user at target_machine:/parent_path/source_dir In other words, I am replicating source_dir on a remote machine. It ends up next to a lot of sibling, directories, like this: On

Hi, I get below error: --------------------------------- In file included from /usr/local/build/llvm/lib/System/platform/Path.cpp:23, from /usr/local/src/llvm/lib/System/Path.cpp:27: /usr/local/build/llvm/lib/System/platform/../Unix/Path.cpp: In member function `bool llvm::sys::Path::create_directory(bool)': /usr/local/build/llvm/lib/System/platform/../Unix/Path.cpp:343:

Hello everyone, 9.0.0-rc2 was tagged yesterday from the release_90 branch at r368683. In the Git monorepo it's available as the llvmorg-9.0.0-rc2 tag. Source code and docs are available at https://prereleases.llvm.org/9.0.0/#rc2 Binaries will be added as they become available. The tag went in roughly one week behind schedule (see "Upcoming Releases" at https://llvm.org), but

Hi everyone, 9.0.0-rc1 was just tagged from the release_90 branch at r367217 (tagged as llvmorg-9.0.0-rc1 in the Git monorepo). Source code and docs are available at https://prereleases.llvm.org/9.0.0/#rc1 Binaries will be added as they become available. Please file bug reports for any issues you find as blockers of https://llvm.org/PR42474 Release testers: please start your engines, run the

Hello everyone, 9.0.0-rc5 was just tagged from the release_90 branch at r371837. In the Git monorepo, it's tagged as llvmorg-9.0.0-rc5. Source code and docs are available at https://prereleases.llvm.org/9.0.0/#rc5 Binaries will be added as they become available. There is only a single change from rc4 to rc5. Once more, the hope is that this will be the last release candidate and that we can

Hi, I've just tagged LLVM 9.0.1-rc3. Testers can begin testing and uploading binaries. This will be the last release candidate unless there is a major problem. I'm planning to tag the final release on Dec 19. -Tom

On Jul 18, 2011, at 12:38 PM, David Blaikie wrote: > I'm attempting to do some amount of mass migration from const std::string& (& const char*) to StringRef. Great! > In doing so I stumbled across the fact that while StringRef has no op+ to speak of (well, it has += and I added a manual StringRef+std::string and std::string+StringRef for now - though I'm thinking perhaps

Hello again, 9.0.0-rc4 was just tagged from the release_90 branch at r371490. In the Git monorepo, it's tagged as llvmorg-9.0.0-rc4. Source code and docs are available at https://prereleases.llvm.org/9.0.0/#rc4 Binaries will be added as they become available. There are not a lot of changes from rc3 to rc4, and there are again no open release blockers, so I'm hoping this will be the last

I'm attempting to do some amount of mass migration from const std::string& (& const char*) to StringRef. In doing so I stumbled across the fact that while StringRef has no op+ to speak of (well, it has += and I added a manual StringRef+std::string and std::string+StringRef for now - though I'm thinking perhaps they can be skipped in favor of Twine operations), Twine does provide a

Hi, I've tagged the LLVM 9.0.1-rc1 release. Testers can begin testing and upload binaries. I've also updated the test-release.sh script to pull from GitHub instead of SVN, if you run into any issues with the new script, let me know. -Tom

Hi, I've just tagged the 9.0.1-final release. Testers can begin uploading binaries. -Tom

Hello everyone, 9.0.0-rc3 was tagged today from the release_90 branch at r370450. In the Git monorepo, it's tagged as llvmorg-9.0.0-rc3. Source code and docs are available at https://prereleases.llvm.org/9.0.0/#rc3 Binaries will be added as they become available. There are currently no open release blockers, which means if nothing new comes up, the final release could ship soon and this is