similar to: [LLVMdev] infinite looping on hashtables

From: José Fonseca <jfonseca at vmware.com> When the hash function uses object pointers all free entries eventually become tombstones as they are used at least once, regardless of the size. DenseMap cannot function with zero empty keys, so it double size to get get ridof the tombstones. However DenseMap never shrinks automatically unless it is cleared, so the net result is that certain

On Apr 28, 2009, at 4:15 PM, Stuart Hastings wrote: > I think this is abusing DenseSet.h, but the bug report says it used to > work... I never claimed any such thing. :) This did come up in a real situation where I know the size of a particular set. The set can get large enough to justify giving size advice to the implementation, but it can also be quite small, which triggered this

This series of patches address several issues causing memory usage to grow indefinetely on a long lived process. These are not convenional leaks -- memory would have been freed when the LLVM context or/and JIT engine is destroyed -- but for as long as they aren't the memory is usage effectively ubounded. The issues were found using valgrind with '--show-reachable=yes' option: 1.

tl;dr: I think we have too many different set classes. They have incompatible APIs and surprising behavior. I think we can reduce their number substantially. Dear all, The following is a subset of the set classes we have in ADT: * DenseSet * SmallDenseSet (https://reviews.llvm.org/D25628) * SetVector * SmallSetVector * SmallSet * SmallPtrSet * StringSet * FoldingSet *

In SmallVector.h: class SmallVectorBase { *protected:* void *BeginX, *EndX, *CapacityX; *protected:* SmallVectorBase(void *FirstEl, size_t Size) : BeginX(FirstEl), EndX(FirstEl), CapacityX((char*)FirstEl+Size) {} In StringMap.h: class StringMapImpl { *protected:* // Array of NumBuckets pointers to entries, null pointers are holes. // TheTable[NumBuckets] contains a sentinel value

Hello everyone! I'm a newcomer for the great LLVM project. I've started to explore the source code of LLVM project to become more familiar with it, and I've found some strange usage of move semantics in constructor of StringMapImpl( StringMapImpl &&RHS) {...} class in include/llvm/ADT/StringMap.h line 56. Could anyone explain me the purpose of zeroing of all fields of RHS in

It sounds like we are kindred spirits. I am using an old PC, with linux installed, running tcpdump as my packet sniffer. I will experiment with data frames as you suggest to get the hang of R some more before worrying about hashtables again. Chris Marshall -----Original Message----- From: M. Edward (Ed) Borasky To: Chris Marshall Cc: r-help at stat.math.ethz.ch Sent: 4/25/01 4:44 PM Subject:

I have a question about a few things: ok when you have parent x:x and handle x:x link x:x flowid and so on. What is the max values of each of these, also where these or some of these hex numbers? I tried this on redhat 7.3 so there may have been some updates, but this is one of the tests I did. [root@RL1 root]# tc filter add dev eth0 protocol ip parent 1:0 prio 10 u32 ht fffe:: match ip dst

Here are two minor patches. The first adds an insert method to DenseSet that takes two iterators representing the beginning and ending of a range of items to insert. I lifted the code verbatim from DenseMap.h. The second patch defines DenseMapInfo for chars. This is useful because DenseSet is implemented as a DenseMap of (Type, char), so anyone who uses DenseSet has to define DenseMapInfo for

I suppose I am looking for recommendations on the right book on R for me. This post drones on a bit about what sort of programming I do and is basically asking if there are any books on R written with me in mind. I also make a proposal regarding R documentation at the end. I started reading "Programming with Data," by Chambers, got really excited in chapter 1, then found that I had a

I'm seeing some test failures for unit tests for msan (check-msan) happening in googletest, which I find weird. I'm on Arch Linux, with r342711. Below is one type of error that I see. The full log is 416MB (!) big. My guess is that those errors are related, but if anyone needs the full log, I'll provide it. Here is a reduced log from the end:

Hi all, I'm currently writing some unit tests for some debug line error handling code I'm working on (see e.g. https://reviews.llvm.org/D44382), and I just ran into an annoying disabled feature in gtest, specifically the "Combine" feature for use in combinatorially generating parameterised tests. A FIXME comment in ProfileData\CoverageMappingTest.cpp suggests that I'm not

(Forwarding this to llvm-dev) This patch adds a unit test framework to LLVM, along with a sample unit test for DenseMap. I don't expect this patch to be accepted as-is, this is mainly a trial balloon and proof of concept. Some notes about the patch: 1) For the testing framework, I went with Google Test, since it's the one I have the most experience with. I fully expect an extended

+Chandler who might have some thoughts on this. Could you provide an example here of the motivation for the feature you're missing? Might help motivate the discussion (and/or we'll end up nitpicking how it could be done differently without that feature... - which is sort of where I'm going with this. Combinatorial test case expansion does seem a bit suspicious to me - I'd hope we

Tobias, I've attached an updated copy of the patch. I believe that I accounted for all of your suggestions except for: 1. You said that I could make AA a member of the class and initialize it for each basic block. I suppose that I'd need to make it a pointer, but more generally, what is the thread-safely model that I should have in mind for the analysis passes (will multiple threads

On Thu, Mar 15, 2018 at 9:09 PM, David Blaikie via llvm-dev <llvm-dev at lists.llvm.org> wrote: > +Chandler who might have some thoughts on this. > > Could you provide an example here of the motivation for the feature you're > missing? Might help motivate the discussion (and/or we'll end up nitpicking > how it could be done differently without that feature... - which

Hi Kees, You added some support for Minix to LLVM's copy of googletest: http://llvm.org/viewvc/llvm-project?view=rev&revision=100895 Is it still being used? If so, would you mind pushing these patches upstream to the googletest project: http://code.google.com/p/googletest/ Otherwise we may drop them, because it makes it harder to import new releases of googletest into the LLVM

On Thu, Mar 15, 2018 at 11:10 AM David Blaikie via llvm-dev < llvm-dev at lists.llvm.org> wrote: > +Chandler who might have some thoughts on this. > FWIW, I have no concerns about updating to a modern googletest. More modern the better IMO if someone is willing to do the work to make sure it works on all our platforms, etc. However: > Could you provide an example here of the

Reverse iteration doesn't really make sense for DenseSet, since its iteration order isn't meaningful to begin with... --Owen On Jul 12, 2012, at 8:20 AM, Vassil Vassilev wrote: > Hi, > I need a data structure which has fast search and I can walk it > forward and backward. Is there something like that in LLVM ADT which am > not aware of? And if not can I implement it in

On Fri, 2011-12-02 at 17:07 +0100, Tobias Grosser wrote: > On 11/23/2011 05:52 PM, Hal Finkel wrote: > > On Mon, 2011-11-21 at 21:22 -0600, Hal Finkel wrote: > >> > On Mon, 2011-11-21 at 11:55 -0600, Hal Finkel wrote: > >>> > > Tobias, > >>> > > > >>> > > I've attached an updated patch. It contains a few bug fixes