similar to: [LLVMdev] Private headers and testing

On Jan 2, 2009, at 12:21 PM, Misha Brukman wrote: > Hi all, > > Reading this doc: http://llvm.org/docs/CodingStandards.html#hl_privateheaders > , it suggests putting private implementation details outside of llvm/ > include/* to avoid polluting the public header space. This makes > sense, and it works fine, because make enters every directory and > hence doesn't

On Dec 30, 2008, at 2:54 PM, Talin wrote: > OK changes made and new patch attached. Nice +++ utils/unittest/Makefile (revision 0) ... +# This has to come after Makefile.common, since it doesn't allow us to +# override the VPATH value unless we set PROJECT_NAME, which we don't want +# to do. +VPATH = $(LLVM_SRC_ROOT)/utils/unittest/googletest/src/ Why play with VPATH here? What

2008/12/31 Chris Lattner <clattner at apple.com> > On Dec 30, 2008, at 2:54 PM, Talin wrote: > > OK changes made and new patch attached. > > +++ utils/unittest/Makefile (revision 0) > > ... > +# This has to come after Makefile.common, since it doesn't allow us to > +# override the VPATH value unless we set PROJECT_NAME, which we don't want > +# to do.

2009/1/2 Chris Lattner <clattner at apple.com> > On Jan 2, 2009, at 12:21 PM, Misha Brukman wrote: > Do you have a specific example of a unit test that would need these? I > really think these should stay private. > Let's take lib/Transforms/Utils/CodeExtractor.cpp . The public interface for it is in include/llvm/Transform/Utils/FunctionUtils.h, with only the high-level

+++ unittests/TestMain.cpp (revision 0) +//===--- unittest.cpp - unittest driver -----------------------------------===// +++ unittests/ADT/DenseMapTest.cpp (revision 0) +//===- llvm/unittest/DenseMapMap.h - DenseMap unit tests --------*- C++ -*-===// You probably want to update these file headers to match their real names. 2008/12/30 Misha Brukman <brukman at gmail.com> >

OK changes made and new patch attached. Comments below: On Tue, Dec 30, 2008 at 2:40 PM, Misha Brukman <brukman at gmail.com> wrote: > +++ unittests/TestMain.cpp (revision 0) > +//===--- unittest.cpp - unittest driver > -----------------------------------===// > > +++ unittests/ADT/DenseMapTest.cpp (revision 0) > +//===- llvm/unittest/DenseMapMap.h - DenseMap unit

After following all steps from http://llvm.org/docs/TestingGuide.html#testsuiterun, I've got this: make[1]: Entering directory `/cygdrive/c/projects/thesis/llvm-suite-2.6/llvm-2.6/projects/test-suite/SingleSource' make[2]: Entering directory `/cygdrive/c/projects/thesis/llvm-suite-2.6/llvm-2.6/projects/test-suite/SingleSource/UnitTests' make[3]: Entering directory

On Jan 2, 2009, at 1:48 PM, Misha Brukman wrote: > 2009/1/2 Chris Lattner <clattner at apple.com> > On Jan 2, 2009, at 12:21 PM, Misha Brukman wrote: > Do you have a specific example of a unit test that would need > these? I really think these should stay private. > > Let's take lib/Transforms/Utils/CodeExtractor.cpp . The public > interface for it is in

2009/1/3 Chris Lattner <clattner at apple.com> > On Jan 2, 2009, at 1:48 PM, Misha Brukman wrote: > > 2009/1/2 Chris Lattner <clattner at apple.com> > >> On Jan 2, 2009, at 12:21 PM, Misha Brukman wrote: >> Do you have a specific example of a unit test that would need these? I >> really think these should stay private. >> > > Let's take

Hooray! I'm thinking that getting unit tests for the classes in ADT should be an early goal. I also wanted to mention a point about the general philosophy of unit testing, which is that the presence of such tests alters the calculation of risk when making changes to a code base. Programmers have various rules of thumb for estimating risk - for example, a change which affects a large

Hi All, I am trying to configure llvm so with test-suite enabled. I have downloaded the test-suite. Spec 2000 benchmarks sources are plugged in speccpu2000 at $LLVM_SRC_ROOT/projects/test-suite-externals/speccpu2000/benchspec e.g.: 164.gzip dir is $LLVM_SRC_ROOT/projects/test-suite-externals/speccpu2000/benchspec/164.gzip My configure command is: ../configure --disable-optimized

On Sat, 2005-06-18 at 10:32 +0200, Henrik Bach wrote: > Hi LLVMers, > > The root of my SRC_DIR is: /home/hb/projects/src/llvm-1/llvm/ > and the root of my OBJ_DIR is: /home/hb/projects/build/FC1/llvm-1-1. > > However, the configure script seems to have stripped some of the / from the > paths: > Makefile.common:63: /home/hb/projects/buildFC1llvm-1-1/Makefile.config: No

Hi! In current LLVM CVS: llvm/projects/Stacker/Makefile.common.in llvm/projects/sample/Makefile.common.in llvm-java/llvm-java/Makefile.common.in have line: include $(LLVM_OBJ_ROOT)/Makefile.common that have line: include $(LLVM_OBJ_ROOT)/Makefile.config (also $(LLVM_OBJ_ROOT)/Makefile.config used in llvm-test/Makefile.config.in) and llvm/Makefile.config.in have lines: INSTALL_SH :=

Hi Duncan, Do you have sources also in the $LLVM_SRC_ROOT/projects/test-suite/External/SPEC/CINT2000/164.gzip? The following is content of above directory in my case. I have copied the CINT2000 sources in this directory manually. $ls -1 $LLVM_SRC_ROOT/projects/test-suite/External/SPEC/CINT2000/164.gzip 164.gzip.reference_output 164.gzip.reference_output.small compile_info compile_parms

Hi Daya, > checking for spec2000 benchmark sources... no, not found in > $LLVM_SRC_ROOT/projects/test-suite-externals/speccpu2000/benchspec I have 164.gzip at $LLVM_SRC_ROOT/projects/test-suite/External/SPEC/CINT2000/164.gzip and it seems to work. Ciao, Duncan.

On Mon, 2005-02-14 at 20:53, Chris Lattner wrote: > On Mon, 14 Feb 2005, Reid Spencer wrote: > > > Personally, I don't think LLVM projects should need much in the way of > > autoconf stuff. They certainly don't need to replicate things like > > install-sh and mkinstalldirs. I'd vote for taking these out of the > > projects rather than making the makefiles

On Fri, Apr 11, 2008 at 3:24 PM, John Criswell <criswell at cs.uiuc.edu> wrote: > Lane Schwartz wrote: > > > [snip] > > > > OK then. I didn't realize that having a newer version would be a problem. > > > > I compiled and installed autoconf 2.59. I still get the same problem: > > > > $ autoconf --version > > autoconf (GNU Autoconf)

On Mon, 14 Feb 2005, Reid Spencer wrote: > Personally, I don't think LLVM projects should need much in the way of > autoconf stuff. They certainly don't need to replicate things like > install-sh and mkinstalldirs. I'd vote for taking these out of the > projects rather than making the makefiles deal with them. I think in > most cases these are just historical artifacts

Personally, I don't think LLVM projects should need much in the way of autoconf stuff. They certainly don't need to replicate things like install-sh and mkinstalldirs. I'd vote for taking these out of the projects rather than making the makefiles deal with them. I think in most cases these are just historical artifacts that have been with the projects since long before the new

Try using the --with-llvmsrc and --with-llvmobj options to explicitly set the locations of your LLVM source tree and object tree, respectively. I faintly recall seeing this error and seem to recall using these options to work around it. -- John T. ________________________________________ From: llvmdev-bounces at cs.uiuc.edu [llvmdev-bounces at cs.uiuc.edu] On Behalf Of Lane Schwartz [dowobeha at