similar to: [LLVMdev] Unit test patch, updated

2008/12/30 Talin <viridia at gmail.com> > Here's the version of the unit test patch, incorporating the feedback I > have received so far. > Looks good, a few comments below. > Some notes on the patch: > > - This patch doesn't include googletest itself, that will need to be > checked in separately. The source distribution will live in >

+++ unittests/TestMain.cpp (revision 0) +//===--- unittest.cpp - unittest driver -----------------------------------===// +++ unittests/ADT/DenseMapTest.cpp (revision 0) +//===- llvm/unittest/DenseMapMap.h - DenseMap unit tests --------*- C++ -*-===// You probably want to update these file headers to match their real names. 2008/12/30 Misha Brukman <brukman at gmail.com> >

OK changes made and new patch attached. Comments below: On Tue, Dec 30, 2008 at 2:40 PM, Misha Brukman <brukman at gmail.com> wrote: > +++ unittests/TestMain.cpp (revision 0) > +//===--- unittest.cpp - unittest driver > -----------------------------------===// > > +++ unittests/ADT/DenseMapTest.cpp (revision 0) > +//===- llvm/unittest/DenseMapMap.h - DenseMap unit

On 30 June 2014 16:16, Shankar Easwaran <shankare at codeaurora.org> wrote: > I think you are hitting a bug, the Observer pattern was added a few weeks > back, and may be there is some sort of uninitialized variable ? This is my back-trace at "-O2 -g" (since -O1 pass): operator() (file=<optimized out>, __closure=0x7fffffffde40) at

On Dec 30, 2008, at 2:54 PM, Talin wrote: > OK changes made and new patch attached. Nice +++ utils/unittest/Makefile (revision 0) ... +# This has to come after Makefile.common, since it doesn't allow us to +# override the VPATH value unless we set PROJECT_NAME, which we don't want +# to do. +VPATH = $(LLVM_SRC_ROOT)/utils/unittest/googletest/src/ Why play with VPATH here? What

$(llvm-config --libs | tr " " "\n" | grep gtest) returns: -lgtest_main -lgtest instead of non-valid: -lLLVMgtest_main -lLLVMgtest It also fixes: $(ld): cannot find -lLLVMgtest $(ld): cannot find -lLLVMgtest_main --- unittests/Makefile.unittest | 2 +- utils/llvm-build/llvmbuild/componentinfo.py | 4 ++-- utils/llvm-build/llvmbuild/main.py |

I'm seeing some test failures for unit tests for msan (check-msan) happening in googletest, which I find weird. I'm on Arch Linux, with r342711. Below is one type of error that I see. The full log is 416MB (!) big. My guess is that those errors are related, but if anyone needs the full log, I'll provide it. Here is a reduced log from the end:

Current revision 285840 fails to build on FreeBSD. I used the command: cmake -G "Unix Makefiles" ../llvm -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX:PATH=/opt/llvm/current && gmake (I am aware of FreeBSD llvm/clang ports, but the source build should always succeed as well.) Yuri ---errors--- Scanning dependencies of target gtest [ 91%] Building CXX object

Hello, GCC 9.0 introduces a new warning checkers and some of them found possible issues in LLVM. In file included from /home/davidbolvansky/trunk/llvm/include/llvm/Analysis/LazyCallGraph.h:38, from /home/davidbolvansky/trunk/llvm/unittests/Analysis/LazyCallGraphTest.cpp:10: /home/davidbolvansky/trunk/llvm/include/llvm/ADT/ArrayRef.h: In instantiation of

Folks, I'm having a look at LLD and I need some guidance... I know it's not production ready for x86 and ARM (the idea is to make it so). My steps: I've added it to tools/lld and ran CMake again (on x86_64) on a standard release build (static linking). It works, builds but I see one unit test error: Note: Google Test filter = InputGraphTest.Observer [==========] Running 1 test from

Hi folks, I'm using gcc 4.8.1 and I'm getting these warnings on every googletest file: src/llvm/utils/unittest/googletest/include/gtest/gtest-typed-test.h:239:47: warning: anonymous variadic macros were introduced in C99 [-Wvariadic-macros] # define REGISTER_TYPED_TEST_CASE_P(CaseName, ...) \ ^ It seems a gtest infrastructure file, so maybe

On Dec 22, 7:34 pm, Talin <viri... at gmail.com> wrote: > (Forwarding this to llvm-dev) > > This patch adds a unit test framework to LLVM, along with a sample unit test > for DenseMap. I don't expect this patch to be accepted as-is, this is mainly > a trial balloon and proof of concept. I think this is a great idea! As Keir already noted, I would also agree with LLVM

Is no one else seeing this? (I've been seeing it for a few days) In file included from /usr/local/google/home/blaikie/dev/llvm/src/utils/unittest/googletest/gtest-all.cc:39: In file included from /usr/local/google/home/blaikie/dev/llvm/src/utils/unittest/googletest/include/gtest/gtest.h:57: In file included from

Misha Brukman wrote: > On Dec 22, 7:34 pm, Talin <viri... at gmail.com> wrote: > >> (Forwarding this to llvm-dev) >> >> This patch adds a unit test framework to LLVM, along with a sample unit test >> for DenseMap. I don't expect this patch to be accepted as-is, this is mainly >> a trial balloon and proof of concept. >> > > I think

On Fri, Dec 26, 2008 at 8:06 PM, Misha Brukman <brukman at gmail.com> wrote: > On Dec 22, 7:34 pm, Talin <viri... at gmail.com> wrote: > > (Forwarding this to llvm-dev) > > > > This patch adds a unit test framework to LLVM, along with a sample unit > test > > for DenseMap. I don't expect this patch to be accepted as-is, this is > mainly > > a

I want to start using cmake+ninja instead of autoconf for configuring and building llvm from svn, but I have no idea how to map my existing list of autoconf flags to cmake. Here's how I run ./configure right now in the top directory: PREFIX=_some_prefix_dir_ \ ../llvm/configure \ --prefix=$PREFIX \ --libdir=$PREFIX/lib/llvm \ --sysconfdir=$PREFIX/etc \ --enable-shared \

Nice! This looks good to me but probably Chris or someone else should sign off on it. There were two minor warnings on Darwin: -- In file included from /Volumes/Data/Users/ddunbar/llvm/lib/Support/regexec.c:81: /Volumes/Data/Users/ddunbar/llvm/lib/Support/regengine.inc: In function 'sbackref': /Volumes/Data/Users/ddunbar/llvm/lib/Support/regengine.inc:665: warning: control reaches end of

+eugenis I see this while running 'check-msan'. On Sun, May 12, 2013 at 9:10 PM, David Blaikie <dblaikie at gmail.com> wrote: > Is no one else seeing this? (I've been seeing it for a few days) > > In file included from > > /usr/local/google/home/blaikie/dev/llvm/src/utils/unittest/googletest/gtest-all.cc:39: > In file included from > >

On 24 July 2011 10:59, Duncan Sands <baldrick at free.fr> wrote: > Hi Edward, > >> Building of llvm with gcc-4.5.2-1 gives these warnings: >> >> 1) Building FileManagerTest >> >> "llvm[4]: Compiling FileManagerTest.cpp for Debug+Asserts build >> C:/Programming/VersionControl/llvm/tools/clang/unittests/Basic/FileManagerTest.cpp: >> In

(Forwarding this to llvm-dev) This patch adds a unit test framework to LLVM, along with a sample unit test for DenseMap. I don't expect this patch to be accepted as-is, this is mainly a trial balloon and proof of concept. Some notes about the patch: 1) For the testing framework, I went with Google Test, since it's the one I have the most experience with. I fully expect an extended