similar to: [LLVMdev] strict aliasing warning in x86 land

On Saturday 15 December 2007 08:36:02 Mike Stump wrote: > /Volumes/mrs5/net/llvm/llvm/llvm/lib/Target/X86/X86ISelLowering.cpp: > In member function 'llvm::SDOperand > llvm::X86TargetLowering::LowerTRAMPOLINE(llvm::SDOperand, > llvm::SelectionDAG&)': > /Volumes/mrs5/net/llvm/llvm/llvm/lib/Target/X86/X86ISelLowering.cpp: > 5305: warning: dereferencing type-punned

On Dec 15, 2007, at 2:15 AM, Duncan Sands wrote: > Can you please paste the line (line number 5305 isn't in > LowerTRAMPOLINE > in my tree...). You have to run svn update for it to have that line... :-) unsigned char N86Reg = ((X86RegisterInfo&)RegInfo).getX86RegNum(NestReg); I've not thought long or hard about the validity of the warning... I'm hoping

/Volumes/mrs5/net/llvm/llvm/llvm/lib/Target/CellSPU/ SPUISelDAGToDAG.cpp: In function 'bool<unnamed>::isFPS16Immediate(llvm::ConstantFPSDNode*, short int&)': /Volumes/mrs5/net/llvm/llvm/llvm/lib/Target/CellSPU/ SPUISelDAGToDAG.cpp:141: warning: dereferencing type-punned pointer will break strict-aliasing rules In file included from

They looked real enough to me: /Volumes/mrs5/net/llvm/llvm/lib/Target/CellSPU/SPUISelDAGToDAG.cpp: In function ‘bool<unnamed>::isFPS16Immediate(llvm::ConstantFPSDNode*, short int&)’: /Volumes/mrs5/net/llvm/llvm/lib/Target/CellSPU/SPUISelDAGToDAG.cpp: 148: warning: dereferencing type-punned pointer will break strict- aliasing rules

llvm[3]: Compiling SPUISelDAGToDAG.cpp for Debug build In file included from /Volumes/mrs5/net/llvm/llvm/lib/Target/CellSPU/ SPUISelDAGToDAG.cpp:334: /Volumes/mrs5/net/llvm/llvm-build/lib/Target/CellSPU/ SPUGenDAGISel.inc: In member function ‘llvm::SDNode* SPUDAGToDAGISel::Emit_5(const llvm::SDOperand&, unsigned int, unsigned int, llvm::MVT::ValueType, llvm::MVT::ValueType)’:

On Dec 20, 2007, at 3:56 PM, Mike Stump wrote: > They looked real enough to me: Fixed, thanks. -Chris > > > /Volumes/mrs5/net/llvm/llvm/lib/Target/CellSPU/SPUISelDAGToDAG.cpp: In > function ‘bool<unnamed>::isFPS16Immediate(llvm::ConstantFPSDNode*, > short int&)’: > /Volumes/mrs5/net/llvm/llvm/lib/Target/CellSPU/SPUISelDAGToDAG.cpp: > 148: warning:

On Jan 30, 2008, at 2:10 PM, Mike Stump wrote: > /Volumes/mrs5/net/llvm/llvm-build/lib/Target/CellSPU/ > SPUGenDAGISel.inc: In member function ‘llvm::SDNode* > SPUDAGToDAGISel::Emit_5(const llvm::SDOperand&, unsigned int, unsigned > int, llvm::MVT::ValueType, llvm::MVT::ValueType)’: Merely rming the file makes it work again. Would be nice if the rules were always incremental

I'm seeing a build failure... In file included from /Volumes/mrs5/net/llvm/llvm/lib/VMCore/ Attributes.cpp:14: /Volumes/mrs5/net/llvm/llvm/include/llvm/Attributes.h: In member function 'llvm::Attributes llvm::AttrListPtr::getParamAttributes(unsigned int) const': /Volumes/mrs5/net/llvm/llvm/include/llvm/Attributes.h:152: error: 'assert' was not declared in this scope

FAIL: /Volumes/mrs5/net/llvm/llvm/test/CFrontend/2007-09-20- GcrootAttribute.c Failed with exit(1) at line 3 while running: /Volumes/mrs5/Packages/llvm-2/bin/llvm-gcc -emit-llvm - S -emit-llvm /Volumes/mrs5/net/llvm/llvm/test/CFrontend/2007-09-20- GcrootAttribute.c -o - | llvm-as llvm-as: assembly parsed, but does not verify as correct! Enclosing function does not specify a collector algorithm.

/Volumes/mrs5/net/llvm/llvm/lib/Transforms/Scalar/CodeGenPrepare.cpp: In member function ‘bool<unnamed>::CodeGenPrepare::OptimizeInlineAsmInst (llvm::Instruction*, llvm::CallSite, llvm::DenseMap<llvm::Value*, llvm::Value*, llvm::DenseMapInfo<llvm::Value*>, llvm::DenseMapInfo<llvm::Value*> >&)’:

Works for me. Presumably #including <cassert> will fix it though? On Sep 26, 2008, at 4:30 PMPDT, Mike Stump wrote: > I'm seeing a build failure... > > In file included from /Volumes/mrs5/net/llvm/llvm/lib/VMCore/ > Attributes.cpp:14: > /Volumes/mrs5/net/llvm/llvm/include/llvm/Attributes.h: In member > function 'llvm::Attributes >

2 new warnings in llvm: /Volumes/mrs5/net/llvm/llvm/lib/AsmParser/LLParser.cpp: In member function 'bool llvm::LLParser::ParseGlobal(const std::string&, const char*, unsigned int, bool, unsigned int)': /Volumes/mrs5/net/llvm/llvm/lib/AsmParser/LLParser.cpp:446: warning: 'IsConstant' may be used uninitialized in this function

/Volumes/mrs5/net/llvm/llvm/lib/Transforms/Scalar/ InstructionCombining.cpp: In member function ‘llvm::Instruction*<unnamed>::InstCombiner::visitAnd (llvm::BinaryOperator&)’: /Volumes/mrs5/net/llvm/llvm/lib/Transforms/Scalar/ InstructionCombining.cpp:3597: warning: ‘RHSCC’ may be used uninitialized in this function /Volumes/mrs5/net/llvm/llvm/lib/Transforms/Scalar/

Newer g++ compilers can emit: /Volumes/mrs5/net/llvm/llvm/llvm/lib/AsmParser/LLLexer.cpp: In member function 'int llvm::LLLexer::LexAt()': /Volumes/mrs5/net/llvm/llvm/llvm/lib/AsmParser/LLLexer.cpp:287: warning: suggest a space before ';' or explicit braces around empty body in 'for' statement /Volumes/mrs5/net/llvm/llvm/llvm/lib/AsmParser/LLLexer.cpp: In member

On darwin x86, I'm seeing: $ make ENABLE_OPTIMIZED=1 llvm[2]: Compiling LiveIntervalAnalysis.cpp for Release build Assertion failed: (MVT::isInteger(LVT)), function MeetsMaxMemopRequirement, file /Volumes/mrs5/net/llvm/llvm/lib/CodeGen/ SelectionDAG/SelectionDAGISel.cpp, line 4230. /Volumes/mrs5/net/llvm/llvm/lib/CodeGen/LiveIntervalAnalysis.cpp:1466: internal compiler error: Abort trap

A new warning: /Volumes/mrs5/net/llvm/llvm/lib/AsmParser/LLParser.cpp: In member function 'bool llvm::LLParser::ParseGlobal(const std::string&, const char*, unsigned int, bool, unsigned int)': /Volumes/mrs5/net/llvm/llvm/lib/AsmParser/LLParser.cpp:448: warning: 'IsConstant' may be used uninitialized in this function

llvm no build? llvm/llvm/lib/Target/PIC16/PIC16AsmPrinter.cpp: In member function ‘bool llvm::PIC16AsmPrinter::printMachineInstruction(const llvm::MachineInstr*)’: llvm/lib/Target/PIC16/PIC16AsmPrinter.cpp:80: error: ‘CurBank’ was not declared in this scope llvm/lib/Target/PIC16/PIC16AsmPrinter.cpp: In member function ‘virtual bool llvm::PIC16AsmPrinter::runOnMachineFunction

Mike Stump wrote: > llvm no build? > > llvm/llvm/lib/Target/PIC16/PIC16AsmPrinter.cpp: In member function > ‘bool llvm::PIC16AsmPrinter::printMachineInstruction(const > llvm::MachineInstr*)’: > llvm/lib/Target/PIC16/PIC16AsmPrinter.cpp:80: error: ‘CurBank’ was not > declared in this scope > llvm/lib/Target/PIC16/PIC16AsmPrinter.cpp: In member function ‘virtual >

> > How about a default GetInstSize() as well? Return 1 for every > instruction except for some special TargetInstrInfo instructions, e.g. > PHI, IMPLICIT_DEF, LABEL. I don't know if it's useful or not. But > perhaps we can default most targets to it? > > I prefer not giving a default implementation and aborting with a message that says the target did not

OK, here's a new patch that adds the infrastructure and the implementation for X86, ARM and PPC of GetInstSize and GetFunctionSize. Both functions are virtual functions defined in TargetInstrInfo.h. For X86, I moved some commodity functions from X86CodeEmitter to X86InstrInfo. What do you think? Nicolas Evan Cheng wrote: > > I think both of these belong to TargetInstrInfo. And