similar to: [LLVMdev] X86AsmPrinter + MASM and NASM backends

Builds fine on Linux, but there seems to be a problem building it on Cygwin, will look into this. Aaron ----- Original Message ----- From: Aaron Gray To: LLVM Developers Mailing List Sent: Thursday, June 30, 2005 7:12 PM Subject: [LLVMdev] X86AsmPrinter + MASM and NASM backends I have "refactored" the X86AsmPrinter into a number of files ready for the MASM and NASM

Some wheird problem, Target/X86 builds okay now. But there seems to be another problem with the Cygwin build :- make[4]: Entering directory `/usr/build/llvm/lib/Target/SparcV9/ModuloScheduling' llvm[4]: Compiling ModuloSchedulingSuperBlock.cpp for Debug build /usr/src/llvm/lib/Target/SparcV9/ModuloScheduling/ModuloSchedulingSuperBlock.cpp : In member function `virtual bool

On Thu, 30 Jun 2005, Aaron Gray wrote: > I have "refactored" the X86AsmPrinter into a number of files ready for > the MASM and NASM backends to be added. Nice! > There is a new namespace llvm::X86 to replace the anomonous namespace as > this does not work accross mutiple .h and .cpp files. Other than that > everything is pritty straight forward, t may possibly need

I am now getting the following link errors on all executables: x86.lib(X86AsmPrinter.obj) : error LNK2001: unresolved external symbol "public: virtual bool __thiscall llvm::x86::X86ATTAsmPrinter::runOnMachineFunction(class llvm::MachineFunction &)" (?runOnMachineFunction at X86ATTAsmPrinter@x86 at llvm@@UAE_NAAVMachineFunction at 3@@Z) x86.lib(X86AsmPrinter.obj) : error LNK2001:

> On Mon, 2005-07-11 at 19:24 +0100, Aaron Gray wrote: >> The NASM like the MASM does not have % symbols on the register names so >> will >> either inherit from the MASM printer or have its own TableGen class. > > Couldn't one conditionally output some macros for the assembler to > translate the reg names rather than having another .td file? or is '%'

On Mon, 2005-07-11 at 19:24 +0100, Aaron Gray wrote: > The NASM like the MASM does not have % symbols on the register names so will > either inherit from the MASM printer or have its own TableGen class. Couldn't one conditionally output some macros for the assembler to translate the reg names rather than having another .td file? or is '%' not a valid part of a macro on NASM?

>> I am not really sure whether to do a X86NASMPrinter or whether to bypass >> that for now and work on an X86COFFWriter which would be more useful to >> me ? > > I wouldn't suggest writing an X86NASMPrinter: just change the current > Intel printer to do what you want. Noone is currently using the intel > printer, so you can do what you wish to it. Once I

On Sat, 2 Jul 2005, Aaron Gray wrote: >>> The only thing I did not like was a clsh between the enum X86 and the new >>> namespace X86, which I had to rename as x86 :( >>> >>> Anyway, I suppose the lower case 'x' in 'x86' fits in with the lowercase >>> 'llvm' namespace. >> >> I'm not sure I follow. X86 is a

Chris, Okay, I have done as you have requested. The only thing I did not like was a clsh between the enum X86 and the new namespace X86, which I had to rename as x86 :( Anyway, I suppose the lower case 'x' in 'x86' fits in with the lowercase 'llvm' namespace. Build tested on MS VC2003 and Linux. Aaron -------------- next part -------------- A non-text attachment was

>> The GAS intel code generator generates percents, look at the >> X86InstrInfo.td file it is full of them. > > Ah, I see what you're talking about. Please feel free to remove all of > those from the Intel format. For example, change this: > > def IN8rr : I<0xEC, RawFrm, (ops), > "in{b} {%dx, %al|%AL, %DX}">, Imp<[DX],

>>> You shouldn't have to add new classes to the .td file, just modify >>> printOp for your asmprinters. >> >> I dont think printOp is virtual and therefore cannot be overriden ? > > Why does it need to be virtual? No 'intel' printers want % signs. The GAS intel code generator generates percents, look at the X86InstrInfo.td file it is full of

On Tue, 12 Jul 2005, Aaron Gray wrote: >>> X86InstrInfo.td file it is full of them. >> >> Ah, I see what you're talking about. Please feel free to remove all of >> those from the Intel format. For example, change this: >> >> def IN8rr : I<0xEC, RawFrm, (ops), >> "in{b} {%dx, %al|%AL, %DX}">, Imp<[DX],

> Patch committed here: Just looked at the WebCVS. > I made a couple of changes to the code you submitted. The most important > is that I converted this (in the .h files): > > using namespace llvm; > namespace x86 { > ... > > into: > > namespace llvm { > namespace x86 { > ... Right, that is how I had it in the beggining, obviously I miss understood your

On Tue, 12 Jul 2005, Aaron Gray wrote: >>>> You shouldn't have to add new classes to the .td file, just modify >>>> printOp for your asmprinters. >>> I dont think printOp is virtual and therefore cannot be overriden ? >> Why does it need to be virtual? No 'intel' printers want % signs. > > The GAS intel code generator generates percents,

On Mon, 11 Jul 2005, Aaron Gray wrote: >> On Mon, 2005-07-11 at 19:24 +0100, Aaron Gray wrote: >>> The NASM like the MASM does not have % symbols on the register names so >>> will >>> either inherit from the MASM printer or have its own TableGen class. >> >> Couldn't one conditionally output some macros for the assembler to >> translate the

Fixed it. You did not add the new files to Visual Studio (or at least forgot to include x86.vcproj with the other files). Jeff Cohen wrote: > I am now getting the following link errors on all executables: > > x86.lib(X86AsmPrinter.obj) : error LNK2001: unresolved external symbol > "public: virtual bool __thiscall > llvm::x86::X86ATTAsmPrinter::runOnMachineFunction(class

> Fixed it. You did not add the new files to Visual Studio (or at least > forgot to include x86.vcproj with the other files). Sorry Jeff thats my fault. Aaron

> You shouldn't have to add new classes to the .td file, just modify printOp > for your asmprinters. I dont think printOp is virtual and therefore cannot be overriden ? Aaron

On Tue, 12 Jul 2005, Aaron Gray wrote: >> You shouldn't have to add new classes to the .td file, just modify printOp >> for your asmprinters. > > I dont think printOp is virtual and therefore cannot be overriden ? Why does it need to be virtual? No 'intel' printers want % signs. -Chris -- http://nondot.org/sabre/ http://llvm.org/

On Fri, 1 Jul 2005, Aaron Gray wrote: > Okay, I have done as you have requested. Patch committed here: I made a couple of changes to the code you submitted. The most important is that I converted this (in the .h files): using namespace llvm; namespace x86 { ... into: namespace llvm { namespace x86 { ... The former defines the "..." stuff in the x86 namespace, the later defines