similar to: CMake support for Opus in addition to Autotools

Right that I had completely missed, I have added the files and verified that it builds with CMake from the tar on Linux (out of the git repo) I am parsing the package_version file from the tarball if it exists so it should maintain the version info. //Marcus ________________________________ From: Jean-Marc Valin <jmvalin at jmvalin.ca> Sent: Tuesday, April 2, 2019 11:38 To: Marcus

Hi, It looks like cmake currently defaults to no optimization, which I think is a bit unexpected for most users. I don't know how to do that in cmake, but it would be good to default to a "release" build with optimizations. Can you have a patch to do that? Also, is there a way to manually add flags to the compiler (like setting CFLAGS with autotools)? Cheers, Jean-Marc On

Thanks, it applies now. I think you'd also want to add some (all?) of these files to EXTRA_DIST in Makefile.am, otherwise your cmake files won't be included in release tarballs, which are generate using "make dist". To test, you should try running run "make dist" to generate a tarball yourself. From there, you try building the contents with your cmake files and see if

Hi, Thanks for the quick feedback I have changed the name to avoid conflict. Attached is the updated patch. //Marcus ________________________________ From: Jean-Marc Valin <jmvalin at jmvalin.ca> Sent: Tuesday, April 2, 2019 00:07 To: Marcus Asteborg; opus at xiph.org Subject: Re: [opus] CMake support for Opus proposal (in addition to Autotools) Hi Marcus, There seems to be a conflict

Hi Marcus, There seems to be a conflict between the autotools-created config.h.in and the same file added by your patch. Any way you can use use a different name? Cheers, Jean-Marc On 04/02/2019 01:39 AM, Marcus Asteborg wrote: > Hi, > > > Here is a proposal for adding CMake in addition of Autotools. > > > See the attached patch for changes or the pull request here:

Did the patch 5 split / AVX fix work get merged at all, I didn't see any more mails about it? Thanks! On Tue, 14 Jan 2020 at 21:34, Marcus Asteborg <xnorpx at outlook.com> wrote: > Awesome thanks! Good comments. > > Please apply patch 1-4 and I prepare another iteration on patch 5 for you > too look at. > > //Marcus > ------------------------------ > *From:*

Hi Christian Adam, Thanks for pointing this out, I made the necessary changes to account for this. So the behavior is as follows: * If no CMAKE_BUILD_TYPE is set and no CFLAGS are set it will default to Release. i.e ( cmake .. ) * If a developer want full control then use export CFLAGS in leave CMAKE_BUILD_TYPE empty. * If a developer want to test CFLAGS in combination with

Hi Simon, Please create a pull request here: https://github.com/xnorpx/opus/pulls Also please add a buildconfig here that exercise the BUILD_FRAMEWORK option: https://github.com/xnorpx/opus/blob/master/.github/workflows/build.yml [https://avatars2.githubusercontent.com/u/302709?s=400&v=4]<https://github.com/xnorpx/opus/blob/master/.github/workflows/build.yml>

On Wed, Apr 10, 2019 at 5:30 PM Marcus Asteborg <xnorpx at outlook.com> wrote: > Hi Mark, > > Thanks for the feedback. > > By default CMake is building the static library in debug, to get other > things one has to explicit turn it on. > > Hi, By default CMake uses the "empty" build, which is used in combination with the environment variables CFLAGS and

Verified that intrin0.h was available in 1910, by building it locally on VS2017 version 15.0 MSVC++ 14.1 _MSC_VER == 1910 (Visual Studio 2017 version 15.0) https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B //Marcus ________________________________ From: Marcus Asteborg <xnorpx at outlook.com> Sent: Thursday, June 11, 2020 20:15 To: Ralph Giles <giles at thaumas.net>; opus at

Hi, Here is a proposal for adding CMake in addition of Autotools. See the attached patch for changes or the pull request here: https://github.com/xiph/opus/pull/100 The CMake scripts are parsing the filelist from Autotools, so only one file list needs to be maintained. With this change the checked in Visual Studio solution can be removed and no longer need to be maintained and updated when

>>> Marcus Asteborg <xnorpx at outlook.com> schrieb am 24.06.2020 um 19:59 in Nachricht <8175_1593021574_5EF39486_8175_1287_1_DB3PR0602MB378816E9B5FC531496C4CE9FDF950 at D 3PR0602MB3788.eurprd06.prod.outlook.com>: > > ________________________________ > From: Mark Harris <mark.hsj at gmail.com> > Sent: Wednesday, June 24, 2020 00:09 > To: Marcus Asteborg

3, no good catch attached is an updated patch //Marcus ________________________________ From: Jean-Marc Valin <jmvalin at jmvalin.ca> Sent: Thursday, June 11, 2020 10:49 To: Marcus Asteborg <xnorpx at outlook.com>; opus at xiph.org <opus at xiph.org> Subject: Re: [opus] Misc patches On 2020-06-08 01:39, Marcus Asteborg wrote: > 1. Build test for cmake and run the test in

Sorry about that, let me check the correct version for the intrin0.h include guard. //Marcus ________________________________ From: Ralph Giles <giles at thaumas.net> Sent: Thursday, June 11, 2020 19:31 To: Marcus Asteborg <xnorpx at outlook.com>; opus at xiph.org <opus at xiph.org> Subject: Re: [opus] Misc patches Speaking of needing more complete ci feedback, the intrin0.h

________________________________ From: Mark Harris <mark.hsj at gmail.com> Sent: Wednesday, June 24, 2020 00:09 To: Marcus Asteborg <xnorpx at outlook.com> Cc: opus at xiph.org <opus at xiph.org> Subject: Re: Add CMake build instructions to README > Hi Marcus, > Currently the build instructions start with simple instructions for > building from the release tarball, and

Hi Marcus, When building shared libraries for macOS / iOS /tvOS, by default `.dylib` shared libraries will be generated. With this patch `BUILD_FRAMEWORK` is exposed as an option allowing the user to specify that a `.framework` bundle should be built instead of a standalone `.dylib` file. Enabling the option sets the necessary target properties to instruct CMake to do this. The Ogg CMake build

On Sat, Jun 13, 2020 at 2:59 PM Marcus Asteborg <xnorpx at outlook.com> wrote: > > Hi, > > Here is a patch to add build instructions for CMake to the README. > > I tried to follow the previous automake style instructions as closely as possible but added instructions for Windows. > Noted that it is still experimental > > //Marcus Hi Marcus, Currently the build

I tried the new cmake-based build system to build Opus on Linux and macOS. I'm not familiar with cmake but based on instructions I found online I used it as follows: - mkdir build - cd build - cmake -DCMAKE_INSTALL_PREFIX:PATH=<install-path> .. - make - ctest - make install Although the "make" command completed, it reported that optimizations were disabled:

Hi Mark, Thanks for the feedback. By default CMake is building the static library in debug, to get other things one has to explicit turn it on. To build in release mode for CMake you use the following flag: -DCMAKE_BUILD_TYPE=Release https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html CMAKE_BUILD_TYPE — CMake 3.14.1

Hi all, With some downtime it's time for some CMake fixes. Most critically is the SSE fixes to avoid crashes that is described in 154 and 132 in github. Patch 5 should address this and also adding APPROX-FLOAT option. Hopefully this can give some gains for those of us running on Windows servers.j I went through the pull request and picked out a few that will ease up integration for