similar to: [PATCH] fuse: Alternatives for Linux-specific commands

* Workaround for linux-specific fuser -v * Workaround for linux-specific fusermount --- fuse/guestunmount.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/fuse/guestunmount.c b/fuse/guestunmount.c index 3df481b..2190ba0 100644 --- a/fuse/guestunmount.c +++ b/fuse/guestunmount.c @@ -257,7 +257,12 @@ do_fusermount (const char *mountpoint, char **error_rtn) /* We have to

On Thu, Feb 05, 2015 at 10:53:06PM +0000, Margaret Lewicka wrote: > Hello, > > I'm attempting to create a Homebrew formula to get libguestfs to > compile on Mac OS X. I've managed to achieve success with several > monkey patches, but since Homebrew's policy is to contact maintainers > about proper fixes in upstream, I would like to ask if there are any > plans to

On Friday 06 February 2015 10:03:37 Richard W.M. Jones wrote: > On Thu, Feb 05, 2015 at 10:53:06PM +0000, Margaret Lewicka wrote: > > Hello, > > > > I'm attempting to create a Homebrew formula to get libguestfs to > > compile on Mac OS X. I've managed to achieve success with several > > monkey patches, but since Homebrew's policy is to contact

Supplied by Pene on IRC who got libguestfs to compile and run on Mac OS X 10.9 with qemu 1.6.0. My notes in [] below. Rich. libguestfs on Mac OS X, recipe so far: -------------------------------------- - libtool-kill-dependency_libs.sh: replace chmod --reference="$output.tmp" "$output" -> chmod `stat -f "%p" "$output.tmp"` "$output" -

More complete documentation below. Rich. ---------------------------------------------------------------------- libguestfs on Mac OS X (tested with libguestfs-1.23.33): -------------------------------------------------------- prerequisites: -------------- - install osxfuse, download from: http://osxfuse.github.io - install some dependencies using macports: sudo port install qemu cdrtools pcre

Hello, I'm attempting to create a Homebrew formula to get libguestfs to compile on Mac OS X. I've managed to achieve success with several monkey patches, but since Homebrew's policy is to contact maintainers about proper fixes in upstream, I would like to ask if there are any plans to fix these issues. I'm afraid I don't know C well enough to propose decent solutions myself.

>From Apple's xdr.h: "If your code invokes an xdrproc_t callback, it must be modified to pass a third parameter, which may simply be zero." --- src/proto.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/proto.c b/src/proto.c index 92ae84d..57f4882 100644 --- a/src/proto.c +++ b/src/proto.c @@ -252,7 +252,12 @@ guestfs___send (guestfs_h *g, int proc_nr, *

Since the first patch: - The program is now called 'guestunmount'. - I tested the --fd option and it appears to work. - You can now control retries / quiet. - Revised man pages. - Includes tests. I'm just running through the automated tests now. Rich.

* PATCH FOR DISCUSSION ONLY - NOT TO BE APPLIED * Colin suggested something which seems eminently sensible: https://bugzilla.redhat.com/show_bug.cgi?id=916780 I've been through a couple of rounds of trying to implement this. I started with adding the option as suggested to the guestmount program, but it tended to make the guestmount program more complex. More importantly, adding the option

Exit with 3 as return value when fusermount fails, because the specified mount point is not considered mounted for the user. This is in line with what the guestunmount documentation says. Adapt the test-guestunmount-fd test to the updated return value. Thanks to: Maxim Perevedentsev. --- fuse/guestunmount.c | 2 +- fuse/test-guestunmount-fd.c | 8 ++++---- 2 files changed, 5

On 11/23/2015 07:59 PM, Pino Toscano wrote: > Hi, > > On Monday 23 November 2015 18:29:50 Maxim Perevedentsev wrote: >> 1) guestunmount never returns 3 (not mounted) - i guess it's a bug at >> guestunmount.c:223 > Indeed, thanks for the notice -- just send a patch for it. > >> 2) I don't know whether it's a bug in guestunmount or fusermount, but on

On Tuesday 24 November 2015 12:57:17 Maxim Perevedentsev wrote: > On 11/23/2015 07:59 PM, Pino Toscano wrote: > > Hi, > > > > On Monday 23 November 2015 18:29:50 Maxim Perevedentsev wrote: > >> 1) guestunmount never returns 3 (not mounted) - i guess it's a bug at > >> guestunmount.c:223 > > Indeed, thanks for the notice -- just send a patch for it.

Hello everyone! I'm playing with guestunmount and got the following issues: 1) guestunmount never returns 3 (not mounted) - i guess it's a bug at guestunmount.c:223 2) I don't know whether it's a bug in guestunmount or fusermount, but on my machine while executing > guestmount > guestunmount > guestunmount on second "guestunmount" I get

Hi, On Monday 23 November 2015 18:29:50 Maxim Perevedentsev wrote: > 1) guestunmount never returns 3 (not mounted) - i guess it's a bug at > guestunmount.c:223 Indeed, thanks for the notice -- just send a patch for it. > 2) I don't know whether it's a bug in guestunmount or fusermount, but on > my machine while executing > > guestmount > > guestunmount

On 9 February 2015 at 09:56, Pino Toscano <ptoscano@redhat.com> wrote: > On Friday 06 February 2015 10:03:37 Richard W.M. Jones wrote: [...] >> #if !(defined __APPLE__ && defined __MACH__) >> execlp ("fusermount", "fusermount", "-u", mountpoint, NULL); >> #else >> execlp ("/sbin/umount",

Tests are run via the ./run binary, so all the binaries in the build directory are available via $PATH already. Followup of commit e85a976c5a474d751c6e8352370047a3177a7c45. --- cat/Makefile.am | 2 +- df/Makefile.am | 2 +- fuse/test-fuse-umount-race.sh | 4 ++-- fuse/test-guestmount-fd.c | 4 ++-- fuse/test-guestunmount-fd.c

Wherever we had code which did: if (something_bad) { perror (...); exit (EXIT_FAILURE); } replace this with use of the error(3) function: if (something_bad) error (EXIT_FAILURE, errno, ...); The error(3) function is supplied by glibc, or by gnulib on platforms which don't have it, and is much more flexible than perror(3). Since we already use error(3), there seems to be

Assorted collection of small improvements in making libguestfs build on non-Linux OSes; most of the changes impact tests though. Thanks, Pino Toscano (7): build: check the path of fuser, and use it in FUSE code tests: move guestfs-md5.sh to test-data v2v: tests: isolate SHA1 calculation in an own shared function v2v: tests: use guestfs-hashsums.sh for MD5 php: pass $(MAKE) to

2014-07-15 20:59 GMT+04:00 Richard W.M. Jones <rjones@redhat.com>: > Not sure I understand the question, but the guestfish mount-local-run > command will block guestfish until another process runs > 'fusermount -u /mntpoint' (or better, 'guestunmount /mntpoint'). I understand that guestfish process will be locked. But in case of go that uses lightweight goroutines,

I don't believe this has any use or meaning. Currently the tools don't process -?, eg: $ guestfish -\? Try `guestfish --help' for more information. Therefore I believe this is erroneous. --- fish/fish.c | 2 +- fuse/guestmount.c | 2 +- fuse/guestunmount.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fish/fish.c b/fish/fish.c index