similar to: RFC: Handle query strings for http and https (RHBZ#1092583)

So far, passwords in URLs (eg http://user:password@host..) have been handled as part of the username, and thus passing add-drive path username:username:password ... instead of add-drive path username:username secret:password ... Fix the parsing of URLs to handle passwords as separate elements, properly passing it as "secret" parameter for add-drive, and properly readd it when

Hi All, Here's the latest patch. I think this should address the problem. The query string is now only appended to the end of a URI in the HTTP and HTTPS cases. The add-uri test now passes, and 'make check' still passes. -- Gabriel

I have written a patch (please see attached) which fixes both of these bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1092583 https://bugzilla.redhat.com/show_bug.cgi?id=1232477 By default, when saving a URI using xmlSaveUri it escapes everything in the URI. QEMU doesn't want anything escaped, so now I unescape everything after the URI is generated. Unfortunately there's no flag to

Miscellaneous fixes to: - Handling of Ceph drives now works end-to-end (RHBZ#1026688). - In particular, you can now use rbd:/// URIs in guestfish (and they work). - Parse Ceph & NBD network drives from libvirt XML correctly, so that existing domains with Ceph/NBD drives can be added (eg. using guestfish -d option). - Add more testing of the above.

Hi, In data giovedì 25 giugno 2015 18:44:50, Gabriel Hartmann ha scritto: > I have written a patch (please see attached) which fixes both of these bugs: > > https://bugzilla.redhat.com/show_bug.cgi?id=1092583 > https://bugzilla.redhat.com/show_bug.cgi?id=1232477 > > By default, when saving a URI using xmlSaveUri it escapes everything in the > URI. QEMU doesn't want

v1 -> v2: - Rebase on top of Pino's version work. Two patches went upstream, these are the two remaining patches. Note the generation number is still inside the qemu.stat file. We could put it in the filename, I have no particular preference. Rich.

QEMU upstream has broken snapshot=on ... again. These two patches stop using it entirely. Instead we run 'qemu-img create' to create overlay disks as required. Note that the libvirt and UML backends were already doing this: The libvirt backend because <transient/> has never worked, and the UML backend was running uml_mkcow because the UML-equivalent syntax of snapshot=on was

Note this patch requires a non-upstream qemu patch that I've been experimenting with. See qemu-devel list. Rich.

This series improves ceph rbd support in libguestfs. It uses the servers list, adds support for a custom username, and starts to add support for custom secret.

Doing qemu feature detection in the direct backend takes ~100ms because we need to run `qemu -help' and `qemu -devices ?', and each of those interacts with glibc's very slow link loader. Fixing the link loader is really hard. Instead memoize the output of those two commands. This patch series first separates all the code dealing with qemu into a separate module (src/qemu.c) and

> > > By default, when saving a URI using xmlSaveUri it escapes everything in > the URI. QEMU doesn't want anything escaped, so now I unescape > everything after the URI is generated. Unfortunately there's no flag to > change the default behavior. > > I'm not sure that's the actual issue here, but I'm somehow included to > think this is another

These patches contain the beginnings of discard (a.k.a. trim or unmap) support. This will allow us to change virt-sparsify to work on disk images in-place (instead of using slow & inefficient copying). The approach used is to add an optional 'discard' parameter to add-drive. It has 3 possible settings: - 'disable' : the default, no discard is done - 'besteffort' :

Move the creation of iscsi URIs away from make_uri, composing them manually: this is needed because libxml assumes colons (':') to separate user and password for the authority part, while with iscsi URIs the separator is percentage ('%'), which would be percent-encoded by libxml. --- src/launch-direct.c | 31 ++++++++++++++++++++++++++++--- 1 file changed, 28 insertions(+), 3

This still isn't working at the moment. See: http://marc.info/?t=139457409300003&r=1&w=2 This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. Rich.

From: Nikolay Ivanets <stenavin@gmail.com> I faced with situation where libguestfs cannot recognize partitions on a disk image which was partitioned on a system with "4K native" sector size support. In order to fix the issue we need to allow users to specify desired physical and/or logical block size per drive basis. It is definitely not a complete patch but rather a way to

GCC 8 thinks that the case drive_protocol_gluster may fall through, most probably because the only code is a switch case that handles the elements of an enum, and thus letting other fall through. In reality this ought to not happen at all, so help GCC by break'ing the case, which will then lead to the abort() at the end of guestfs_int_drive_source_qemu_param. --- lib/qemu.c | 1 + 1 file

On Tuesday 11 March 2014 23:13:46 Richard W.M. Jones wrote: > diff --git a/src/drives.c b/src/drives.c > index 2c85b52..68e37f7 100644 > --- a/src/drives.c > +++ b/src/drives.c > @@ -115,7 +115,8 @@ static struct drive * > create_drive_file (guestfs_h *g, const char *path, > bool readonly, const char *format, > const char *iface,

Hi, I am trying to play with all the methods in the Array Object. Just wanted to check with you guys if this is the correct explanation of toQueryParams(). If yes, then I''ll add it to the documentation as well. Works for me (but I am not sure if it''s the correct way to use it). /* String.prototype.toQueryParams takes a query string, i.e, string with name value pairs

When parsing the URI, drop the leading '/' from the path also when the protocol is 'nbd': in this case, the path represents the export name, which does not need the '/' coming from the URI format. Improve the coverage for nbd in test-add-uri.sh, adding a couple of tests, and adjusting the result of an existing one. --- fish/test-add-uri.sh | 8 +++++++- fish/uri.c

This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. This is now working, after fixing the rather stupid bug in fstrim. I've pushed the ones which were ACKed previously + the fstrim fix. Rich.