similar to: [PATCH] daemon: readdir: fix invalid memory access on error

On Tue, Jan 20, 2015 at 04:28:39PM +0100, Pino Toscano wrote: > If "strdup (d->d_name)" fails with "i" > 0, then both "p" and > "ret->guestfs_int_dirent_list_val" are non-null pointers, but the latter > is no more valid (since "p" is the new realloc'ed buffer). Hence, trying > to free both will access to invalid memory.

On Tue, Jan 20, 2015 at 04:28:40PM +0100, Pino Toscano wrote: > The code is already within a "if (prompt) {...}" block, so checking for > "prompt" again is redundant. > --- > fish/fish.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fish/fish.c b/fish/fish.c > index 8b74c7b..71db83a 100644 > --- a/fish/fish.c > +++

The code is already within a "if (prompt) {...}" block, so checking for "prompt" again is redundant. --- fish/fish.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fish/fish.c b/fish/fish.c index 8b74c7b..71db83a 100644 --- a/fish/fish.c +++ b/fish/fish.c @@ -661,8 +661,8 @@ rl_gets (int prompt) line_read = NULL; } - p = prompt

Never mind I was missing libreadline-dev I gues this check would be good to be added with an error to the configure script since it creates error in compilation Regards, Peter > On 22 Nov 2015, at 20:06, Keresztes Péter-Zoltán <zozo@z0z0.tk> wrote: > > Hello, > > I have got into a different issue while trying to compile the latest version of libguestfs: > > CC

I''m running the latest mongrel (1.0.1) and the latest mongrel_cluster (1.0.1.1) on FreeBSD 6.1. When I use capistrano to try to stop or restart my cluster I get this (partial) output: ps: Process environment requires procfs(5) And my Mongrel processes haven''t stopped. Any ideas? Thanks, Jamie

Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- fish/fish.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fish/fish.c b/fish/fish.c index 0432774..20511f8 100644 --- a/fish/fish.c +++ b/fish/fish.c @@ -641,10 +641,12 @@ shell_script (void) #define FISH "><fs> " +#ifdef HAVE_LIBREADLINE static char *ps1 = NULL; /* GUESTFISH_PS1 */

Hello all. I''ve recently installed the 0.2.2 pre-release of mongrel_cluster to try out the new --clean option. However, after installing, when I give a simple "mongrel_rails" command, the cluster::status command is not listed. The error I receive when I do try and run the full "mongrel_rails cluster::status" is... ERROR RUNNING

I''m running FreeBSD 6.1 and installed the 1.0.1.1 mongrel_cluster prerelease. I had a problem with the mongrels not stopping, and it turns out it''s because ps is reporting my processes as just [ruby18] instead of someting more like "mongrel_rails start -d ......." Not sure why it''s doing that, but it is. Any ideas? For the time being I just changed line

Patch registers SIGTSTP hook where it sends reset terminal color control sequence. Maros Zatko (1): fish: reset the console on ^Z RHBZ#1213844 fish/fish.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 72 insertions(+) -- 2.5.0

This patch is against OpenSSH 3.7.1p2 sources. It adds recursive (directory) downloading and uploading. Criticism/suggestions welcome. I would imagine the time official support is added, recursive operations will be handled on a per-command basis as a flag as opposed to a global toggle command (such as get -r)? diff -ru openssh-3.7.1p2/sftp-int.c openssh-3.7.1p2-patched/sftp-int.c ---

Patch registers SIGTSTP hook where it sends reset terminal color control sequence using write and fsync. Handler is installed only if signal is not being ignored. Patch uses rl_free_line_state and rl_cleanup_after_signal to unhook readline from terminal, then it calls original TSTP handler using approach in URL below and again hooks readline using rl_reset_after_signal. Handling is based on code

Hello all Im using sftp 1:4.7p1-8ubuntu1.2 in a batchjob Ive noticed that sftp needs a long time for sending a filelist. The timespan increases exponential if many files are on the remoteserver. for example "ls -la *.txt" needs 10 seconds for 2000 files but needs 50 seconds for 4000 files. For 150.000 Files i have to wait 15 minutes for example but the

Hi Rich I using ubuntu 13.10 with powerpc arch. I tried the above stepss and below are the output of the related commands.. nm -D /usr/lib/powerpc-linux-gnu/libtinfo.so | grep tgetent 0000def0 T tgetent ubuntu@t4240-ubuntu1310:~$ dpkg -S /usr/lib/powerpc-linux-gnu/libtinfo.so libtinfo-dev:powerpc: /usr/lib/powerpc-linux-gnu/libtinfo.so However I'm not able to perform rm -f config.cache

These two patches are probably not completely independent, but separating them is a lot of work. With *both* patches applied, all the tests and extra-tests pass. That's no guarantee however that there isn't a mistake, so I don't think this patch is a candidate for the 1.16 branch, until it's had a lot more testing in development. Rich.

In case you configure libguestfs with a custom QEMU, e.g.: $ ./configure [...] QEMU=/path/to/qemu then the libvirt backend did not use to override it, launching the appliance with the default QEMU for libvirt. This does not change the manual emulator overriding using set-hv. Pino Toscano (2): launch: libvirt: get default QEMU from domcapabilities launch: libvirt: fix custom hypervisor

These patches contain the beginnings of discard (a.k.a. trim or unmap) support. This will allow us to change virt-sparsify to work on disk images in-place (instead of using slow & inefficient copying). The approach used is to add an optional 'discard' parameter to add-drive. It has 3 possible settings: - 'disable' : the default, no discard is done - 'besteffort' :

Hello, I just downloaded OpenSSH 3.5p1. This version has some great improvement in sftp client. But I still miss the FTP's "ls [flags] remote-path [localpath]" feature to redirect the output of ls/dir to a local file. The following are the diff outputs against 3.5p1 to enable this feature. *** sftp-int.c.orig Wed Sep 11 20:34:15 2002 --- sftp-int.c Fri Oct 18 13:39:46 2002

This started as a simple warning-elimination change. I'll get back to that series shortly ;-) It turned into a factorization and constification exercise during which I got a taste of ocaml. Thanks to Rich Jones for help with a few snippets in generator.ml. The overall result is that many previously-manually-maintained bits from daemon/*.c functions are now hoisted into the automatically-

On some architectures a certain machine type is used, so use it when querying the libvirt domain capabilities. --- lib/launch-libvirt.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/launch-libvirt.c b/lib/launch-libvirt.c index 864eae314..f2cad9300 100644 --- a/lib/launch-libvirt.c +++ b/lib/launch-libvirt.c @@ -431,7 +431,12 @@ launch_libvirt (guestfs_h *g, void

Patch registers SIGTSTP hook where it sends reset terminal color control sequence. --- fish/fish.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 72 insertions(+) diff --git a/fish/fish.c b/fish/fish.c index d26f8b3..b579898 100644 --- a/fish/fish.c +++ b/fish/fish.c @@ -73,6 +73,11 @@ static void cleanup_readline (void); static char *decode_ps1 (const char