similar to: [PATCH v2] fish: show synopsis if command syntax is wrong

On Mon, Dec 01, 2014 at 06:01:25PM +0000, Richard W.M. Jones wrote: > > How about the following? I've made it use a named value > (RUN_WRONG_ARGS == -2) instead of just the magic number. Yes, it looks better! > > Also I removed an incorrect hunk from the original patch (space before > synopsis string is required). The space before synopsis makes the text of synopsis

This patch lets guestfish show command synopsis if the syntax of command issued by user is wrong, rather than telling user that the number of parameters is wrong. Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- fish/cmds-gperf.h | 1 + generator/fish.ml | 33 ++++++++++++--------------------- 2 files changed, 13 insertions(+), 21 deletions(-) diff --git a/fish/cmds-gperf.h

By splitting up large C files we can make parallel compiles a bit faster. Rich.

In the generated description of the guestfish commands, wrap and indent the help text, so it is a multiline string instead of a very long single one. This has no behaviour changes, only makes cmds.c more readable (and easier to diff when the description of actions change). --- generator/fish.ml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/generator/fish.ml

- when a command needs no parameters, tell that explicitly instead of "command should have 0 parameters" - use gettext's plural form when printing the number of required arguments - improve the error message for a variable number of parameters limited only in the maximum number of them, using also a plural form --- generator/fish.ml | 20 ++++++++++++++++---- 1 file changed,

Hi, here there are few patches to improve the extraction of translatable messages, and the usage of messages with plural forms. Pino Toscano (3): po: fix broken message extraction po: fix dependencies for libguestfs.pot extraction fish: improve the command error messages generator/fish.ml | 20 ++++++++++++++++---- po/Makefile.am | 24 +++++++----------------- 2 files changed, 23

How about the following? I've made it use a named value (RUN_WRONG_ARGS == -2) instead of just the magic number. Also I removed an incorrect hunk from the original patch (space before synopsis string is required). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is

On Friday 28 November 2014 17:55:51 Hu Tao wrote: > This patch lets guestfish show command synopsis if the syntax of command issued > by user is wrong, rather than telling user that the number of parameters is wrong. The idea seems sound to me. Shouldn't that be done also for fish commands? If so, just make "synopsis" a function taking args and optargs, and use it in both

On Mon, Dec 01, 2014 at 10:25:51AM +0800, Hu Tao wrote: > On Fri, Nov 28, 2014 at 03:00:39PM +0100, Pino Toscano wrote: > > On Friday 28 November 2014 17:55:51 Hu Tao wrote: > > > This patch lets guestfish show command synopsis if the syntax of command issued > > > by user is wrong, rather than telling user that the number of parameters is wrong. > > > > The

The output of TableGen (intrinsics.gen) seems a bit too clunky specifically the switching parts (input the string, output the enum). Moreover, the code makes MSVC barf due to its nesting limit which even applices to if-else statements. One one hand, gperf (http://www.gnu.org/software/gperf/manual/gperf.html) offers a way to map strings to records without much difficulty (and it does its job

Per my previous email: https://www.redhat.com/archives/libguestfs/2017-September/msg00203.html I'd like to talk about requiring a more modern version of the OCaml compiler. These commits show some of the code changes which would be possible with OCaml >= 3.12 [which it turns out we already require by accident] and also with OCaml >= 4.02. The latter is my favoured option. Rich.

On Mon, Dec 01, 2014 at 02:42:54PM +0800, Hu Tao wrote: > On Mon, Dec 01, 2014 at 10:25:51AM +0800, Hu Tao wrote: > > On Fri, Nov 28, 2014 at 03:00:39PM +0100, Pino Toscano wrote: > > > On Friday 28 November 2014 17:55:51 Hu Tao wrote: > > > > This patch lets guestfish show command synopsis if the syntax of command issued > > > > by user is wrong, rather

FYI, gperf is a very good perfect hash utility written originally by Doug Schmidt (of ACE fame). I used it in XPS for speeding up XML parsing by hashing all the element and attribute names. Unfortunately, its a code generator, which we're trying to get rid of in LLVM. Still, I recommend the tool highly. Reid. On Tue, 1 Jan 2008 13:04:57 -0800 Chris Lattner <sabre at nondot.org>

On Fri, Nov 28, 2014 at 03:00:39PM +0100, Pino Toscano wrote: > On Friday 28 November 2014 17:55:51 Hu Tao wrote: > > This patch lets guestfish show command synopsis if the syntax of command issued > > by user is wrong, rather than telling user that the number of parameters is wrong. > > The idea seems sound to me. > > Shouldn't that be done also for fish commands?

On Jan 1, 2008, at 1:51 AM, Wilhansen Li wrote: > The output of TableGen (intrinsics.gen) seems a bit too clunky > specifically the switching parts (input the string, output the enum). > Moreover, the code makes MSVC barf due to its nesting limit which even > applices to if-else statements. Right, fixing the VC++ issue is straight-forward. I will do it in the next couple of days

This patch is just for review. It enables FUSE support in the API via two new calls, 'guestfs_mount_local' and 'guestfs_umount_local'. FUSE turns out to be very easy to deadlock (necessitating that the machine be rebooted). Running the test from the third patch is usually an effective way to demonstrate this. However I have not yet managed to produce a simple reproducer that

It's not possible to define an action which takes a parameter called 'message' because the Erlang bindings use that as the name of an internal variable. Solve this by renaming the Erlang internal variable. Fixes commit 84763d7fca3668c62ee3fe53d0e00a5a672f687b. --- generator/erlang.ml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

Hi folks, I have been stumped on a compilation problem when I tried to build 176.gcc of SPEC CPU2000 with clang v 2.8 (trunk 427) on Linux and intel. First, I tried to compile with 'clang -std=c89 *.c -o gcc.clang' since the default C standard of Clang is c99 while that of gcc is c89. It reported this error: ./c-gperf.h:14:1: error: unknown type name 'inline' inline ^

Prune from the list of sources where to extract messages various sources with no messages: - .pl and .pm files, as they do not contain messages: almost all the .pl files are tests, and the only .pm file is the Perl Sys::Guestfs module, which wraps the XS extension - dummy.c sources; they are empty sources used to build OCaml-only targets using automake - gperf generated sources - C/OCaml

When running (eg) dnf on a 32 bit i686 guest when the host is 64 bit x86_64, dnf believes it is running on a 64 bit machine and so tries to install x86_64 packages. We can 'trick' dnf into believing it's a 32 bit machine using the setarch program. $ virt-builder fedora-22 --arch i686 --install 'gperf' ... [ 27.4] Installing packages: gperf ... Running transaction test Error: