similar to: [PATCH] fish: show synopsis if command syntax is wrong

This patch lets guestfish show command synopsis if the syntax of command issued by user is wrong, rather than telling user that the number of parameters is wrong. Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- changes in v2: - fix the error of ' error: control reaches end of non-void function [-Werror=return-type]' - change the return value from -2 to -1 fish/cmds-gperf.h |

On Mon, Dec 01, 2014 at 06:01:25PM +0000, Richard W.M. Jones wrote: > > How about the following? I've made it use a named value > (RUN_WRONG_ARGS == -2) instead of just the magic number. Yes, it looks better! > > Also I removed an incorrect hunk from the original patch (space before > synopsis string is required). The space before synopsis makes the text of synopsis

On Friday 28 November 2014 17:55:51 Hu Tao wrote: > This patch lets guestfish show command synopsis if the syntax of command issued > by user is wrong, rather than telling user that the number of parameters is wrong. The idea seems sound to me. Shouldn't that be done also for fish commands? If so, just make "synopsis" a function taking args and optargs, and use it in both

- when a command needs no parameters, tell that explicitly instead of "command should have 0 parameters" - use gettext's plural form when printing the number of required arguments - improve the error message for a variable number of parameters limited only in the maximum number of them, using also a plural form --- generator/fish.ml | 20 ++++++++++++++++---- 1 file changed,

On Fri, Nov 28, 2014 at 03:00:39PM +0100, Pino Toscano wrote: > On Friday 28 November 2014 17:55:51 Hu Tao wrote: > > This patch lets guestfish show command synopsis if the syntax of command issued > > by user is wrong, rather than telling user that the number of parameters is wrong. > > The idea seems sound to me. > > Shouldn't that be done also for fish commands?

By splitting up large C files we can make parallel compiles a bit faster. Rich.

In the generated description of the guestfish commands, wrap and indent the help text, so it is a multiline string instead of a very long single one. This has no behaviour changes, only makes cmds.c more readable (and easier to diff when the description of actions change). --- generator/fish.ml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/generator/fish.ml

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://et.redhat.com/~rjones/libguestfs/ See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html -------------- next part -------------- >From ea5c6cf0341fdd8072b12723f9794506841bc688 Mon Sep 17

Hi, here there are few patches to improve the extraction of translatable messages, and the usage of messages with plural forms. Pino Toscano (3): po: fix broken message extraction po: fix dependencies for libguestfs.pot extraction fish: improve the command error messages generator/fish.ml | 20 ++++++++++++++++---- po/Makefile.am | 24 +++++++----------------- 2 files changed, 23

Prune from the list of sources where to extract messages various sources with no messages: - .pl and .pm files, as they do not contain messages: almost all the .pl files are tests, and the only .pm file is the Perl Sys::Guestfs module, which wraps the XS extension - dummy.c sources; they are empty sources used to build OCaml-only targets using automake - gperf generated sources - C/OCaml

On Mon, Dec 01, 2014 at 10:25:51AM +0800, Hu Tao wrote: > On Fri, Nov 28, 2014 at 03:00:39PM +0100, Pino Toscano wrote: > > On Friday 28 November 2014 17:55:51 Hu Tao wrote: > > > This patch lets guestfish show command synopsis if the syntax of command issued > > > by user is wrong, rather than telling user that the number of parameters is wrong. > > > > The

How about the following? I've made it use a named value (RUN_WRONG_ARGS == -2) instead of just the magic number. Also I removed an incorrect hunk from the original patch (space before synopsis string is required). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is

On Mon, Dec 01, 2014 at 02:42:54PM +0800, Hu Tao wrote: > On Mon, Dec 01, 2014 at 10:25:51AM +0800, Hu Tao wrote: > > On Fri, Nov 28, 2014 at 03:00:39PM +0100, Pino Toscano wrote: > > > On Friday 28 November 2014 17:55:51 Hu Tao wrote: > > > > This patch lets guestfish show command synopsis if the syntax of command issued > > > > by user is wrong, rather

This commit, which is just code motion, moves the common XDR protocol code (libprotocol) and the common errno handling (liberrnostring) into libraries which are each built once and shared between the library and daemon. --- .gitignore | 20 +++++-------- Makefile.am | 1 + common/errnostring/Makefile.am | 45 +++++++++++++++++++++++++++++

Hello, > One one hand, gperf > (http://www.gnu.org/software/gperf/manual/gperf.html) offers a way to > map strings to records without much difficulty (and it does its job > efficiently). > > My point is, are there plans to utilize gperf for table generation? I'm aware about gperf. However we're planning to utilize some another approach based on tries. The idea behind

FYI, gperf is a very good perfect hash utility written originally by Doug Schmidt (of ACE fame). I used it in XPS for speeding up XML parsing by hashing all the element and attribute names. Unfortunately, its a code generator, which we're trying to get rid of in LLVM. Still, I recommend the tool highly. Reid. On Tue, 1 Jan 2008 13:04:57 -0800 Chris Lattner <sabre at nondot.org>

On Fri, Oct 25, 2013 at 01:14:04PM -0700, Scott Baker wrote: > On 10/25/2013 12:56 PM, Richard W.M. Jones wrote: > > F20 - it's in the beta now (as of yesterday). > > > > Rich. > > Wow this has a lot of dependencies :) Two questions... Let's put this on the mailing list so others can help. > Do I need OCaml installed? > Where does guestfs_protocol.x come

On Jan 1, 2008, at 1:51 AM, Wilhansen Li wrote: > The output of TableGen (intrinsics.gen) seems a bit too clunky > specifically the switching parts (input the string, output the enum). > Moreover, the code makes MSVC barf due to its nesting limit which even > applices to if-else statements. Right, fixing the VC++ issue is straight-forward. I will do it in the next couple of days

Hi, I'm having some problems compiling on Mac OS X: nekomimi:xapian samuel$ sudo port install libiconv ---> Configuring gperf ---> Building gperf ---> Staging gperf into destroot ---> Installing gperf @3.0.4_0+universal ---> Deactivating gperf @3.0.4_0 ---> Cleaning gperf ---> Activating gperf @3.0.4_0+universal ---> Cleaning gperf ---> Computing

The output of TableGen (intrinsics.gen) seems a bit too clunky specifically the switching parts (input the string, output the enum). Moreover, the code makes MSVC barf due to its nesting limit which even applices to if-else statements. One one hand, gperf (http://www.gnu.org/software/gperf/manual/gperf.html) offers a way to map strings to records without much difficulty (and it does its job