Displaying 20 results from an estimated 900 matches similar to: "[PATCH 1/1] inspect: Fix a bug in the *BSD root detection"
2014 Nov 28
2
Re: [PATCH 1/1] inspect: Fix a bug in the *BSD root detection
On Friday 28 November 2014 14:31:01 Richard W.M. Jones wrote:
> How about the attached patch? It's basically the same as your patch
> but I moved the code between files and tidied up some whitespace
> issues.
Present in both the patches:
> +/* On *BSD systems, sometimes /dev/sda[1234] is a shadow of the real root
> + * filesystem that is probably /dev/sda5
> + * (see:
2014 Nov 28
0
Re: [PATCH 1/1] inspect: Fix a bug in the *BSD root detection
On Fri, Nov 28, 2014 at 03:42:58PM +0100, Pino Toscano wrote:
> On Friday 28 November 2014 14:31:01 Richard W.M. Jones wrote:
> > How about the attached patch? It's basically the same as your patch
> > but I moved the code between files and tidied up some whitespace
> > issues.
>
> Present in both the patches:
>
> > +/* On *BSD systems, sometimes
2014 Nov 28
1
Re: [synnefo-devel] Re: [PATCH 1/1] inspect: Fix a bug in the *BSD root detection
LGTM
Another thing concerning the disklabel partitions is that
list_filesystems() will print both /dev/sda1 and /dev/sda5 as ufs file
systems. I don't know if you care to change this. The fact is that both
are mountable.
P.S. I wish the kernel folks would stop treating the disklabel
partitions as logical partitions. Logical partitions are sequential,
there are no gaps in the numbering. On
2016 Dec 06
9
[PATCH 0/5] Improve inspection of /usr filesystems
Hi,
this patch series improves the way /usr filesystems are handled: tag
them appropriately, so later on we can find them and merge results they
contain directly back for the root filesystem.
The series includes also a new private debug API, and its usage to fix
the resolution of /dev/mapper/.. devices found in fstab; without it,
LVM /usr filesystems are not recognized as belonging to their
2014 Dec 03
1
[PATCH 1/4] inspect_os: Add support for detecting OpenBSD
Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr>
---
src/guestfs-internal.h | 1 +
src/inspect-fs-unix.c | 106 +++++++++++++++++++++++++++++++++++++++++++++++--
src/inspect-fs.c | 12 ++++++
3 files changed, 116 insertions(+), 3 deletions(-)
diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h
index 33d28f5..c8dd084 100644
--- a/src/guestfs-internal.h
+++
2015 Jun 02
1
[PATCH 2/3] inspection: Add support for CoreOS
* Implement coreos distro
* Detect CoreOS images
Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr>
---
generator/actions.ml | 4 +++
src/guestfs-internal.h | 3 +++
src/inspect-fs-unix.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++---
src/inspect-fs.c | 21 +++++++++++++++
src/inspect-icon.c | 1 +
src/inspect.c | 59
2015 May 29
2
[PATCH 2/3] inspection: Add support for CoreOS
* Implement coreos distro
* Detect CoreOS images
Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr>
---
generator/actions.ml | 4 +++
src/guestfs-internal.h | 3 +++
src/inspect-fs-unix.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++---
src/inspect-fs.c | 21 +++++++++++++++
src/inspect-icon.c | 1 +
src/inspect.c | 62
2013 Nov 28
0
[PATCH 3/3] inspect: improve detection of FreeBSD install discs
Check for /boot/loader.rc as "install disc" detection, using it to mark
FreeBSD install discs.
Also, check for /mfsroot.gz to see whether such disc is also a live one.
See also RHBZ#1033207.
---
src/inspect-fs-cd.c | 19 ++++++++++++++++++-
src/inspect-fs.c | 3 ++-
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/src/inspect-fs-cd.c b/src/inspect-fs-cd.c
index
2013 Nov 28
0
[PATCH 3/3, v2] inspect: improve detection of FreeBSD install discs
Check for /boot/loader.rc as "install disc" detection, using it to mark
FreeBSD install discs.
Also, check for /mfsroot.gz to see whether such disc is also a live one.
See also RHBZ#1033207.
---
src/inspect-fs-cd.c | 8 +++++++-
src/inspect-fs.c | 3 ++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/inspect-fs-cd.c b/src/inspect-fs-cd.c
index eaeaa6f..45d7bb5
2013 Nov 28
3
Re: [PATCH 3/3] inspect: improve detection of FreeBSD install discs
On Thu, Nov 28, 2013 at 02:48:38PM +0100, Pino Toscano wrote:
> Check for /boot/loader.rc as "install disc" detection, using it to mark
> FreeBSD install discs.
> Also, check for /mfsroot.gz to see whether such disc is also a live one.
>
> See also RHBZ#1033207.
> ---
> src/inspect-fs-cd.c | 19 ++++++++++++++++++-
> src/inspect-fs.c | 3 ++-
> 2 files
2016 Feb 24
2
[PATCH] inspect: check also /etc/hosts for detecting Linux root (RHBZ#1203898)
Use /etc/hosts as alternative of /etc/fstab to detect whether a partition
represents the root of a Linux installation; the latter might not exist
in smaller/special installations like Docker images.
---
src/inspect-fs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/inspect-fs.c b/src/inspect-fs.c
index 02fdb2a..ad175f8 100644
--- a/src/inspect-fs.c
+++
2014 Dec 02
0
[PATCH 2/5] inspect_os: Add support for detecting OpenBSD
Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr>
---
src/guestfs-internal.h | 1 +
src/inspect-fs-unix.c | 110 +++++++++++++++++++++++++++++++++++++++++++++----
src/inspect-fs.c | 12 ++++++
3 files changed, 116 insertions(+), 7 deletions(-)
diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h
index 33d28f5..c8dd084 100644
--- a/src/guestfs-internal.h
+++
2016 Feb 24
0
Re: [PATCH] inspect: check also /etc/hosts for detecting Linux root (RHBZ#1203898)
On Wed, Feb 24, 2016 at 05:31:32PM +0100, Pino Toscano wrote:
> Use /etc/hosts as alternative of /etc/fstab to detect whether a partition
> represents the root of a Linux installation; the latter might not exist
> in smaller/special installations like Docker images.
> ---
> src/inspect-fs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git
2016 May 05
0
[PATCH v2] inspect: check also /etc/hosts for detecting Linux root (RHBZ#1203898)
Use /etc/hosts as alternative of /etc/fstab to detect whether a partition
represents the root of a Linux installation; the latter might not exist
in smaller/special installations like Docker images.
---
Repost (refreshed) of
https://www.redhat.com/archives/libguestfs/2016-February/msg00207.html
src/inspect-fs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
2014 Nov 27
0
[PATCH 0/1] inspect: Fix a bug in the *BSD root detection
Hello,
I've been reading the *BSD detection code in check_filesystem() in
inspect-fs.c in order to write a patch for OpenBSD detection that is
missing. Both, in FreeBSD and in NetBSD you have this piece of code:
/* Ignore /dev/sda1 which is a shadow of the real root filesystem
* that is probably /dev/sda5 (see:
* http://www.freebsd.org/doc/handbook/disk-organization.html)
2014 Sep 22
1
[PATCH] inspect: basic Minix support
Add a basic support for identifying Minix, extracting its version and
hostname.
Related to RHBZ#1144137.
---
src/guestfs-internal.h | 2 ++
src/inspect-apps.c | 1 +
src/inspect-fs-unix.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++
src/inspect-fs.c | 11 ++++++++++
src/inspect-icon.c | 1 +
src/inspect.c | 1 +
6 files changed, 73 insertions(+)
diff
2016 Mar 17
2
[PATCH] inspect: improve UsrMove detection (RHBZ#1186935)
In case /usr is a symlink to /usr/bin, then we cannot rely on /usr/bin
to exist, since /usr might be in a different partition. Thus, in case
/bin is a symlink, check it points to "usr/bin".
---
src/inspect-fs.c | 20 ++++++++++++++++++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/src/inspect-fs.c b/src/inspect-fs.c
index 02fdb2a..0714ae1 100644
---
2016 Dec 06
0
[PATCH 5/5] inspect: gather info from /usr filesystems as well (RHBZ#1401474)
Flag the filesystems for Linux /usr properly as USR role, and detect
some data out of it, like the distro information from an os-release
(if present), and the architecture (since the binaries used for our
architecture check will be available there only).
Later on, collect the results in a way similar to what is done for
CoreOS: for each non-CoreOS root, try to find its /usr filesystem, and
if
2017 Oct 05
2
[PATCH] inspector: Fix virt-inspector on *BSD guests (RHBZ#1144138).
---
inspector/inspector.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/inspector/inspector.c b/inspector/inspector.c
index 3583c61df..30d279987 100644
--- a/inspector/inspector.c
+++ b/inspector/inspector.c
@@ -347,6 +347,7 @@ output_root (xmlTextWriterPtr xo, char *root)
char buf[32];
char *canonical_root;
size_t size;
+ int is_bsd;
XMLERROR
2016 Mar 17
0
Re: [PATCH] inspect: improve UsrMove detection (RHBZ#1186935)
On Thu, Mar 17, 2016 at 12:25:18PM +0100, Pino Toscano wrote:
> In case /usr is a symlink to /usr/bin, then we cannot rely on /usr/bin
> to exist, since /usr might be in a different partition. Thus, in case
> /bin is a symlink, check it points to "usr/bin".
> ---
> src/inspect-fs.c | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>