similar to: [PATCH v2 0/4] launch: libvirt: Use qemu-bridge-helper to implement a full network (RHBZ#1148012).

v3: - Various changes to dhclient/dhcpcd as discussed on the mailing list.

Let's actually compile and test the patch this time, rather than trusting the RHEL 7.6 patch to apply directly to head ... Rich.

Possibly for post 1.40. Rich.

qemu in SLIRP mode offers DHCP services to the appliance. We don't use them, but use a fixed IP address intead. This changes the appliance to get its IP address using DHCP. Note: This is only used when the network is enabled. dhclient is somewhat slower, but the penalty (a few seconds) is only paid for network users. We could consider using the faster systemd dhcp client instead. ---

v1 was here: https://www.redhat.com/archives/libguestfs/2018-October/msg00047.html However it was broken in a few ways. First of all the documentation was broken because "/**" enhanced comments were not permitted on macros. This is fixed in the new 1/4 patch. Secondly we didn't use single_element() everywhere possible, which is fixed in the new 4/4 patch. Lastly I've

Consolidate and extend the use of funky start_element() etc macros. Rich.

On Tue, Sep 30, 2014 at 04:44:05PM +0100, Richard W.M. Jones wrote: > When using the libvirt backend, don't use the SLIRP. Use > qemu-bridge-helper via libvirt to give us a full network connection. > One consequence of this is that 'ping' works in virt-builder > --run-command. > > Note unfortunately this does not fix virt-rescue (since it overrides > the default

v1 was here: https://www.redhat.com/archives/libguestfs/2018-October/msg00047.html v2 was here: https://www.redhat.com/archives/libguestfs/2018-October/msg00051.html v3: - Back to using string/string_format and attribute/attribute_format. - Add both single_element and single_element_format. - Rebased and retested. Rich.

We've been carrying this exact patch in RHEL 7 for several years. It reverts the change made in 2014 where we switched to using the virbr0 bridge for libguestfs networking instead of SLIRP. We thought SLIRP was going to become unsupported in qemu, but recently there have been more encouraging signs since it looks like SLIRP will be spun off as a separate project, running as a modular process

Since v1: - Base64 decode the Ceph secret before passing it to libvirt. - Don't call virSecretFree (NULL) [libvirt bug?] - Small cleanups.

This patch causes aarch64 to use virtio-pci instead of virtio-mmio. Virtio-pci is considerably faster than virtio-mmio, it's more like how other architectures work, and it supports hotplugging (although it's not likely we'd use the latter feature). I'm not necessarily suggesting that we apply this. Laine (CC'd) has some further patches to libvirt lined up which AIUI would

Unfortunately I was not able to test this because I don't currently have access to a P9 machine. Rich.

Use libvirt to set up the user network instead of a custom qemu argument. Note this requires a non-upstream patch being discussed on the libvirt mailing list at the moment. https://bugzilla.redhat.com/show_bug.cgi?id=1075520#c6 Rich.

Of course I mean state=off (not <htm state=on>) ... Rich.

On Monday, 3 September 2018 10:09:07 CEST Richard W.M. Jones wrote: > See: > https://bugzilla.redhat.com/show_bug.cgi?id=1614948#c23 > > Thanks: David Gibson. > --- > lib/launch-direct.c | 3 +++ > lib/launch-libvirt.c | 10 ++++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/lib/launch-direct.c b/lib/launch-direct.c > index 47e8f37de..94dd995c6

v1 was here: https://www.redhat.com/archives/libguestfs/2018-September/thread.html#00000 v2: - Make conditional on qemu >= 2.11.2 and libvirt >= 4.6.0. - Fix the libvirt XML to match what went upstream. Still untested. Rich.

On Friday, 2 November 2018 16:05:04 CET Richard W.M. Jones wrote: > diff --git a/common/utils/libxml2-writer-macros.h b/common/utils/libxml2-writer-macros.h > index d74dcd465..a99b245bb 100644 > --- a/common/utils/libxml2-writer-macros.h > +++ b/common/utils/libxml2-writer-macros.h > @@ -86,7 +86,7 @@ > * > * which produces C<<< <name>text</name>

In some places when generating XML output in C code we use some clever macros: start_element ("memory") { attribute ("unit", "MiB"); string ("%d", g->memsize); } end_element (); This commit which is mostly refactoring moves the repeated definitions of these macros into a common header file. I also took this opportunity to change / clean up

Commit aa9e0057b19e29f76c9a81f9aebeeb1cb5bf1fdb made the libvirt backend use <shareable/> for the disk of the appliance, since at that time all the instances were using the disk directly. OTOH, commit 3ad44c866042919374e2d840502e53da2ed8aef0 switched to overlays for read-only disks, including the appliance, so effectively protecting the appliance. Because of this, the libvirt backend does

When using the libvirt backend, don't use the SLIRP. Use qemu-bridge-helper via libvirt to give us a full network connection. One consequence of this is that 'ping' works in virt-builder --run-command. Note unfortunately this does not fix virt-rescue (since it overrides the default backend and uses 'direct' for various reasons). --- src/launch-libvirt.c | 34