similar to: [PATCH] tests/regressions: remove C part of rhbz1044014

Thanks: Dan Berrangé for identifying the problem. --- .gitignore | 1 + src/command.c | 11 +++++++ tests/regressions/Makefile.am | 13 +++++++- tests/regressions/test-big-heap.c | 69 +++++++++++++++++++++++++++++++++++++++ 4 files changed, 93 insertions(+), 1 deletion(-) create mode 100644 tests/regressions/test-big-heap.c diff --git

From: "Richard W.M. Jones" <rjones@redhat.com> It's not our job to worry about downstream packaging issues ... --- tests/regressions/Makefile.am | 6 +-- tests/regressions/test-noexec-stack.pl | 84 ---------------------------------- 2 files changed, 2 insertions(+), 88 deletions(-) delete mode 100755 tests/regressions/test-noexec-stack.pl diff --git

Test case adapted from Hu Zhang's RHBZ#1242853, thanks. --- tests/regressions/Makefile.am | 2 + tests/regressions/rhbz1011907-1165785.sh | 66 ++++++++++++++++++++++++++++++++ 2 files changed, 68 insertions(+) create mode 100755 tests/regressions/rhbz1011907-1165785.sh diff --git a/tests/regressions/Makefile.am b/tests/regressions/Makefile.am index c4f60ae..026987b 100644 ---

It's not our job to worry about downstream packaging issues ... --- generator/tests.ml | 1 - tests/regressions/Makefile.am | 3 +- tests/regressions/test-noexec-stack.pl | 78 ---------------------------------- tests/regressions/tests.mk | 3 +- 4 files changed, 2 insertions(+), 83 deletions(-) delete mode 100755

--- .gitignore | 2 +- builder/index-validate.c | 2 +- builder/pxzcat-c.c | 2 +- common/edit/file-edit.c | 2 +- common/mlutils/c_utils-c.c | 2 +- common/options/options.h | 2 +- common/options/uri.c

The reason it's not just ‘utils.h’ is because Pino is worried that we might pick up /usr/include/utils.h from a rogue library. --- .gitignore | 2 +- builder/index-validate.c | 2 +- builder/pxzcat-c.c | 2 +- common/edit/file-edit.c

Remove the GUESTFS_PRIVATE=1 define for some tools and tests which don't really use any private API. --- align/Makefile.am | 1 - df/Makefile.am | 1 - tests/protocol/Makefile.am | 1 - tests/qemu/Makefile.am | 2 -- tests/regressions/Makefile.am | 6 ++---- 5 files changed, 2 insertions(+), 9 deletions(-) diff --git a/align/Makefile.am

This is almost just refactoring, but I also set the memory limit to really 1 GB, and not 1×10⁹. --- src/info.c | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/src/info.c b/src/info.c index d7f45f0..616ef50 100644 --- a/src/info.c +++ b/src/info.c @@ -56,6 +56,7 @@ static yajl_val get_json_output (guestfs_h *g, const char *filename); static char

It's not our job to worry about downstream packaging issues ... --- generator/tests.ml | 1 - tests/regressions/Makefile.am | 3 +- tests/regressions/test-noexec-stack.pl | 78 ---------------------------------- tests/regressions/tests.mk | 3 +- 4 files changed, 2 insertions(+), 83 deletions(-) delete mode 100755

https://bugzilla.redhat.com/show_bug.cgi?id=1175196 Currently if you write something like LIBGUESTFS_DEBUG=0 or LIBGUESTFS_DEBUG=true then it doesn't do what you probably expect. This patch series fixes that. Rich.

Create a new guestfs-private.h header, and move there the definitions of all the actions with visibility VInternal, and all the private structs: they are not meant to be used, not even seen, outside of the library. Include the new header where needed, which means also a couple of places outside the library (but they are tests, so it is acceptable for now). The result of this is mostly motion of

Wherever we had code which did: if (something_bad) { perror (...); exit (EXIT_FAILURE); } replace this with use of the error(3) function: if (something_bad) error (EXIT_FAILURE, errno, ...); The error(3) function is supplied by glibc, or by gnulib on platforms which don't have it, and is much more flexible than perror(3). Since we already use error(3), there seems to be

Only in end-user messages and documentation. This change was done mostly mechanically using the Perl script attached below. I also changed don't -> don’t etc and made some other simple fixes. See also: https://www.cl.cam.ac.uk/~mgk25/ucs/quotes.html ---------- #!/usr/bin/perl -w use strict; use Locale::PO; my $re = qr{'([-\w%.,=?*/]+)'}; my %files = (); foreach my $filename

Since v4: - More tests have been converted. - Testing local guests fixed. - Drop no-exec-stack test.

Just code motion. This commit makes it clearer what is a utility and what is part of the library. It also makes it clear that we should rename: guestfs-internal-frontend.h -> utils.h guestfs-internal-frontend-cleanups.h -> cleanups.h (?) but this commit does not make that change. --- .gitignore | 10 ++--- Makefile.am

For v6: This is mainly just a rebase, but I have also added tests in the ocaml/ language bindings directory, and for all the OCaml-written virt tools. Rich.

v7: The only changes since v6 are those suggested by Pino in the review of v5.

This converts more of the tests (basically everything under tests/) to use the test harness, revealing some problems which have subsequently been fixed. Rich.

Those cleanups which only depend on libc, gnulib or libxml2 are split out into a separate common/cleanups directory. --- .gitignore | 3 +- Makefile.am | 4 +- align/Makefile.am | 2 + builder/Makefile.am | 4 + cat/Makefile.am

These are my thoughts on adding a test harness to run tests instead of using automake. The aim of this exercise is to allow us to run the full test suite on an installed copy of libguestfs. Another aim is to allow us to work around all the limitations and problems of automake. The first patch makes an observation that since the ./run script sets up $PATH to contain all the directories