similar to: [PATCH] drives: add CD-ROM disk images as read-only drives (RHBZ#563450).

On Saturday 14 December 2013 22:50:28 Richard W.M. Jones wrote: > On Fri, Dec 13, 2013 at 04:32:49PM +0100, Pino Toscano wrote: > > The current add_cdrom way basically appends a new raw "-cdrom /path" > > parameter to the qemu invocation (even when using libvirt as > > backend), hence such images are seen as "CD-ROM drives" inside the > > appliance.

On Fri, Dec 13, 2013 at 04:32:49PM +0100, Pino Toscano wrote: > The current add_cdrom way basically appends a new raw "-cdrom /path" > parameter to the qemu invocation (even when using libvirt as backend), > hence such images are seen as "CD-ROM drives" inside the appliance. > However, there is no need for such particular behaviour, as they need to > be handled

The current add_cdrom way basically appends a new raw "-cdrom /path" parameter to the qemu invocation (even when using libvirt as backend), hence such images are seen as "CD-ROM drives" inside the appliance. However, there is no need for such particular behaviour, as they need to be handled as normal (read-only) drives. Adding CD-ROM disk images as drives also changes the

On Wednesday 18 December 2013 20:44:33 Richard W.M. Jones wrote: > On Fri, Dec 13, 2013 at 04:32:49PM +0100, Pino Toscano wrote: > > diff --git a/tests/regressions/rhbz563450.sh > > b/tests/regressions/rhbz563450.sh new file mode 100755 > > index 0000000..6fa6f2b > > --- /dev/null > > +++ b/tests/regressions/rhbz563450.sh > > @@ -0,0 +1,54 @@ > >

Added in 2392fae6803b9de4a4761509007c160339d57f50 and removed in be025369ad622867ecf08d5c9170e8e59d2d6294; now they should work with any backend, as the device names are normalised and not change the guestfish output depending on the used backend. Thanks Richard for the hints. --- tests/regressions/Makefile.am | 2 ++ tests/regressions/rhbz563450.sh | 59

On Fri, Dec 13, 2013 at 04:32:49PM +0100, Pino Toscano wrote: > diff --git a/tests/regressions/rhbz563450.sh b/tests/regressions/rhbz563450.sh > new file mode 100755 > index 0000000..6fa6f2b > --- /dev/null > +++ b/tests/regressions/rhbz563450.sh > @@ -0,0 +1,54 @@ > +#!/bin/bash - > +# libguestfs > +# Copyright (C) 2013 Red Hat Inc. > +# > +# This program is free

--- test-data/phony-guests/Makefile.am | 3 +-- test-data/phony-guests/make-archlinux-img.sh | 4 ++-- test-data/phony-guests/make-coreos-img.sh | 10 ++++---- test-data/phony-guests/make-debian-img.sh | 10 ++++---- test-data/phony-guests/make-fedora-img.pl | 34 ++++++++++++++-------------- test-data/phony-guests/make-ubuntu-img.sh | 14 ++++++------

Hi, small series with small improvements to the tests. Pino Toscano (3): tests: specify the image format when possible tests: remove remaining relative paths to binaries fish: generate test-prep.sh with generator .gitignore | 1 + align/test-virt-alignment-scan.sh | 2 +- cat/Makefile.am | 2 +- cat/test-virt-cat.sh

Previously I posted a work-in-progress preview of this patch series: https://www.redhat.com/archives/libguestfs/2017-February/msg00224.html This is the finished version that updates all of the shell-script based tests. It passes 'make check', 'make check-direct' and 'make check-slow'. Rich.

These are my thoughts on adding a test harness to run tests instead of using automake. The aim of this exercise is to allow us to run the full test suite on an installed copy of libguestfs. Another aim is to allow us to work around all the limitations and problems of automake. The first patch makes an observation that since the ./run script sets up $PATH to contain all the directories

Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- align/test-virt-alignment-scan-guests.sh | 2 +- align/test-virt-alignment-scan.sh | 2 +- builder/test-virt-builder-planner.sh | 2 +- builder/website/ubuntu.sh | 2 +- configure.ac | 2 +- fish/test-mount-local.sh | 2 +- make-fs/test-virt-make-fs.sh | 2 +-

This converts more of the tests (basically everything under tests/) to use the test harness, revealing some problems which have subsequently been fixed. Rich.

Since v4: - More tests have been converted. - Testing local guests fixed. - Drop no-exec-stack test.

For v6: This is mainly just a rebase, but I have also added tests in the ocaml/ language bindings directory, and for all the OCaml-written virt tools. Rich.

v7: The only changes since v6 are those suggested by Pino in the review of v5.

I should probably start by saying this patch series isn't ready for review yet. This patch series adds a test harness to libguestfs. It allows us to run the tests outside the ordinary 'make check' path in the build tree. In particular, you can use this to run tests when libguestfs has been installed. 'make check' and the other 'make check-*' rules still work. The

When possible, make the disk image format explicit when invoking tools or using add-drive. This avoids warnings from qemu about the unspecified format for the image, and also makes qemu slightly faster (skipping the disk image probing). Tests checking the image probing are not touched. This changes also: - old-style invocations of tools (`$tool $filename`) into new style (`$tool -a $filename`)

Hi Rich, This series includes patches to make `make syntax-check` pass. Some of the fix require change to maint.mk, but the file is not in git repo. Is it intended? Thanks! Hu Tao (13): syntax-check: dirty hack to pass bindtextdomain check syntax-check: fix error_message_period check syntax-check: fix makefile_at_at_check syntax-check: fix prohibit_assert_without_use check

Note: This is a regression in RHEL 6.3. Please review this patch urgently. The description of the bug is here: https://bugzilla.redhat.com/show_bug.cgi?id=812092 This patch set attempts to fix the problem conservatively, because it's a very high risk codepath and very late in the development of RHEL 6.3. The first patch reverts the behaviour of calling realpath(3) and checking for

This is a more complete patch to add the test harness. The only parts missing now are the language bindings (except OCaml). The language bindings need a bit more thought. At the moment most language binding tests are done through some sort of shell script like perl/run-perl-tests which either runs each test itself or uses some language-specific machinary to run each test. The problem with that