similar to: [PATCH] virt-v2v: Add use augeas_error to GrubLegacy, plus typo fixup

On Friday, October 11, 2013 04:57:32 PM Mike Latimer wrote: > I think I've addressed all the concerns you raised in the following patch. > Can you take a look and let me know if I've created any new ones? ;) Other than the concern about being a little too obsessed about the 79 character line length. ;) This version of the patch has all the unecessary cleanup removed, and only

On Tuesday, October 08, 2013 10:05:17 AM Matthew Booth wrote: > Feel free to remove ^$path. However, for robustness I ditch the leading > ^ from your replacement. The difference will be down to a different > version of file included in the libguestfs appliance on SUSE. I think I've addressed all the concerns you raised in the following patch. Can you take a look and let me know if

The SUSE converter itself, based on the RedHat converter. This supports converting SLES 10/11 and openSUSE 10/11/12/13. --- MANIFEST | 1 + lib/Sys/VirtConvert/Converter/SUSE.pm | 2527 +++++++++++++++++++++++++++++++++ 2 files changed, 2528 insertions(+) diff --git a/MANIFEST b/MANIFEST index 3724fde..615ec32 100644 --- a/MANIFEST +++ b/MANIFEST @@ -17,6 +17,7

This is a proposed patch which changes the RedHat.pm converter to Linux.pm, and adds support for SUSE guest conversion. This is first approach recommended by Matt Booth in: https://www.redhat.com/archives/libguestfs/2013-September/msg00076.html Some aspects of this patch still need additional testing, and a couple of changes are not foolproof (such as the lack of grub2 support in the menu.lst

Mike, This is great. I have a couple of minor comments inline, but this looks good. I do have a major concern, though, which is this is basically a fork of RedHat.pm. There are well over 1,000 identical lines of code between the 2 modules. Many of the differences are relatively minor, and could be handled with additional cases. I've also fixed a couple of bits in RedHat.pm since you forked

This approach looks great. I think there are a couple of bits to look at (see below), but probably not much. Matt On Wed, 2013-10-02 at 23:46 -0600, Mike Latimer wrote: > This is a proposed patch which changes the RedHat.pm converter to Linux.pm, > and adds support for SUSE guest conversion. This is first approach recommended > by Matt Booth in: > >

Matt, Thanks for the extensive comments. I'll go through them in detail, but it won't be until next week. For the time being, here's a quick take on some of the main issues: > I do have a major concern, though, which is this is basically a fork of > RedHat.pm. There are well over 1,000 identical lines of code between the > 2 modules. Many of the differences are relatively

On Friday, October 04, 2013 09:38:58 AM Matthew Booth wrote: > It's specifically an error if we're attempting to configure virtio, and > there's no detected virtio kernel. It shouldn't have been possible to > get here in that state, hence it's a programmer error. The code below > attempts to install *any* kernel in the case that we aren't configuring >

This change is part of an ongoing effort to remove use of $desc and inspect the OS directly as required during conversion. --- lib/Sys/VirtConvert/Connection/LibVirtTarget.pm | 4 +- lib/Sys/VirtConvert/Connection/RHEVTarget.pm | 41 +++++++++--------- lib/Sys/VirtConvert/Converter.pm | 35 ++++++++++++---- lib/Sys/VirtConvert/Converter/RedHat.pm | 45

In preparation for an upcoming patch which adds support for SUSE guest conversions, it makes sense to have an intermediate steps that changes the RedHat.pm converter into a more generic Linux converter. The SUSE changes will then be limited in scope to only what is required for SUSE support. This series of patches accomplishes the following: - Renames RedHat.pm to Linux.pm - Modifies Linux.pm

This is a new conversion module to convert SUSE Linux and openSUSE guests. The converter is based on the RedHat module, and should offer the same functionality on both SUSE and RedHat hosts. There are a few additional messages in this module, such as reporting of packages when installing through zypper or the local virt-v2v repo. These messages don't necessarily flow unless verbose switches

For guests registered with Red Hat Network, this patch allows for the conversion process to use RHN to download appropriate kernel package and its dependencies. We use yum on RHEL-5, up2date libraries on RHEL-4. We install matching kernel version whenever possible, latest available kernel version otherwise. _discover_kernel routine has been extended to return version-release of the default

When a conversion requires a file from the config file which isn't present, we currently die and report which file was missing. If there are many missing dependencies, using this method to find them all would take multiple runs. This change attempts to find all missing dependencies in the first run. --- lib/Sys/VirtV2V/Config.pm | 9 ---- lib/Sys/VirtV2V/GuestOS/RedHat.pm | 83

The following series of patches adds support for converting SUSE guests through virt-v2v. These changes should not impact non-SUSE guest conversions. Mike Latimer (4): Add perl-Bootloader support to grub packages Add conversion support for SUSE guests Add SUSE to capabilities db and conf Add SUSE support documentation lib/Sys/VirtConvert/Converter/Linux.pm | 480

We previously wouldn't create a Config object if no config file was specified. This change ensures that a Config object is always created, but will do nothing interesting if there is no config file. Apart from being slightly cleaner, this allows information provided by Config to be later supplied from the command line instead. --- lib/Sys/VirtV2V/Config.pm | 34

Hello, I've trying to move a 32bit CentOS 6.4 on VirtualBox to oVirt on Fedora 19 64bit via virt-v2v. The command I'm currently using is: virt-v2v -i libvirtxml -of qcow2 -oa sparse -o rhev -osd xxx.xxx.xxx.xxx:/usr/local/ovirt/exports --network ovirtmgmt /usr1/home/williams/Downloads/OpenAthens/VMs/OpenAthensLARuntime2.2.xml The exciting bit of the XML is: <devices>

Conversion would fail if it was necessary to install a package, and multiple architectures of that package were already installed. This was happening specifically with device-mapper on RHEL 5 conversions. Unfortunately the flat dependency list in the config file didn't really allow this to be fixed. The best that could be done is to specify both i386 and x86_64 dependencies, but would mean

This patch series includes a repost of Milan's unmodified RHN support patch because I haven't pushed it yet. On top of that patch, it includes the capabilities patch in as many bits as I could make it into. The big one is 7/8. I've tested all of the following guests both with and without RHN registration: Xen RHEL 54 PV Xen RHEL 51 PV Xen RHEL 48 PV ESX RHEL 54 FV

This removes another chunk of functionality from GuestOS. --- MANIFEST | 1 + lib/Sys/VirtV2V/Config.pm | 339 +++++++++++++++++++++++++++++++++++++ lib/Sys/VirtV2V/Converter.pm | 56 +----- lib/Sys/VirtV2V/GuestOS.pm | 94 ---------- lib/Sys/VirtV2V/GuestOS/RedHat.pm | 46 ++++-- v2v/virt-v2v.pl | 96 +---------- 6 files

On Mon, 2013-10-07 at 10:58 -0600, Mike Latimer wrote: > On Friday, October 04, 2013 09:38:58 AM Matthew Booth wrote: > > It's specifically an error if we're attempting to configure virtio, and > > there's no detected virtio kernel. It shouldn't have been possible to > > get here in that state, hence it's a programmer error. The code below > >