similar to: [PATCH] docs: guestfs_case_sensitive_path returns error on non-existent path

--- generator/actions.ml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/generator/actions.ml b/generator/actions.ml index c73a319..32758b1 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -7161,6 +7161,9 @@ created under Windows). I<Note>: This function does not handle drive names, backslashes etc. +C<guestfs_case_sensitive_path> will return an error if

From: "Richard W.M. Jones" <rjones at redhat.com> Don't assume that if guestfs_case_sensitive_path returns NULL, that it means the file does not exist. The (previously undefined) behaviour of case_sensitive_path was that a NULL return meant "either the file doesn't exist or some other error". However in commit 973581780d8a006f336684fef6762801402d775d this was

Some virtio-win drivers contain more files than just *.{cat,inf,sys}. They are filtered out currently, which prevents the drivers from being installed by PnP. Stop filtering driver files by extension, and copy all of them instead. Signed-off-by: Roman Kagan <rkagan@virtuozzo.com> --- v1 -> v2: - update unit test to match the changed behavior v2v/v2v_unit_tests.ml | 202

Instead of trying to split and parse elements from virtio-win paths, use the '*.inf' files supplied with the drivers to control how Windows drivers are installed. The following emails best explain how this works: https://www.redhat.com/archives/libguestfs/2015-October/msg00352.html https://www.redhat.com/archives/libguestfs/2015-November/msg00065.html Currently the product variant (eg.

- fix names of arguments & optional arguments in C<..> markers - use https for URLs where possible - fix links to other guestfs APIs - use more C<..> markers for special tests, shell commands, values of arguments, and names of fields - link to command man pages where an explicit command is mentioned - fix few incorrect documentation bits --- generator/actions_augeas.ml

In order to test the copying of virtio-win drivers into the guest during v2v, create a set of fake virtio-win drivers and make use of them in the corresponding v2v tests. Signed-off-by: Roman Kagan <rkagan@virtuozzo.com> --- tests/fake-virtio-win/drivers/i386/Win7/netkvm.cat | 1 + tests/fake-virtio-win/drivers/i386/Win7/netkvm.inf | 1 +

In order to test the copying of virtio-win drivers into the guest during v2v, create a set of fake virtio-win drivers and make use of them in the corresponding v2v tests. Signed-off-by: Roman Kagan <rkagan@virtuozzo.com> --- changes since v1: - moved fake-virtio-win under v2v - referred to fake-virtio-win stuff via $PWD in test scripts - updated Makefile to package the newly added files

On 6/1/20 5:31 AM, Richard W.M. Jones wrote: > This command fails with an incorrect error message: > > $ nbdkit ssh host=localhost /nosuchfile password=- --run 'qemu-img info $nbd' </dev/null > password: > nbdkit: error: could not read password from stdin: Inappropriate ioctl for device > > The error (ENOTTY Inappropriate ioctl for device) is actually a

On Thu, Feb 07, 2013 at 09:53:39PM +1100, Vadim Rozenfeld wrote: > On Thu, 2013-02-07 at 12:18 +0200, Michael S. Tsirkin wrote: > > On Thu, Feb 07, 2013 at 08:24:10PM +1100, Vadim Rozenfeld wrote: > > > On Thu, 2013-02-07 at 11:33 +1030, Rusty Russell wrote: > > > > Vadim Rozenfeld <vrozenfe at redhat.com> writes: > > > > > On Tue, 2013-02-05 at

On Thu, Feb 07, 2013 at 09:53:39PM +1100, Vadim Rozenfeld wrote: > On Thu, 2013-02-07 at 12:18 +0200, Michael S. Tsirkin wrote: > > On Thu, Feb 07, 2013 at 08:24:10PM +1100, Vadim Rozenfeld wrote: > > > On Thu, 2013-02-07 at 11:33 +1030, Rusty Russell wrote: > > > > Vadim Rozenfeld <vrozenfe at redhat.com> writes: > > > > > On Tue, 2013-02-05 at

This command fails with an incorrect error message: $ nbdkit ssh host=localhost /nosuchfile password=- --run 'qemu-img info $nbd' </dev/null password: nbdkit: error: could not read password from stdin: Inappropriate ioctl for device The error (ENOTTY Inappropriate ioctl for device) is actually a leftover errno from the previous isatty call. This happens because getline(3) can

This series makes several enhancements to tests for v2v conversion of Windows guests. Specifically, it - adds a number of files which imitate the stuff that is supposed to be present on the host when the actual conversion is performed, but may not be there when the tests are run. This includes certain tools and virtio drivers - fixes the test for windows conversion to actually

Refactor copying of virtio windows drivers into the guest so that the matching of the drivers to the guest os flavor and copying the files happens one next to the other in a single function, and no guestfs handle (nor any other irrelevant info) is leaked outside. Signed-off-by: Roman Kagan <rkagan@virtuozzo.com> --- v2v/convert_windows.ml | 77 ++++++++++------- v2v/utils.ml |

Refactor copying of virtio windows drivers into the guest so that the matching of the drivers to the guest os flavor and copying the files happens one next to the other in a single function, and no guestfs handle (nor any other irrelevant info) is leaked outside. Signed-off-by: Roman Kagan <rkagan@virtuozzo.com> --- changes since v1: - former patch #3 - updated usage of string functions

This makes several changes to the handling of virtio-win drivers: The VIRTIO_WIN_DIR environment variable has been renamed VIRTIO_WIN (but you can still use the old name). You can point the VIRTIO_WIN either at a RHEL virtio-win directory (ie. /usr/share/virtio-win), OR at a loopback-mounted virtio-win ISO, OR at the virtio-win.iso file itself. In the latter case, libguestfs is used to open the

This makes several changes to the handling of virtio-win drivers: The VIRTIO_WIN_DIR environment variable has been renamed VIRTIO_WIN (but you can still use the old name). You can point the VIRTIO_WIN either at a RHEL virtio-win directory (ie. /usr/share/virtio-win), OR at a loopback-mounted virtio-win ISO, OR at the virtio-win.iso file itself. In the latter case, libguestfs is used to open the

On Mon, Oct 05, 2015 at 02:24:18PM +0100, Richard W.M. Jones wrote: > On Mon, Oct 05, 2015 at 03:40:03PM +0300, Roman Kagan wrote: > > v2v/test-v2v-windows-conversion.sh used to query if the expected > > directories and filed were present in the VM upon conversion; however it > > would ignore the results of that query. > > > > That lead to the test passing even

Windows QXL drivers include also qxldd.dll which used to get filtered out and not copied over into the guest. As a result QXL driver failed to install due to a missing file. Correct that, and update the tests accordingly. Signed-off-by: Roman Kagan <rkagan@virtuozzo.com> --- v2v/fake-virtio-win/drivers/i386/Win7/qxldd.dll | 1 + v2v/test-v2v-in-place.sh | 1 +

On Thu, Oct 29, 2015 at 10:33:57AM +0200, Yan Vugenfirer wrote: > > On 29 Oct 2015, at 10:28, Richard W.M. Jones <rjones@redhat.com> wrote: > > On Thu, Oct 29, 2015 at 11:05:42AM +1100, Vadim Rozenfeld wrote: > > > > Seems like looking at this field in the .inf file is better than our > > current approach of matching path names. > > You just need to

On Wed, Dec 05, 2018 at 01:18:49PM +0100, Fabien Dupont wrote: > On Wed, Dec 5, 2018 at 12:01 PM Richard W.M. Jones <rjones@redhat.com> > wrote: > > > On Wed, Dec 05, 2018 at 09:01:16AM +0000, Roman Kagan wrote: > > > On Tue, Dec 04, 2018 at 05:29:31PM +0000, Richard W.M. Jones wrote: > > > > This patch is just for discussion. There are still a couple of