similar to: [PATCH] virtio_mmio: generation support

"Michael S. Tsirkin" <mst at redhat.com> writes: > virtio_mmio currently lacks generation support which > makes multi-byte field access racy. > Fix by getting the value at offset 0xfc for version 2 > devices. Nothing we can do for version 1, so return > generation id 0. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > > Pawel,

"Michael S. Tsirkin" <mst at redhat.com> writes: > virtio_mmio currently lacks generation support which > makes multi-byte field access racy. > Fix by getting the value at offset 0xfc for version 2 > devices. Nothing we can do for version 1, so return > generation id 0. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > > Pawel,

Going over the virtio mmio code, I noticed that it doesn't correctly return device config values in LE format when using virtio 1.0. Borrow code from virtio_pci_modern to do this correctly. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Note: untested: QEMU doesn't support virtio 1.0 for virtio-mmio. Pawel, could you please confirm this patch makes sense?

Going over the virtio mmio code, I noticed that it doesn't correctly return device config values in LE format when using virtio 1.0. Borrow code from virtio_pci_modern to do this correctly. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Note: untested: QEMU doesn't support virtio 1.0 for virtio-mmio. Pawel, could you please confirm this patch makes sense?

Subject: [PATCH] virtio_mmio: fix access width for mmio Going over the virtio mmio code, I noticed that it doesn't correctly access modern device config values using "natural" accessors: it uses readb to get/set them byte by byte, while the virtio 1.0 spec explicitly states: 4.2.2.2 Driver Requirements: MMIO Device Register Layout ... The driver MUST only

Subject: [PATCH] virtio_mmio: fix access width for mmio Going over the virtio mmio code, I noticed that it doesn't correctly access modern device config values using "natural" accessors: it uses readb to get/set them byte by byte, while the virtio 1.0 spec explicitly states: 4.2.2.2 Driver Requirements: MMIO Device Register Layout ... The driver MUST only

On Thu, Mar 12, 2015 at 12:33:36PM +1030, Rusty Russell wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > Going over the virtio mmio code, I noticed that it doesn't correctly > > return device config values in LE format when using virtio 1.0. > > Borrow code from virtio_pci_modern to do this correctly. > > AFAICT, it doesn't need to.

On Thu, Mar 12, 2015 at 12:33:36PM +1030, Rusty Russell wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > Going over the virtio mmio code, I noticed that it doesn't correctly > > return device config values in LE format when using virtio 1.0. > > Borrow code from virtio_pci_modern to do this correctly. > > AFAICT, it doesn't need to.

On Mon, 2011-10-24 at 03:33 +0100, Rusty Russell wrote: > No, that's it I think. Please send a diff for the documentation, since > I'm updating the LyX master and I've already applied your previous > version. Here it goes (below). Also do you think you would be able to merge the driver (corresponding v4 patch follows) in the 3.2 merge window that seems to have just opened?

On Mon, 2011-10-24 at 03:33 +0100, Rusty Russell wrote: > No, that's it I think. Please send a diff for the documentation, since > I'm updating the LyX master and I've already applied your previous > version. Here it goes (below). Also do you think you would be able to merge the driver (corresponding v4 patch follows) in the 3.2 merge window that seems to have just opened?

Aiming these for coming merge window. Nothing should change, but get ready for a non-guest-endian config transports, and > 32 features bits. Final one is just an overdue consolidation. Cheers, Rusty. Rusty Russell (7): virtio_config: introduce size-based accessors. virtio: use size-based config accessors. virtio_config: helpers for non-converting accessors. virtio_config: make

Aiming these for coming merge window. Nothing should change, but get ready for a non-guest-endian config transports, and > 32 features bits. Final one is just an overdue consolidation. Cheers, Rusty. Rusty Russell (7): virtio_config: introduce size-based accessors. virtio: use size-based config accessors. virtio_config: helpers for non-converting accessors. virtio_config: make

"Michael S. Tsirkin" <mst at redhat.com> writes: > Going over the virtio mmio code, I noticed that it doesn't correctly > return device config values in LE format when using virtio 1.0. > Borrow code from virtio_pci_modern to do this correctly. AFAICT, it doesn't need to. The endian correction is done by the callers. The only reason that virtio_pci_modern() does

"Michael S. Tsirkin" <mst at redhat.com> writes: > Going over the virtio mmio code, I noticed that it doesn't correctly > return device config values in LE format when using virtio 1.0. > Borrow code from virtio_pci_modern to do this correctly. AFAICT, it doesn't need to. The endian correction is done by the callers. The only reason that virtio_pci_modern() does

From: Sebastien Boeuf <sebastien.boeuf at intel.com> On MMIO a new set of registers is defined for finding SHM regions. Add their definitions and use them to find the region. Signed-off-by: Sebastien Boeuf <sebastien.boeuf at intel.com> Cc: kvm at vger.kernel.org Cc: virtualization at lists.linux-foundation.org Cc: "Michael S. Tsirkin" <mst at redhat.com> ---

"Michael S. Tsirkin" <mst at redhat.com> writes: > On Thu, Mar 12, 2015 at 12:33:36PM +1030, Rusty Russell wrote: >> "Michael S. Tsirkin" <mst at redhat.com> writes: >> > Going over the virtio mmio code, I noticed that it doesn't correctly >> > return device config values in LE format when using virtio 1.0. >> > Borrow code

"Michael S. Tsirkin" <mst at redhat.com> writes: > On Thu, Mar 12, 2015 at 12:33:36PM +1030, Rusty Russell wrote: >> "Michael S. Tsirkin" <mst at redhat.com> writes: >> > Going over the virtio mmio code, I noticed that it doesn't correctly >> > return device config values in LE format when using virtio 1.0. >> > Borrow code

From: Yuan Liu <liuyuan at google.com> Fix a warning thrown from virtio_mmio_remove(): Device 'virtio0' does not have a release() function The fix is according to virtio_pci_probe() of drivers/virtio/virtio_pci_common.c Signed-off-by: Yuan Liu <liuyuan at google.com> --- drivers/virtio/virtio_mmio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

From: Yuan Liu <liuyuan at google.com> Fix a warning thrown from virtio_mmio_remove(): Device 'virtio0' does not have a release() function The fix is according to virtio_pci_probe() of drivers/virtio/virtio_pci_common.c Signed-off-by: Yuan Liu <liuyuan at google.com> --- drivers/virtio/virtio_mmio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

I think not. In virtio_pci_common, vp_dev is allocated by kzalloc so a kfree is needed. Here vm_dev is allocated by devm_kmalloc which is "automatically freed on driver detach" from the comment (drivers/base/devres.c:769). On Thu, Nov 24, 2016 at 6:37 PM, Jason Wang <jasowang at redhat.com> wrote: > > > On 2016?11?24? 08:31, Yuan Liu wrote: > >> From: Yuan Liu