similar to: [PATCH] virtio_blk: fix blk_mq_init_queue() error handling

From: Omar Sandoval <osandov at fb.com> If blk_mq_init_queue() returns an error, it gets assigned to vblk->disk->queue. Then, when we call put_disk(), we end up calling blk_put_queue() with the ERR_PTR, causing a bad dereference. Fix it by only assigning to vblk->disk->queue on success. Signed-off-by: Omar Sandoval <osandov at fb.com> --- drivers/block/virtio_blk.c | 3

From: Omar Sandoval <osandov at fb.com> If blk_mq_init_queue() returns an error, it gets assigned to vblk->disk->queue. Then, when we call put_disk(), we end up calling blk_put_queue() with the ERR_PTR, causing a bad dereference. Fix it by only assigning to vblk->disk->queue on success. Signed-off-by: Omar Sandoval <osandov at fb.com> --- drivers/block/virtio_blk.c | 3

On Mon, Jan 09, 2017 at 11:44:12AM -0800, Omar Sandoval wrote: > From: Omar Sandoval <osandov at fb.com> > > If blk_mq_init_queue() returns an error, it gets assigned to > vblk->disk->queue. Then, when we call put_disk(), we end up calling > blk_put_queue() with the ERR_PTR, causing a bad dereference. Fix it by > only assigning to vblk->disk->queue on success.

Linux kernel only supports logical block sizes which are power of two, at least 512 bytes and no more that PAGE_SIZE. Check this instead of crashing later on. Note that there is no need to check physical block size since it is only a hint, and virtio-blk already only supports power of two values. Bugzilla link: https://bugzilla.redhat.com/show_bug.cgi?id=1664619 Signed-off-by: Maxim Levitsky

Linux kernel only supports logical block sizes which are power of two, at least 512 bytes and no more that PAGE_SIZE. Check this instead of crashing later on. Note that there is no need to check physical block size since it is only a hint, and virtio-blk already only supports power of two values. Bugzilla link: https://bugzilla.redhat.com/show_bug.cgi?id=1664619 Signed-off-by: Maxim Levitsky

On Wed, Jul 15, 2020 at 12:55:18PM +0300, Maxim Levitsky wrote: > Linux kernel only supports logical block sizes which are power of two, > at least 512 bytes and no more that PAGE_SIZE. > > Check this instead of crashing later on. > > Note that there is no need to check physical block size since it is > only a hint, and virtio-blk already only supports power of two values.

On Wed, Jul 15, 2020 at 01:19:55PM +0300, Maxim Levitsky wrote: > On Wed, 2020-07-15 at 06:06 -0400, Michael S. Tsirkin wrote: > > On Wed, Jul 15, 2020 at 12:55:18PM +0300, Maxim Levitsky wrote: > > > Linux kernel only supports logical block sizes which are power of > > > two, > > > at least 512 bytes and no more that PAGE_SIZE. > > > > > >

Linux kernel only supports logical block sizes which are power of two, at least 512 bytes and no more that PAGE_SIZE. Check this instead of crashing later on. Note that there is no need to check physical block size since it is only a hint, and virtio-blk already only supports power of two values. Bugzilla link: https://bugzilla.redhat.com/show_bug.cgi?id=1664619 Signed-off-by: Maxim Levitsky

On Wed, 2020-07-15 at 06:06 -0400, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2020 at 12:55:18PM +0300, Maxim Levitsky wrote: > > Linux kernel only supports logical block sizes which are power of > > two, > > at least 512 bytes and no more that PAGE_SIZE. > > > > Check this instead of crashing later on. > > > > Note that there is no need to check

On Wed, 2020-07-15 at 06:06 -0400, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2020 at 12:55:18PM +0300, Maxim Levitsky wrote: > > Linux kernel only supports logical block sizes which are power of > > two, > > at least 512 bytes and no more that PAGE_SIZE. > > > > Check this instead of crashing later on. > > > > Note that there is no need to check

Hi In run-init.c there is a minor bug which can cause major problems i.e. not able to boot systems with udev-enabled initramfs on systems with multiple cdrom drives. In nuke_dirent () in run-init.c the stat call should be replaced with a lstat call, else nuking symbolic links which have been created before the link target will fail. Was somewhat tricky to debug... The bug gets triggered by udev

Hi, trying to build klibc 1.1.8 on x86 fails on my machine as follows: KLIBCCC dash/trap.o KLIBCCC dash/output.o dash/trap.c: In function 'trapcmd': dash/trap.c:94: warning: unused parameter 'argc' dash/trap.c:94: warning: unused parameter 'argv' dash/trap.c: In function 'decode_signal': dash/trap.c:398: error: 'SIGRTMIN' undeclared (first use in this

fstype is currently broken in klibc (1.1.14 and git). It segfaults on startup when not invoked with an argument. Attached patch fixes that. PS: The previously reported problems with klibc 1.1.8 don't occur anymore, thanks. Regards, J?rg -- J?rg Billeter <j@bitron.ch> -------------- next part -------------- A non-text attachment was scrubbed... Name: klibc-1.1.14-fstype-segv-1.patch

flight 21952 qemu-upstream-unstable real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/21952/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-intel 7 redhat-install fail REGR. vs. 20054 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 13 guest-stop

flight 21930 qemu-upstream-unstable real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/21930/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-intel 7 redhat-install fail REGR. vs. 20054 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-winxpsp3-vcpus1 7

flight 21993 qemu-upstream-unstable real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/21993/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-intel 7 redhat-install fail REGR. vs. 20054 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 8

This picks up a pile of fixes from master. Notable highlights: - Fix for CVE-2015-3164 in Xwayland - Fix int10 setup for vesa - Fix regression in server-interpreted auth - Fix fb setup on big-endian CPUs - Build fix for for gcc5 Complete changelog: Aaron Plattner (2): xfree86: Fix xf86_check_platform_slot's handling of PCI xfree86: Add GPU screens even if there are no active

Time for another release candidate. Long past time, to be honest. Please speak up soon if you have a favorite patch or series that isn't in yet. Aaron Plattner (1):       privates: Clear screen-specific keys during CloseScreen Adam Jackson (6):       glxproxy: Fix an obvious thinko in QueryExtensionsString       render: Simplify SProcRenderScale       rootless: Fix bogus handling of broken

On 11/21/2017 12:15 PM, Christian Borntraeger wrote: > > > On 11/21/2017 07:39 PM, Jens Axboe wrote: >> On 11/21/2017 11:27 AM, Jens Axboe wrote: >>> On 11/21/2017 11:12 AM, Christian Borntraeger wrote: >>>> >>>> >>>> On 11/21/2017 07:09 PM, Jens Axboe wrote: >>>>> On 11/21/2017 10:27 AM, Jens Axboe wrote:

Get this building on GNU and BSD systems. J?rg Billeter: Fix grep pattern in Makefile.am Matthieu Herrb: include <time.h> before <utmp.h>. Required on some systems. git tag: sessreg-1.0.2 http://xorg.freedesktop.org/archive/individual/app/sessreg-1.0.2.tar.bz2 MD5: bee5d87d40615e67c84ab0b0c65049ba sessreg-1.0.2.tar.bz2 SHA1: 2f2a36967ecffb29461ae28def3b013955e584dd