similar to: [PATCH net-next V2] virtio-net: don't do header check for dodgy gso packets

There's no need to do header check for virito-net since: - Host set dodgy for all gso packets from guest and check the header. - Host should prepare for all kinds of evil packets from guest, since malicious guest can send any kinds of packet. So this patch sets NETIF_F_GSO_ROBUST for virtio-net to skip the check. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin

There's no need to do header check for virito-net since: - Host set dodgy for all gso packets from guest and check the header. - Host should prepare for all kinds of evil packets from guest, since malicious guest can send any kinds of packet. So this patch sets NETIF_F_GSO_ROBUST for virtio-net to skip the check. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin

This reverts commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4. Now that GSO functionality can correctly track if the fragment id has been selected and select a fragment id if necessary, we can re-enable UFO on tap/macvap and virtio devices. Signed-off-by: Vladislav Yasevich <vyasevic at redhat.com> --- drivers/net/macvtap.c | 13 ++++++++----- drivers/net/tun.c | 19

This reverts commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4. Now that GSO functionality can correctly track if the fragment id has been selected and select a fragment id if necessary, we can re-enable UFO on tap/macvap and virtio devices. Signed-off-by: Vladislav Yasevich <vyasevic at redhat.com> --- drivers/net/macvtap.c | 13 ++++++++----- drivers/net/tun.c | 19

This reverts commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4. Now that UFO functionality can correctly track the fragment id has been selected and select a fragment id if necessary, we can re-enable UFO on tap/macvap and virtio devices. Signed-off-by: Vladislav Yasevich <vyasevic at redhat.com> --- drivers/net/macvtap.c | 13 ++++++++----- drivers/net/tun.c | 19

This reverts commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4. Now that UFO functionality can correctly track the fragment id has been selected and select a fragment id if necessary, we can re-enable UFO on tap/macvap and virtio devices. Signed-off-by: Vladislav Yasevich <vyasevic at redhat.com> --- drivers/net/macvtap.c | 13 ++++++++----- drivers/net/tun.c | 19

This reverts commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4. Now that we've split UFO into v4 and v6 version, we can turn back UFO support for ipv4. Full IPv6 support will come later as it requires extending vnet header structure. Any older VM that assumes IPv6 support is included in UFO will continue to use UFO and the host will generate fragment ids for it, thus preserving connectivity.

This reverts commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4. Now that we've split UFO into v4 and v6 version, we can turn back UFO support for ipv4. Full IPv6 support will come later as it requires extending vnet header structure. Any older VM that assumes IPv6 support is included in UFO will continue to use UFO and the host will generate fragment ids for it, thus preserving connectivity.

Signed-off-by: Micha? Miros?aw <mirq-linux at rere.qmqm.pl> --- drivers/net/virtio_net.c | 46 +++++++++++++++++++--------------------------- 1 files changed, 19 insertions(+), 27 deletions(-) This is an example conversion to hw_features when constraints are constant and can be detected at init time. Build tested only. diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c

Signed-off-by: Micha? Miros?aw <mirq-linux at rere.qmqm.pl> --- drivers/net/virtio_net.c | 46 +++++++++++++++++++--------------------------- 1 files changed, 19 insertions(+), 27 deletions(-) This is an example conversion to hw_features when constraints are constant and can be detected at init time. Build tested only. diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c

IPv6 does not allow fragmentation by routers, so there is no fragmentation ID in the fixed header. UFO for IPv6 requires the ID to be passed separately, but there is no provision for this in the virtio net protocol. Until recently our software implementation of UFO/IPv6 generated a new ID, but this was a bug. Now we will use ID=0 for any UFO/IPv6 packet passed through a tap, which is even

IPv6 does not allow fragmentation by routers, so there is no fragmentation ID in the fixed header. UFO for IPv6 requires the ID to be passed separately, but there is no provision for this in the virtio net protocol. Until recently our software implementation of UFO/IPv6 generated a new ID, but this was a bug. Now we will use ID=0 for any UFO/IPv6 packet passed through a tap, which is even

On Thu, Oct 30, 2014 at 06:27:12PM +0000, Ben Hutchings wrote: > IPv6 does not allow fragmentation by routers, so there is no > fragmentation ID in the fixed header. UFO for IPv6 requires the ID to > be passed separately, but there is no provision for this in the virtio > net protocol. > > Until recently our software implementation of UFO/IPv6 generated a new > ID, but this

IPv6 does not allow fragmentation by routers, so there is no fragmentation ID in the fixed header. UFO for IPv6 requires the ID to be passed separately, but there is no provision for this in the virtio net protocol. Until recently our software implementation of UFO/IPv6 generated a new ID, but this was a bug. Now we will use ID=0 for any UFO/IPv6 packet passed through a tap, which is even

IPv6 does not allow fragmentation by routers, so there is no fragmentation ID in the fixed header. UFO for IPv6 requires the ID to be passed separately, but there is no provision for this in the virtio net protocol. Until recently our software implementation of UFO/IPv6 generated a new ID, but this was a bug. Now we will use ID=0 for any UFO/IPv6 packet passed through a tap, which is even

On Wed, Dec 17, 2014 at 01:20:46PM -0500, Vladislav Yasevich wrote: > Split IPv6 support for UFO into its own feature similiar to TSO. > This will later allow us to re-enable UFO support for virtio-net > devices. > > Signed-off-by: Vladislav Yasevich <vyasevic at redhat.com> > --- > include/linux/netdev_features.h | 7 +++++-- > include/linux/netdevice.h | 1

On Wed, Dec 17, 2014 at 01:20:46PM -0500, Vladislav Yasevich wrote: > Split IPv6 support for UFO into its own feature similiar to TSO. > This will later allow us to re-enable UFO support for virtio-net > devices. > > Signed-off-by: Vladislav Yasevich <vyasevic at redhat.com> > --- > include/linux/netdev_features.h | 7 +++++-- > include/linux/netdevice.h | 1

On 12/17/2014 05:45 PM, Michael S. Tsirkin wrote: > On Wed, Dec 17, 2014 at 01:20:46PM -0500, Vladislav Yasevich wrote: >> Split IPv6 support for UFO into its own feature similiar to TSO. >> This will later allow us to re-enable UFO support for virtio-net >> devices. >> >> Signed-off-by: Vladislav Yasevich <vyasevic at redhat.com> >> --- >>

On 12/17/2014 05:45 PM, Michael S. Tsirkin wrote: > On Wed, Dec 17, 2014 at 01:20:46PM -0500, Vladislav Yasevich wrote: >> Split IPv6 support for UFO into its own feature similiar to TSO. >> This will later allow us to re-enable UFO support for virtio-net >> devices. >> >> Signed-off-by: Vladislav Yasevich <vyasevic at redhat.com> >> --- >>

On 12/18/2014 02:54 AM, Michael S. Tsirkin wrote: > Cc Dave, pls remember to do this next time otherwise > your patches won't get merged :) > > On Wed, Dec 17, 2014 at 06:31:50PM -0500, Vlad Yasevich wrote: >> On 12/17/2014 05:45 PM, Michael S. Tsirkin wrote: >>> On Wed, Dec 17, 2014 at 01:20:46PM -0500, Vladislav Yasevich wrote: >>>> Split IPv6 support