similar to: [PATCH v7 36/46] vhost/net: suppress compiler warning

On Mon, Dec 01, 2014 at 01:37:40PM +0100, Cornelia Huck wrote: > On Sun, 30 Nov 2014 17:12:13 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > len is always initialized since function is called with size > 0. > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > --- > > drivers/vhost/net.c | 2 +- > >

On Mon, Dec 01, 2014 at 01:37:40PM +0100, Cornelia Huck wrote: > On Sun, 30 Nov 2014 17:12:13 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > len is always initialized since function is called with size > 0. > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > --- > > drivers/vhost/net.c | 2 +- > >

On Mon, Dec 01, 2014 at 03:21:03PM +0100, Cornelia Huck wrote: > On Mon, 1 Dec 2014 15:48:39 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > On Mon, Dec 01, 2014 at 01:37:40PM +0100, Cornelia Huck wrote: > > > On Sun, 30 Nov 2014 17:12:13 +0200 > > > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > >

On Mon, Dec 01, 2014 at 03:21:03PM +0100, Cornelia Huck wrote: > On Mon, 1 Dec 2014 15:48:39 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > On Mon, Dec 01, 2014 at 01:37:40PM +0100, Cornelia Huck wrote: > > > On Sun, 30 Nov 2014 17:12:13 +0200 > > > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > >

On 2020/6/2 ??9:06, Michael S. Tsirkin wrote: > Convert vhost net to use the new format-agnostic API. > In particular, don't poke at vq internals such as the > heads array. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/vhost/net.c | 153 +++++++++++++++++++++++--------------------- > 1 file changed, 81 insertions(+), 72 deletions(-)

On Sun, 30 Nov 2014 17:12:13 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > len is always initialized since function is called with size > 0. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/vhost/net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/net.c

On Mon, 1 Dec 2014 15:48:39 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Mon, Dec 01, 2014 at 01:37:40PM +0100, Cornelia Huck wrote: > > On Sun, 30 Nov 2014 17:12:13 +0200 > > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > > > len is always initialized since function is called with size > 0. > > >

On Sun, 30 Nov 2014 17:12:13 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > len is always initialized since function is called with size > 0. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/vhost/net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/net.c

On Mon, 1 Dec 2014 15:48:39 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Mon, Dec 01, 2014 at 01:37:40PM +0100, Cornelia Huck wrote: > > On Sun, 30 Nov 2014 17:12:13 +0200 > > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > > > len is always initialized since function is called with size > 0. > > >

len is always initialized since function is called with size > 0. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vhost/net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 984242e..54ffbb0 100644 --- a/drivers/vhost/net.c +++ b/drivers/vhost/net.c @@ -501,7 +501,7 @@ static int get_rx_bufs(struct

len is always initialized since function is called with size > 0. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vhost/net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 984242e..54ffbb0 100644 --- a/drivers/vhost/net.c +++ b/drivers/vhost/net.c @@ -501,7 +501,7 @@ static int get_rx_bufs(struct

When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, it will merge big packet into rx vq. Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> --- drivers/vhost/vsock.c | 117 +++++++++++++++++++++++++++++++------- include/linux/virtio_vsock.h | 1 + include/uapi/linux/virtio_vsock.h | 5 ++ 3 files changed, 102 insertions(+), 21 deletions(-) diff --git

When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, it will merge big packet into rx vq. Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> --- drivers/vhost/vsock.c | 117 +++++++++++++++++++++++++++++++------- include/linux/virtio_vsock.h | 1 + include/uapi/linux/virtio_vsock.h | 5 ++ 3 files changed, 102 insertions(+), 21 deletions(-) diff --git

Hi all: This RFC implement packed ring layout. The code were tested with Tiwei's RFC V2 a thttps://lkml.org/lkml/2018/4/1/48. Some fixups and tweaks were needed on top of Tiwei's code to make it run. TCP stream and pktgen does not show obvious difference compared with split ring. Changes from V2: - do not use & in checking desc_event_flags - off should be most significant bit -

Hi all: This RFC implement packed ring layout. The code were tested with Tiwei's RFC V2 a thttps://lkml.org/lkml/2018/4/1/48. Some fixups and tweaks were needed on top of Tiwei's code to make it run. TCP stream and pktgen does not show obvious difference compared with split ring. Changes from V2: - do not use & in checking desc_event_flags - off should be most significant bit -

When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, it will merge big packet into rx vq. Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> --- drivers/vhost/vsock.c | 111 ++++++++++++++++++++++++++++++-------- include/linux/virtio_vsock.h | 1 + include/uapi/linux/virtio_vsock.h | 5 ++ 3 files changed, 94 insertions(+), 23 deletions(-) diff --git

When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, it will merge big packet into rx vq. Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> --- drivers/vhost/vsock.c | 111 ++++++++++++++++++++++++++++++-------- include/linux/virtio_vsock.h | 1 + include/uapi/linux/virtio_vsock.h | 5 ++ 3 files changed, 94 insertions(+), 23 deletions(-) diff --git

When mergeable buffers are disabled, and the incoming packet is too large for the rx buffer, get_rx_bufs returns success. This was intentional in order for make recvmsg truncate the packet and then handle_rx would detect err != sock_len and drop it. Unfortunately we pass the original sock_len to recvmsg - which means we use parts of iov not fully validated. Fix this up by detecting this overrun

When mergeable buffers are disabled, and the incoming packet is too large for the rx buffer, get_rx_bufs returns success. This was intentional in order for make recvmsg truncate the packet and then handle_rx would detect err != sock_len and drop it. Unfortunately we pass the original sock_len to recvmsg - which means we use parts of iov not fully validated. Fix this up by detecting this overrun

On 2018/12/12 23:37, Michael S. Tsirkin wrote: > On Wed, Dec 12, 2018 at 05:29:31PM +0800, jiangyiwen wrote: >> When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, >> it will merge big packet into rx vq. >> >> Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> > > I feel this approach jumps into making interface changes for > optimizations too