similar to: [PATCH v7 16/46] virtio_blk: v1.0 support

Based on patch by Cornelia Huck. Note: for consistency, and to avoid sparse errors, convert all fields, even those no longer in use for virtio v1.0. Reviewed-by: Thomas Huth <thuth at linux.vnet.ibm.com> Reviewed-by: David Hildenbrand <dahi at linux.vnet.ibm.com> Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> Signed-off-by: Michael S. Tsirkin <mst at

Based on patch by Cornelia Huck. Note: for consistency, and to avoid sparse errors, convert all fields, even those no longer in use for virtio v1.0. Reviewed-by: Thomas Huth <thuth at linux.vnet.ibm.com> Reviewed-by: David Hildenbrand <dahi at linux.vnet.ibm.com> Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> Signed-off-by: Michael S. Tsirkin <mst at

Based on patch by Cornelia Huck. Note: for consistency, and to avoid sparse errors, convert all fields, even those no longer in use for virtio v1.0. Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_blk.h | 15 ++++----- drivers/block/virtio_blk.c | 70

Based on patch by Cornelia Huck. Note: for consistency, and to avoid sparse errors, convert all fields, even those no longer in use for virtio v1.0. Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_blk.h | 15 ++++----- drivers/block/virtio_blk.c | 70

Based on patch by Cornelia Huck. Note: for consistency, and to avoid sparse errors, convert all fields, even those no longer in use for virtio v1.0. Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_blk.h | 15 ++++----- drivers/block/virtio_blk.c | 70

Based on patch by Cornelia Huck. Note: for consistency, and to avoid sparse errors, convert all fields, even those no longer in use for virtio v1.0. Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_blk.h | 15 ++++----- drivers/block/virtio_blk.c | 70

Based on patch by Cornelia Huck. Note: for consistency, and to avoid sparse errors, convert all fields, even those no longer in use for virtio v1.0. Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_blk.h | 15 ++++----- drivers/block/virtio_blk.c | 70

Based on patch by Cornelia Huck. Note: for consistency, and to avoid sparse errors, convert all fields, even those no longer in use for virtio v1.0. Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_blk.h | 15 ++++----- drivers/block/virtio_blk.c | 70

Based on patch by Cornelia Huck. Note: for consistency, and to avoid sparse errors, convert all fields, even those no longer in use for virtio v1.0. Reviewed-by: Thomas Huth <thuth at linux.vnet.ibm.com> Reviewed-by: David Hildenbrand <dahi at linux.vnet.ibm.com> Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> Signed-off-by: Michael S. Tsirkin <mst at

Based on patch by Cornelia Huck. Note: for consistency, and to avoid sparse errors, convert all fields, even those no longer in use for virtio v1.0. Reviewed-by: Thomas Huth <thuth at linux.vnet.ibm.com> Reviewed-by: David Hildenbrand <dahi at linux.vnet.ibm.com> Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> Signed-off-by: Michael S. Tsirkin <mst at

Based on patch by Cornelia Huck. Note: for consistency, and to avoid sparse errors, convert all fields, even those no longer in use for virtio v1.0. Reviewed-by: Thomas Huth <thuth at linux.vnet.ibm.com> Reviewed-by: David Hildenbrand <dahi at linux.vnet.ibm.com> Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> Signed-off-by: Michael S. Tsirkin <mst at

Based on patch by Cornelia Huck. Note: for consistency, and to avoid sparse errors, convert all fields, even those no longer in use for virtio v1.0. Reviewed-by: Thomas Huth <thuth at linux.vnet.ibm.com> Reviewed-by: David Hildenbrand <dahi at linux.vnet.ibm.com> Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> Signed-off-by: Michael S. Tsirkin <mst at

> -----Original Message----- > From: Stefan Hajnoczi [mailto:stefanha at gmail.com] > Sent: Tuesday, March 28, 2017 4:20 AM > To: Liu, Changpeng <changpeng.liu at intel.com> > Cc: virtio-dev at lists.oasis-open.org; virtualization at lists.linux-foundation.org; linux- > kernel at vger.kernel.org; hch at lst.de; qemu-devel at nongnu.org > Subject: Re: [PATCH] virtio-blk:

> -----Original Message----- > From: Stefan Hajnoczi [mailto:stefanha at gmail.com] > Sent: Tuesday, March 28, 2017 4:20 AM > To: Liu, Changpeng <changpeng.liu at intel.com> > Cc: virtio-dev at lists.oasis-open.org; virtualization at lists.linux-foundation.org; linux- > kernel at vger.kernel.org; hch at lst.de; qemu-devel at nongnu.org > Subject: Re: [PATCH] virtio-blk:

Currently virtio-blk driver does not provide discard feature flag, so the filesystems which built on top of the block device will not send discard command. This is okay for HDD backend, but it will impact the performance for SSD backend. Add a feature flag VIRTIO_BLK_F_DISCARD and command VIRTIO_BLK_T_DISCARD to extend exist virtio-blk protocol. virtio-blk protocol uses a single 8 bytes

Currently virtio-blk driver does not provide discard feature flag, so the filesystems which built on top of the block device will not send discard command. This is okay for HDD backend, but it will impact the performance for SSD backend. Add a feature flag VIRTIO_BLK_F_DISCARD and command VIRTIO_BLK_T_DISCARD to extend exist virtio-blk protocol. virtio-blk protocol uses a single 8 bytes

On Mon, Dec 01, 2014 at 09:16:41AM +0100, David Hildenbrand wrote: > > Based on patch by Cornelia Huck. > > > > Note: for consistency, and to avoid sparse errors, > > convert all fields, even those no longer in use > > for virtio v1.0. > > > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> > > Signed-off-by: Michael S.

On Mon, Dec 01, 2014 at 09:16:41AM +0100, David Hildenbrand wrote: > > Based on patch by Cornelia Huck. > > > > Note: for consistency, and to avoid sparse errors, > > convert all fields, even those no longer in use > > for virtio v1.0. > > > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> > > Signed-off-by: Michael S.

Since the need for a special flag to support SCSI passthrough on a block device was added in May 2017 the SCSI passthrough support in virtio-blk has been disabled. It has always been a bad idea (just ask the original author..) and we have virtio-scsi for proper passthrough. The feature also never made it into the virtio 1.0 or later specifications. Signed-off-by: Christoph Hellwig <hch at

Latest virtio spec says the feature bit name is VIRTIO_BLK_F_FLUSH, VIRTIO_BLK_F_WCE is the legacy name. virtio blk header says exactly the reverse - fix that and update driver code to match. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- I'm inclined to merge it for the current kernel - safe and avoids confusion. include/uapi/linux/virtio_blk.h | 6 +++---