similar to: [PATCH v4 11/42] virtio: add legacy feature table support

virtio blk has some legacy feature bits that modern drivers must not negotiate, but are needed for old legacy hosts (e.g. that dn't support virtio scsi). Allow a separate legacy feature table for such cases. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 4 ++++ drivers/virtio/virtio.c | 25 ++++++++++++++++++++++++- 2 files changed, 28

virtio blk has some legacy feature bits that modern drivers must not negotiate, but are needed for old legacy hosts (e.g. that dn't support virtio scsi). Allow a separate legacy feature table for such cases. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 4 ++++ drivers/virtio/virtio.c | 25 ++++++++++++++++++++++++- 2 files changed, 28

virtio blk has some legacy feature bits that modern drivers must not negotiate, but are needed for old legacy hosts (e.g. that dn't support virtio scsi). Allow a separate legacy feature table for such cases. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 4 ++++ drivers/virtio/virtio.c | 18 +++++++++++++++++- 2 files changed, 21 insertions(+), 1

virtio blk has some legacy feature bits that modern drivers must not negotiate, but are needed for old legacy hosts (e.g. that dn't support virtio scsi). Allow a separate legacy feature table for such cases. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 4 ++++ drivers/virtio/virtio.c | 18 +++++++++++++++++- 2 files changed, 21 insertions(+), 1

virtio-blk has some legacy feature bits that modern drivers must not negotiate, but are needed for old legacy hosts (that e.g. don't support virtio-scsi). Allow a separate legacy feature table for such cases. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 4 ++++ drivers/virtio/virtio.c | 25 ++++++++++++++++++++++++- 2 files changed, 28

virtio-blk has some legacy feature bits that modern drivers must not negotiate, but are needed for old legacy hosts (that e.g. don't support virtio-scsi). Allow a separate legacy feature table for such cases. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 4 ++++ drivers/virtio/virtio.c | 25 ++++++++++++++++++++++++- 2 files changed, 28

virtio-blk has some legacy feature bits that modern drivers must not negotiate, but are needed for old legacy hosts (that e.g. don't support virtio-scsi). Allow a separate legacy feature table for such cases. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 4 ++++ drivers/virtio/virtio.c | 25 ++++++++++++++++++++++++- 2 files changed, 28

virtio-blk has some legacy feature bits that modern drivers must not negotiate, but are needed for old legacy hosts (that e.g. don't support virtio-scsi). Allow a separate legacy feature table for such cases. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 4 ++++ drivers/virtio/virtio.c | 25 ++++++++++++++++++++++++- 2 files changed, 28

virtio-blk has some legacy feature bits that modern drivers must not negotiate, but are needed for old legacy hosts (that e.g. don't support virtio-scsi). Allow a separate legacy feature table for such cases. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Reviewed-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- include/linux/virtio.h | 4 ++++ drivers/virtio/virtio.c

virtio-blk has some legacy feature bits that modern drivers must not negotiate, but are needed for old legacy hosts (that e.g. don't support virtio-scsi). Allow a separate legacy feature table for such cases. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Reviewed-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- include/linux/virtio.h | 4 ++++ drivers/virtio/virtio.c

virtio-blk has some legacy feature bits that modern drivers must not negotiate, but are needed for old legacy hosts (that e.g. don't support virtio-scsi). Allow a separate legacy feature table for such cases. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 4 ++++ drivers/virtio/virtio.c | 25 ++++++++++++++++++++++++- 2 files changed, 28

virtio-blk has some legacy feature bits that modern drivers must not negotiate, but are needed for old legacy hosts (that e.g. don't support virtio-scsi). Allow a separate legacy feature table for such cases. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 4 ++++ drivers/virtio/virtio.c | 25 ++++++++++++++++++++++++- 2 files changed, 28

On Tue, Nov 25, 2014 at 06:53:42PM +0100, Cornelia Huck wrote: > On Tue, 25 Nov 2014 18:42:09 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > virtio blk has some legacy feature bits that modern drivers > > virtio-blk > > > must not negotiate, but are needed for old legacy hosts > > (e.g. that dn't support virtio scsi). >

On Tue, Nov 25, 2014 at 06:53:42PM +0100, Cornelia Huck wrote: > On Tue, 25 Nov 2014 18:42:09 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > virtio blk has some legacy feature bits that modern drivers > > virtio-blk > > > must not negotiate, but are needed for old legacy hosts > > (e.g. that dn't support virtio scsi). >

On Tue, 25 Nov 2014 18:42:09 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > virtio blk has some legacy feature bits that modern drivers virtio-blk > must not negotiate, but are needed for old legacy hosts > (e.g. that dn't support virtio scsi). (that e.g. don't support virtio-scsi) > Allow a separate legacy feature table for such cases. > >

legacy_only flag is now unused, drop it from core. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 2 -- drivers/virtio/virtio.c | 4 ---- 2 files changed, 6 deletions(-) diff --git a/include/linux/virtio.h b/include/linux/virtio.h index d666bcb..d09e093 100644 --- a/include/linux/virtio.h +++ b/include/linux/virtio.h @@ -134,7 +134,6 @@ int

legacy_only flag is now unused, drop it from core. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 2 -- drivers/virtio/virtio.c | 4 ---- 2 files changed, 6 deletions(-) diff --git a/include/linux/virtio.h b/include/linux/virtio.h index d666bcb..d09e093 100644 --- a/include/linux/virtio.h +++ b/include/linux/virtio.h @@ -134,7 +134,6 @@ int

balloon device is not part of virtio 1.0 spec. Still, it's easy enough to make it handle endian-ness exactly as other virtio 1.0 devices: what we gain from this, is that there's no need to special-case it in virtio core. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_balloon.h | 5 +++-- drivers/virtio/virtio_balloon.c | 4 ++-- 2 files

balloon device is not part of virtio 1.0 spec. Still, it's easy enough to make it handle endian-ness exactly as other virtio 1.0 devices: what we gain from this, is that there's no need to special-case it in virtio core. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_balloon.h | 5 +++-- drivers/virtio/virtio_balloon.c | 4 ++-- 2 files

Some drivers can't support all features in all configurations. At the moment we blindly set FEATURES_OK and later FAILED. Support this better by adding a callback drivers can use to do some early checks. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio.c | 6 ++++++ include/linux/virtio.h | 1 + 2 files changed, 7 insertions(+) diff --git