similar to: [PATCH 1/2] virito: introduce methods of fixing device features

Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies were missed). In this case, driver should detect and disable the buggy features by itself. This patch introduces driver specific fix_features() method which is called just before features finalizing to detect and disable buggy features advertised by host. Virtio-net will be the first

Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies were missed). In this case, driver should detect and disable the buggy features by itself. This patch introduces driver specific fix_features() method which is called just before features finalizing to detect and disable buggy features advertised by host. Virtio-net will be the first

On 11/13/2014 01:52 PM, Jason Wang wrote: > This patch tries to detect the possible buggy features advertised by host > and fix them. One example is booting virtio-net with only ctrl_vq disabled, > qemu may still advertise many features which depends on it. This will > trigger several BUG()s in virtnet_send_command(). > > This patch utilizes the fix_features() method, and

On 11/13/2014 01:52 PM, Jason Wang wrote: > This patch tries to detect the possible buggy features advertised by host > and fix them. One example is booting virtio-net with only ctrl_vq disabled, > qemu may still advertise many features which depends on it. This will > trigger several BUG()s in virtnet_send_command(). > > This patch utilizes the fix_features() method, and

On Thu, 13 Nov 2014 13:52:54 +0800 Jason Wang <jasowang at redhat.com> wrote: > This patch tries to detect the possible buggy features advertised by host > and fix them. One example is booting virtio-net with only ctrl_vq disabled, > qemu may still advertise many features which depends on it. This will > trigger several BUG()s in virtnet_send_command(). > > This patch

On Thu, 13 Nov 2014 13:52:54 +0800 Jason Wang <jasowang at redhat.com> wrote: > This patch tries to detect the possible buggy features advertised by host > and fix them. One example is booting virtio-net with only ctrl_vq disabled, > qemu may still advertise many features which depends on it. This will > trigger several BUG()s in virtnet_send_command(). > > This patch

Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies were missed). In this case, driver should detect and disable the buggy features by itself. This patch introduces driver specific sanitize_features() method which is called just before features finalizing to detect and disable buggy features advertised by host. Virtio-net will be the

Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies were missed). In this case, driver should detect and disable the buggy features by itself. This patch introduces driver specific sanitize_features() method which is called just before features finalizing to detect and disable buggy features advertised by host. Virtio-net will be the

This patch tries to detect the possible buggy features advertised by host and fix them. One example is booting virtio-net with only ctrl_vq disabled, qemu may still advertise many features which depends on it. This will trigger several BUG()s in virtnet_send_command(). This patch utilizes the fix_features() method, and disables all features that depends on ctrl_vq if it was not advertised. This

This patch tries to detect the possible buggy features advertised by host and fix them. One example is current booting virtio-net with only ctrl_vq disabled, qemu may still advertise many features which depends it. This will trigger several BUG()s in virtnet_send_command(). This patch utilizes the fix_features() method, and disable all features that depends on ctrl_vq if it was not advertised.

This patch tries to detect the possible buggy features advertised by host and fix them. One example is current booting virtio-net with only ctrl_vq disabled, qemu may still advertise many features which depends it. This will trigger several BUG()s in virtnet_send_command(). This patch utilizes the fix_features() method, and disable all features that depends on ctrl_vq if it was not advertised.

On 11/13/2014 04:46 PM, Cornelia Huck wrote: > On Thu, 13 Nov 2014 13:52:53 +0800 > Jason Wang <jasowang at redhat.com> wrote: > > typo in subject-prefix: s/virito/virtio/ > Will correct this. >> Buggy host may advertised buggy host features (a usual case is that host >> advertise a feature whose dependencies were missed). In this case, driver >> should

On 11/13/2014 04:46 PM, Cornelia Huck wrote: > On Thu, 13 Nov 2014 13:52:53 +0800 > Jason Wang <jasowang at redhat.com> wrote: > > typo in subject-prefix: s/virito/virtio/ > Will correct this. >> Buggy host may advertised buggy host features (a usual case is that host >> advertise a feature whose dependencies were missed). In this case, driver >> should

This patch tries to detect the possible buggy features advertised by host and sanitize them. One example is booting virtio-net with only ctrl_vq disabled, qemu may still advertise many features which depends on it. This will trigger several BUG()s in virtnet_send_command(). This patch utilizes the sanitize_features() method, and disables all features that depends on ctrl_vq if it was not

This patch tries to detect the possible buggy features advertised by host and sanitize them. One example is booting virtio-net with only ctrl_vq disabled, qemu may still advertise many features which depends on it. This will trigger several BUG()s in virtnet_send_command(). This patch utilizes the sanitize_features() method, and disables all features that depends on ctrl_vq if it was not

On 11/19/2014 04:59 PM, Michael S. Tsirkin wrote: > On Wed, Nov 19, 2014 at 02:35:39PM +0800, Jason Wang wrote: >> This patch validates feature dependencies during probe and fail the probing >> if a dependency is missed. This fixes the issues of hitting BUG() >> when qemu fails to advertise features correctly. One example is booting >> guest with ctrl_vq=off through

On 11/19/2014 04:59 PM, Michael S. Tsirkin wrote: > On Wed, Nov 19, 2014 at 02:35:39PM +0800, Jason Wang wrote: >> This patch validates feature dependencies during probe and fail the probing >> if a dependency is missed. This fixes the issues of hitting BUG() >> when qemu fails to advertise features correctly. One example is booting >> guest with ctrl_vq=off through

On 11/17/2014 06:08 PM, Michael S. Tsirkin wrote: > On Mon, Nov 17, 2014 at 05:17:18PM +0800, Jason Wang wrote: >> This patch tries to detect the possible buggy features advertised by host >> and sanitize them. One example is booting virtio-net with only ctrl_vq >> disabled, qemu may still advertise many features which depends on it. This >> will trigger several BUG()s

On 11/17/2014 06:08 PM, Michael S. Tsirkin wrote: > On Mon, Nov 17, 2014 at 05:17:18PM +0800, Jason Wang wrote: >> This patch tries to detect the possible buggy features advertised by host >> and sanitize them. One example is booting virtio-net with only ctrl_vq >> disabled, qemu may still advertise many features which depends on it. This >> will trigger several BUG()s

This patch validates feature dependencies during probe and fail the probing if a dependency is missed. This fixes the issues of hitting BUG() when qemu fails to advertise features correctly. One example is booting guest with ctrl_vq=off through qemu. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Cornelia Huck <cornelia.huck at