similar to: [PATCH RFC v3 3/3] virtio-net: optimize free_old_xmit_skbs stats

From: Jason Wang <jasowang at redhat.com> We already have counters for sent packets and sent bytes. Use them to reduce the number of u64_stats_update_begin/end(). Take care not to bother with stats update when called speculatively. Based on a patch by Jason Wang. Cc: Rusty Russell <rusty at rustcorp.com.au> Signed-off-by: Jason Wang <jasowang at redhat.com> Signed-off-by:

From: Jason Wang <jasowang at redhat.com> We already have counters for sent packets and sent bytes. Use them to reduce the number of u64_stats_update_begin/end(). Take care not to bother with stats update when called speculatively. Based on a patch by Jason Wang. Cc: Rusty Russell <rusty at rustcorp.com.au> Signed-off-by: Jason Wang <jasowang at redhat.com> Signed-off-by:

Improve tx batching using byte queue limits. Should be especially effective for MQ. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 14f4cda..b83d39d 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -227,6 +227,7 @@

Improve tx batching using byte queue limits. Should be especially effective for MQ. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 14f4cda..b83d39d 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -227,6 +227,7 @@

We already have counters for sent/recv packets and sent/recv bytes. Doing a batched update to reduce the number of u64_stats_update_begin/end(). Take care not to bother with stats update when called speculatively. Cc: Willem de Bruijn <willemb at google.com> Signed-off-by: Jason Wang <jasowang at redhat.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> ---

We already have counters for sent/recv packets and sent/recv bytes. Doing a batched update to reduce the number of u64_stats_update_begin/end(). Take care not to bother with stats update when called speculatively. Cc: Willem de Bruijn <willemb at google.com> Signed-off-by: Jason Wang <jasowang at redhat.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> ---

Improve tx batching using byte queue limits. Should be especially effective for MQ. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index a9bf178..8dea411 100644 --- a/drivers/net/virtio_net.c +++

Improve tx batching using byte queue limits. Should be especially effective for MQ. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index a9bf178..8dea411 100644 --- a/drivers/net/virtio_net.c +++

Accumulate the sent packets and sent bytes in local variables and perform a single u64_stats_update_begin/end() after. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) diff --git

Accumulate the sent packets and sent bytes in local variables and perform a single u64_stats_update_begin/end() after. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) diff --git

On Wed, Oct 15, 2014 at 09:49:01AM +0000, David Laight wrote: > From: Of Michael S. Tsirkin > > On Wed, Oct 15, 2014 at 03:25:27PM +0800, Jason Wang wrote: > > > Accumulate the sent packets and sent bytes in local variables and perform a > > > single u64_stats_update_begin/end() after. > > > > > > Cc: Rusty Russell <rusty at rustcorp.com.au> >

From: Michael S. Tsirkin > On Wed, Oct 15, 2014 at 09:49:01AM +0000, David Laight wrote: > > From: Of Michael S. Tsirkin > > > On Wed, Oct 15, 2014 at 03:25:27PM +0800, Jason Wang wrote: > > > > Accumulate the sent packets and sent bytes in local variables and perform a > > > > single u64_stats_update_begin/end() after. > > > > > > >

From: Michael S. Tsirkin > On Wed, Oct 15, 2014 at 09:49:01AM +0000, David Laight wrote: > > From: Of Michael S. Tsirkin > > > On Wed, Oct 15, 2014 at 03:25:27PM +0800, Jason Wang wrote: > > > > Accumulate the sent packets and sent bytes in local variables and perform a > > > > single u64_stats_update_begin/end() after. > > > > > > >

From: Of Michael S. Tsirkin > On Wed, Oct 15, 2014 at 03:25:27PM +0800, Jason Wang wrote: > > Accumulate the sent packets and sent bytes in local variables and perform a > > single u64_stats_update_begin/end() after. > > > > Cc: Rusty Russell <rusty at rustcorp.com.au> > > Cc: Michael S. Tsirkin <mst at redhat.com> > > Signed-off-by: Jason Wang

From: Of Michael S. Tsirkin > On Wed, Oct 15, 2014 at 03:25:27PM +0800, Jason Wang wrote: > > Accumulate the sent packets and sent bytes in local variables and perform a > > single u64_stats_update_begin/end() after. > > > > Cc: Rusty Russell <rusty at rustcorp.com.au> > > Cc: Michael S. Tsirkin <mst at redhat.com> > > Signed-off-by: Jason Wang

On Wed, Oct 15, 2014 at 03:25:27PM +0800, Jason Wang wrote: > Accumulate the sent packets and sent bytes in local variables and perform a > single u64_stats_update_begin/end() after. > > Cc: Rusty Russell <rusty at rustcorp.com.au> > Cc: Michael S. Tsirkin <mst at redhat.com> > Signed-off-by: Jason Wang <jasowang at redhat.com> Not sure how much it's worth

On newer hosts that support delayed tx interrupts, we probably don't have much to gain from orphaning packets early. Based on patch by Jason Wang. Note: this might degrade performance for hosts without event idx support. Should be addressed by the next patch. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 133

On newer hosts that support delayed tx interrupts, we probably don't have much to gain from orphaning packets early. Based on patch by Jason Wang. Note: this might degrade performance for hosts without event idx support. Should be addressed by the next patch. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 133

On newer hosts that support delayed tx interrupts, we probably don't have much to gain from orphaning packets early. Note: this might degrade performance for hosts without event idx support. Should be addressed by the next patch. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com>

On newer hosts that support delayed tx interrupts, we probably don't have much to gain from orphaning packets early. Note: this might degrade performance for hosts without event idx support. Should be addressed by the next patch. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com>