Displaying 20 results from an estimated 1000 matches similar to: "[PATCH 33/39] virtio: pci: remove DEFINE_PCI_DEVICE_TABLE macro"
2014 Jul 18
0
[PATCH 23/25] virtio: Replace DEFINE_PCI_DEVICE_TABLE macro use
We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet
kernel coding style guidelines. This issue was reported by checkpatch.
Signed-off-by: Benoit Taine <benoit.taine at lip6.fr>
---
Tested by compilation without errors.
drivers/virtio/virtio_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_pci.c
2014 Sep 17
2
[PATCH] virtio: pci: Use SIMPLE_DEV_PM_OPS macro
On Tuesday, September 09, 2014 9:14 AM, Rusty Russell wrote:
> Jingoo Han <jg1.han at samsung.com> writes:
> > Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler.
> >
> > Signed-off-by: Jingoo Han <jg1.han at samsung.com>
>
> This patch is obviously wrong. It won't compile without
> CONFIG_PM_SLEEP.
No, there is no compile issue.
When,
2014 Sep 17
2
[PATCH] virtio: pci: Use SIMPLE_DEV_PM_OPS macro
On Tuesday, September 09, 2014 9:14 AM, Rusty Russell wrote:
> Jingoo Han <jg1.han at samsung.com> writes:
> > Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler.
> >
> > Signed-off-by: Jingoo Han <jg1.han at samsung.com>
>
> This patch is obviously wrong. It won't compile without
> CONFIG_PM_SLEEP.
No, there is no compile issue.
When,
2013 Nov 25
1
[PATCH] virtio: pci: remove unnecessary pci_set_drvdata()
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han at samsung.com>
---
drivers/virtio/virtio_pci.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
index a37c699..a416f9b 100644
---
2013 Nov 25
1
[PATCH] virtio: pci: remove unnecessary pci_set_drvdata()
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han at samsung.com>
---
drivers/virtio/virtio_pci.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
index a37c699..a416f9b 100644
---
2014 Sep 05
2
[PATCH] virtio: pci: Use SIMPLE_DEV_PM_OPS macro
Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler.
Signed-off-by: Jingoo Han <jg1.han at samsung.com>
---
drivers/virtio/virtio_pci.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
index 3d1463c6b120..c5fbdb4023d1 100644
--- a/drivers/virtio/virtio_pci.c
+++ b/drivers/virtio/virtio_pci.c
@@
2014 Sep 05
2
[PATCH] virtio: pci: Use SIMPLE_DEV_PM_OPS macro
Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler.
Signed-off-by: Jingoo Han <jg1.han at samsung.com>
---
drivers/virtio/virtio_pci.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
index 3d1463c6b120..c5fbdb4023d1 100644
--- a/drivers/virtio/virtio_pci.c
+++ b/drivers/virtio/virtio_pci.c
@@
2014 Jul 21
0
[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
[+cc Jingoo]
On Fri, Jul 18, 2014 at 12:50 PM, James Bottomley
<James.Bottomley at hansenpartnership.com> wrote:
> On Fri, 2014-07-18 at 11:17 -0700, Greg KH wrote:
>> On Fri, Jul 18, 2014 at 09:54:32AM -0700, James Bottomley wrote:
>> > On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote:
>> > > On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
2014 Sep 09
0
[PATCH] virtio: pci: Use SIMPLE_DEV_PM_OPS macro
Jingoo Han <jg1.han at samsung.com> writes:
> Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler.
>
> Signed-off-by: Jingoo Han <jg1.han at samsung.com>
This patch is obviously wrong. It won't compile without
CONFIG_PM_SLEEP.
Cheers,
Rusty.
> ---
> drivers/virtio/virtio_pci.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
2014 Jul 18
9
[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
We should prefer `const struct pci_device_id` over
`DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
This issue was reported by checkpatch.
A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/):
// <smpl>
@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@
- DEFINE_PCI_DEVICE_TABLE(i)
+ const
2014 Jul 18
9
[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
We should prefer `const struct pci_device_id` over
`DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
This issue was reported by checkpatch.
A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/):
// <smpl>
@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@
- DEFINE_PCI_DEVICE_TABLE(i)
+ const
2014 Sep 15
0
[PATCH] virtio-pci: also bind to Amazon PCI vendor ID
On Sun, Sep 14, 2014 at 08:29:33PM -0700, Anthony Liguori wrote:
> From: Anthony Liguori <aliguori at amazon.com>
>
> See https://issues.oasis-open.org/browse/VIRTIO-16 although it
> was prematurely closed.
The reason it was closed is described in the comments. and I quote:
" I think anyone can use a different subsystem vendor id and whql the
driver. virtio-102 will make
2014 Sep 15
3
[PATCH] virtio-pci: also bind to Amazon PCI vendor ID
From: Anthony Liguori <aliguori at amazon.com>
See https://issues.oasis-open.org/browse/VIRTIO-16 although it
was prematurely closed.
Red Hat has non-redistributable Windows drivers and Microsoft
will not allow anyone else to WHQL certify drivers using that
vendor ID. That makes it impossible to use virtio drivers with
a Windows guest without changing the vendor ID.
Cc: Matt Wilson
2014 Sep 15
3
[PATCH] virtio-pci: also bind to Amazon PCI vendor ID
From: Anthony Liguori <aliguori at amazon.com>
See https://issues.oasis-open.org/browse/VIRTIO-16 although it
was prematurely closed.
Red Hat has non-redistributable Windows drivers and Microsoft
will not allow anyone else to WHQL certify drivers using that
vendor ID. That makes it impossible to use virtio drivers with
a Windows guest without changing the vendor ID.
Cc: Matt Wilson
2014 Sep 15
0
[PATCH] virtio-pci: also bind to Amazon PCI vendor ID
On Mon, Sep 15, 2014 at 07:24:33AM -0700, Anthony Liguori wrote:
> Hi Michael,
>
> On Mon, Sep 15, 2014 at 1:20 AM, Michael S. Tsirkin <mst at redhat.com> wrote:
> > On Sun, Sep 14, 2014 at 08:29:33PM -0700, Anthony Liguori wrote:
> >> From: Anthony Liguori <aliguori at amazon.com>
> >>
> >> See https://issues.oasis-open.org/browse/VIRTIO-16
2014 Sep 18
0
[PATCH] virtio: pci: Use SIMPLE_DEV_PM_OPS macro
Jingoo Han <jg1.han at samsung.com> writes:
> On Tuesday, September 09, 2014 9:14 AM, Rusty Russell wrote:
>> Jingoo Han <jg1.han at samsung.com> writes:
>> > Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler.
>> >
>> > Signed-off-by: Jingoo Han <jg1.han at samsung.com>
>>
>> This patch is obviously wrong. It won't
2015 Nov 10
2
[PATCH v4 0/6] virtio core DMA API conversion
On Mon, 2015-11-09 at 18:18 -0800, Andy Lutomirski wrote:
>
> /* Qumranet donated their vendor ID for devices 0x1000 thru 0x10FF.
> */
> static const struct pci_device_id virtio_pci_id_table[] = {
> ??????? { PCI_DEVICE(0x1af4, PCI_ANY_ID) },
> ??????? { 0 }
> };
>
> Can we match on that range?
We can, but the problem remains, how do we differenciate an existing
2015 Nov 10
2
[PATCH v4 0/6] virtio core DMA API conversion
On Mon, 2015-11-09 at 18:18 -0800, Andy Lutomirski wrote:
>
> /* Qumranet donated their vendor ID for devices 0x1000 thru 0x10FF.
> */
> static const struct pci_device_id virtio_pci_id_table[] = {
> ??????? { PCI_DEVICE(0x1af4, PCI_ANY_ID) },
> ??????? { 0 }
> };
>
> Can we match on that range?
We can, but the problem remains, how do we differenciate an existing
2015 Nov 10
0
[PATCH v4 0/6] virtio core DMA API conversion
On Mon, Nov 9, 2015 at 9:28 PM, Benjamin Herrenschmidt
<benh at kernel.crashing.org> wrote:
> On Mon, 2015-11-09 at 18:18 -0800, Andy Lutomirski wrote:
>>
>> /* Qumranet donated their vendor ID for devices 0x1000 thru 0x10FF.
>> */
>> static const struct pci_device_id virtio_pci_id_table[] = {
>> { PCI_DEVICE(0x1af4, PCI_ANY_ID) },
>> {
2014 Sep 15
3
[PATCH] virtio-pci: also bind to Amazon PCI vendor ID
Hi Michael,
On Mon, Sep 15, 2014 at 1:20 AM, Michael S. Tsirkin <mst at redhat.com> wrote:
> On Sun, Sep 14, 2014 at 08:29:33PM -0700, Anthony Liguori wrote:
>> From: Anthony Liguori <aliguori at amazon.com>
>>
>> See https://issues.oasis-open.org/browse/VIRTIO-16 although it
>> was prematurely closed.
>
> The reason it was closed is described in the