similar to: [patch] virtio: console: fix error handling for debugfs_create_dir()

On Friday 19 July 2013, Dan Carpenter wrote: > debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. > Also my static checker doesn't like it when we print the error code, but > it's always just NULL. > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> This looks wrong. debugfs_create_dir intentionally returns non-NULL so failing to create

On Friday 19 July 2013, Dan Carpenter wrote: > debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. > Also my static checker doesn't like it when we print the error code, but > it's always just NULL. > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> This looks wrong. debugfs_create_dir intentionally returns non-NULL so failing to create

On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote: > The PTR_ERR(NULL) here is not useful. > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > --- > v2: completely different > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index 1b456fe..4cf46d8 100644 > --- a/drivers/char/virtio_console.c > +++

On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote: > The PTR_ERR(NULL) here is not useful. > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > --- > v2: completely different > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index 1b456fe..4cf46d8 100644 > --- a/drivers/char/virtio_console.c > +++

On Mon, Jul 29, 2013 at 06:12:31AM -0700, Greg Kroah-Hartman wrote: > On Mon, Jul 29, 2013 at 12:41:31PM +0530, Amit Shah wrote: > > On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote: > > > The PTR_ERR(NULL) here is not useful. > > > > > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > > > --- > > > v2: completely

On Mon, Jul 29, 2013 at 06:12:31AM -0700, Greg Kroah-Hartman wrote: > On Mon, Jul 29, 2013 at 12:41:31PM +0530, Amit Shah wrote: > > On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote: > > > The PTR_ERR(NULL) here is not useful. > > > > > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > > > --- > > > v2: completely

debugfs_create_dir() returns NULL if it fails, there's little point in calling PTR_ERR on it. Signed-off-by: Sasha Levin <sasha.levin at oracle.com> --- drivers/char/virtio_console.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index c594cb1..490b70e 100644 --- a/drivers/char/virtio_console.c

debugfs_create_dir() returns NULL if it fails, there's little point in calling PTR_ERR on it. Signed-off-by: Sasha Levin <sasha.levin at oracle.com> --- drivers/char/virtio_console.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index c594cb1..490b70e 100644 --- a/drivers/char/virtio_console.c

From: Sjur Br?ndeland <sjur.brandeland at stericsson.com> Add information so rproc-serial can be easily recogniced from user space. Add the following information to uevent: DRIVER=virtio_console|virtio_rproc_serial INTERFACE=grand-parent/parent/name Signed-off-by: Sjur Br?ndeland <sjur.brandeland at stericsson.com> --- Hi, I need some way to identify the major/minor number for the

From: Sjur Br?ndeland <sjur.brandeland at stericsson.com> Add information so rproc-serial can be easily recogniced from user space. Add the following information to uevent: DRIVER=virtio_console|virtio_rproc_serial INTERFACE=grand-parent/parent/name Signed-off-by: Sjur Br?ndeland <sjur.brandeland at stericsson.com> --- Hi, I need some way to identify the major/minor number for the

On Saturday 20 July 2013, Dan Carpenter wrote: > On Fri, Jul 19, 2013 at 12:28:41PM +0200, Arnd Bergmann wrote: > > On Friday 19 July 2013, Dan Carpenter wrote: > > > debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. > > > Also my static checker doesn't like it when we print the error code, but > > > it's always just NULL. > >

On Saturday 20 July 2013, Dan Carpenter wrote: > On Fri, Jul 19, 2013 at 12:28:41PM +0200, Arnd Bergmann wrote: > > On Friday 19 July 2013, Dan Carpenter wrote: > > > debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. > > > Also my static checker doesn't like it when we print the error code, but > > > it's always just NULL. > >

On Mon, Jul 29, 2013 at 12:41:31PM +0530, Amit Shah wrote: > On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote: > > The PTR_ERR(NULL) here is not useful. > > > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > > --- > > v2: completely different > > > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c

The PTR_ERR(NULL) here is not useful. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- v2: completely different diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 1b456fe..4cf46d8 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -2215,10 +2215,8 @@ static int __init init(void) } pdrvdata.debugfs_dir =

My static checker complains that this sprintf() can overflow. vdev->index is selected by ida_simple_get() in register_virtio_device() so my reading of the code is that this overflow is theoretically possible. The max value of "id" is configurable and I'm not sure what typical values are. Anyway, it's simple enough to make the buffer larger and I changed it to snprintf() as

My static checker complains that this sprintf() can overflow. vdev->index is selected by ida_simple_get() in register_virtio_device() so my reading of the code is that this overflow is theoretically possible. The max value of "id" is configurable and I'm not sure what typical values are. Anyway, it's simple enough to make the buffer larger and I changed it to snprintf() as

My static checker complains that this sprintf() can overflow but really it can't. Just silence the warning by using snprintf(). Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- v2: the overflow is not possible so just leave the buffer size alone and silence the warning with snprintf(). diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index

My static checker complains that this sprintf() can overflow but really it can't. Just silence the warning by using snprintf(). Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- v2: the overflow is not possible so just leave the buffer size alone and silence the warning with snprintf(). diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index

From: Sjur Br?ndeland <sjur.brandeland at stericsson.com> Use virtio device index for creating unique device port names. Current index allocation in virtio is based on a monotonically increasing variable "index". A better handling of this is to use device index which is allocated by ida. Signed-off-by: Sjur Br?ndeland <sjur.brandeland at stericsson.com> ---

From: Sjur Br?ndeland <sjur.brandeland at stericsson.com> Use virtio device index for creating unique device port names. Current index allocation in virtio is based on a monotonically increasing variable "index". A better handling of this is to use device index which is allocated by ida. Signed-off-by: Sjur Br?ndeland <sjur.brandeland at stericsson.com> ---